[dpdk-stable] please help backporting some patches to LTS release 16.11.5

[dpdk-stable] please help backporting some patches to LTS release 16.11.5

[luca.boccassi]

Hi commit authors (and maintainers),

I didn't manage to apply following commits from upstream to stable branch
16.11: conflict happens. I'm wondering can the authors check the following
list and backport those patches belong to you?

FYI, branch 16.11 is located at tree:
   git://dpdk.org/dpdk-stable

It'd be great if you could do that in one or two weeks. Also, please add a
heading line like below before the commit log body:
    [ backported from upstream commit xxx ]

Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=c4831394c7d1944d8ec27d52c22997f20d19718e

Please let me know if you have any comments, say, need more time, or it's
worthless to packport it. And please send it to "stable@dpdk.org", but not
"dev@dpdk.org".

Thanks.

Luca Boccassi

---
ee5d7bdda  Ajit Khaparde    net/bnxt: fix group info usage
cab278dee  Jianfeng Tan     vhost: fix crash
ae80146c5  Matan Azrad      net/failsafe: fix removed device handling
b365799b3  Nélio Laranjeiro net/mlx5: fix un-supported RSS hash fields use
35906acbf  Olivier Matz     net/bnxt: fix headroom initialization
b692c7e00  Qi Zhang         net/i40e/base: fix reading LLDP configuration
11c52927f  Qi Zhang         net/i40e/base: release spinlock before function returns
2b38f509c  Qi Zhang         net/i40e: exclude LLDP packet count
f64b91b0e  Rasesh Mody      net/qede: replace config option with run-time arg
a36880469  Victor Kaplansky vhost: protect active rings from async ring changes
aa2919592  Wei Zhao         net/ixgbe: fix tunnel filter fail problem
6b75183ac  Wenzhuo Lu       net/ixgbe: fix wrong PBA setting
c7bf62255  Yongseok Koh     net/mlx5: fix handling link status event

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Yongseok Koh]

> On Jan 26, 2018, at 5:30 AM, luca.boccassi@gmail.com wrote:
> 
> Hi commit authors (and maintainers),
> 
> I didn't manage to apply following commits from upstream to stable branch
> 16.11: conflict happens. I'm wondering can the authors check the following
> list and backport those patches belong to you?
[...]
> c7bf62255  Yongseok Koh     net/mlx5: fix handling link status event

I don't think it's worth back-porting this patch to 16.11.
The bug was very minor but changes are big.
And in 16.11, it doesn't even have priv_dev_traffic_enable/disable(), which
means this patch could bring another instability.

Please drop the patch for 16.11.5

Thanks
Yongseok

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Luca Boccassi]

On Fri, 2018-01-26 at 18:26 +0000, Yongseok Koh wrote:
> > On Jan 26, 2018, at 5:30 AM, luca.boccassi@gmail.com wrote:
> > 
> > Hi commit authors (and maintainers),
> > 
> > I didn't manage to apply following commits from upstream to stable
> > branch
> > 16.11: conflict happens. I'm wondering can the authors check the
> > following
> > list and backport those patches belong to you?
> 
> [...]
> > c7bf62255  Yongseok Koh     net/mlx5: fix handling link status
> > event
> 
> I don't think it's worth back-porting this patch to 16.11.
> The bug was very minor but changes are big.
> And in 16.11, it doesn't even have priv_dev_traffic_enable/disable(),
> which
> means this patch could bring another instability.
> 
> Please drop the patch for 16.11.5
> 
> Thanks
> Yongseok

Will do, thanks for looking into it.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Matan Azrad]

Hi Luca

From: luca.boccassi@gmail.com, Sent: Friday, January 26, 2018 3:31 PM
> Hi commit authors (and maintainers),
> 
> I didn't manage to apply following commits from upstream to stable branch
> 16.11: conflict happens. I'm wondering can the authors check the following
> list and backport those patches belong to you?
> 
> FYI, branch 16.11 is located at tree:
>    git://dpdk.org/dpdk-stable
> 
> It'd be great if you could do that in one or two weeks. Also, please add a
> heading line like below before the commit log body:
>     [ backported from upstream commit xxx ]
> 
> Example:
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
> k.org%2Fbrowse%2Fdpdk-
> stable%2Fcommit%2F%3Fh%3D16.07%26id%3Dc4831394c7d1944d8ec27d52c2
> 2997f20d19718e&data=02%7C01%7Cmatan%40mellanox.com%7Cb0462279f1
> c8434d196408d564c10643%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C
> 0%7C636525702569275353&sdata=3ohSFBpIsLNVcXk444UP3dOJXOXEPcnJxxl
> %2B%2FEjFIDE%3D&reserved=0
> 
> Please let me know if you have any comments, say, need more time, or it's
> worthless to packport it. And please send it to "stable@dpdk.org", but not
> "dev@dpdk.org".
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> ee5d7bdda  Ajit Khaparde    net/bnxt: fix group info usage
> cab278dee  Jianfeng Tan     vhost: fix crash
> ae80146c5  Matan Azrad      net/failsafe: fix removed device handling

This patch is without Cc:stable so you should not backport it.

> b365799b3  Nélio Laranjeiro net/mlx5: fix un-supported RSS hash fields use
> 35906acbf  Olivier Matz     net/bnxt: fix headroom initialization
> b692c7e00  Qi Zhang         net/i40e/base: fix reading LLDP configuration
> 11c52927f  Qi Zhang         net/i40e/base: release spinlock before function
> returns
> 2b38f509c  Qi Zhang         net/i40e: exclude LLDP packet count
> f64b91b0e  Rasesh Mody      net/qede: replace config option with run-time
> arg
> a36880469  Victor Kaplansky vhost: protect active rings from async ring
> changes
> aa2919592  Wei Zhao         net/ixgbe: fix tunnel filter fail problem
> 6b75183ac  Wenzhuo Lu       net/ixgbe: fix wrong PBA setting
> c7bf62255  Yongseok Koh     net/mlx5: fix handling link status event

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Luca Boccassi]

On Sun, 2018-01-28 at 05:47 +0000, Matan Azrad wrote:
> Hi Luca
> 
> From: luca.boccassi@gmail.com, Sent: Friday, January 26, 2018 3:31 PM
> > Hi commit authors (and maintainers),
> > 
> > I didn't manage to apply following commits from upstream to stable
> > branch
> > 16.11: conflict happens. I'm wondering can the authors check the
> > following
> > list and backport those patches belong to you?
> > 
> > FYI, branch 16.11 is located at tree:
> >    git://dpdk.org/dpdk-stable
> > 
> > It'd be great if you could do that in one or two weeks. Also,
> > please add a
> > heading line like below before the commit log body:
> >     [ backported from upstream commit xxx ]
> > 
> > Example:
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fd
> > pd
> > k.org%2Fbrowse%2Fdpdk-
> > stable%2Fcommit%2F%3Fh%3D16.07%26id%3Dc4831394c7d1944d8ec27d52c2
> > 2997f20d19718e&data=02%7C01%7Cmatan%40mellanox.com%7Cb0462279f1
> > c8434d196408d564c10643%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C
> > 0%7C636525702569275353&sdata=3ohSFBpIsLNVcXk444UP3dOJXOXEPcnJxxl
> > %2B%2FEjFIDE%3D&reserved=0
> > 
> > Please let me know if you have any comments, say, need more time,
> > or it's
> > worthless to packport it. And please send it to "stable@dpdk.org",
> > but not
> > "dev@dpdk.org".
> > 
> > Thanks.
> > 
> > Luca Boccassi
> > 
> > ---
> > ee5d7bdda  Ajit Khaparde    net/bnxt: fix group info usage
> > cab278dee  Jianfeng Tan     vhost: fix crash
> > ae80146c5  Matan Azrad      net/failsafe: fix removed device
> > handling
> 
> This patch is without Cc:stable so you should not backport it.

Great, thanks for checking (the script probably needs a tweak)

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Nélio Laranjeiro]

Hi Luca,

On Fri, Jan 26, 2018 at 01:30:39PM +0000, luca.boccassi@gmail.com wrote:
> Hi commit authors (and maintainers),
> 
> I didn't manage to apply following commits from upstream to stable branch
> 16.11: conflict happens. I'm wondering can the authors check the following
> list and backport those patches belong to you?
> 
> FYI, branch 16.11 is located at tree:
>    git://dpdk.org/dpdk-stable
> 
> It'd be great if you could do that in one or two weeks. Also, please add a
> heading line like below before the commit log body:
>     [ backported from upstream commit xxx ]
> 
> Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=c4831394c7d1944d8ec27d52c22997f20d19718e
> 
> Please let me know if you have any comments, say, need more time, or it's
> worthless to packport it. And please send it to "stable@dpdk.org", but not
> "dev@dpdk.org".
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> b365799b3  Nélio Laranjeiro net/mlx5: fix un-supported RSS hash fields use

You can drop this commit for 16.11

Thanks,

-- 
Nélio Laranjeiro
6WIND

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Luca Boccassi]

On Tue, 2018-01-30 at 15:26 +0100, Nélio Laranjeiro wrote:
> Hi Luca,
> 
> On Fri, Jan 26, 2018 at 01:30:39PM +0000, luca.boccassi@gmail.com
> wrote:
> > Hi commit authors (and maintainers),
> > 
> > I didn't manage to apply following commits from upstream to stable
> > branch
> > 16.11: conflict happens. I'm wondering can the authors check the
> > following
> > list and backport those patches belong to you?
> > 
> > FYI, branch 16.11 is located at tree:
> >    git://dpdk.org/dpdk-stable
> > 
> > It'd be great if you could do that in one or two weeks. Also,
> > please add a
> > heading line like below before the commit log body:
> >     [ backported from upstream commit xxx ]
> > 
> > Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=c483
> > 1394c7d1944d8ec27d52c22997f20d19718e
> > 
> > Please let me know if you have any comments, say, need more time,
> > or it's
> > worthless to packport it. And please send it to "stable@dpdk.org",
> > but not
> > "dev@dpdk.org".
> > 
> > Thanks.
> > 
> > Luca Boccassi
> > 
> > ---
> > b365799b3  Nélio Laranjeiro net/mlx5: fix un-supported RSS hash
> > fields use
> 
> You can drop this commit for 16.11

Will do, thanks!

-- 
Kind regards,
Luca Boccassi

[dpdk-stable] [PATCH 0/2] bnxt patchset for 16.11

[Ajit Khaparde]

1st patch is a backport from upstream commit:
ee5d7bddab27  net/bnxt: fix group info usage

2nd patch fixes an issue with broadcast configuration.
Instead of porting the complete upstream patch I just picked the
relevant part of code from upstream commit:
d69851df12b2  net/bnxt: support multicast filter and set MAC addr

Please apply.

Ajit Khaparde (2):
  net/bnxt: fix group info usage
  net/bnxt: fix broadcast cofiguration

 drivers/net/bnxt/bnxt_ethdev.c |  4 +++-
 drivers/net/bnxt/bnxt_hwrm.c   | 42 ++++++++++++++++++++++++++----------------
 drivers/net/bnxt/bnxt_hwrm.h   |  4 +++-
 drivers/net/bnxt/bnxt_ring.c   | 24 +++++++++++++++++-------
 drivers/net/bnxt/bnxt_ring.h   |  3 ++-
 5 files changed, 51 insertions(+), 26 deletions(-)

-- 
2.14.3 (Apple Git-98)

[dpdk-stable] [PATCH 1/2] net/bnxt: fix group info usage

[Ajit Khaparde]

Ring groups is a Rx only attribute. Make sure there are sufficient
ring groups available. Return an error if they are not available.

[ upstream commit ee5d7bddab27 ("net/bnxt: fix group info usage") ]

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c |  4 +++-
 drivers/net/bnxt/bnxt_hwrm.c   | 38 ++++++++++++++++++++++++--------------
 drivers/net/bnxt/bnxt_hwrm.h   |  4 +++-
 drivers/net/bnxt/bnxt_ring.c   | 24 +++++++++++++++++-------
 drivers/net/bnxt/bnxt_ring.h   |  3 ++-
 5 files changed, 49 insertions(+), 24 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 64cc7217c..359a95d4e 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -315,7 +315,9 @@ static int bnxt_init_nic(struct bnxt *bp)
 {
 	int rc;
 
-	bnxt_init_ring_grps(bp);
+	rc = bnxt_init_ring_grps(bp);
+	if (rc)
+		return rc;
 	bnxt_init_vnics(bp);
 	bnxt_init_filters(bp);
 
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 619bc979c..8eb559708 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -604,7 +604,7 @@ int bnxt_hwrm_queue_qportcfg(struct bnxt *bp)
 int bnxt_hwrm_ring_alloc(struct bnxt *bp,
 			 struct bnxt_ring *ring,
 			 uint32_t ring_type, uint32_t map_index,
-			 uint32_t stats_ctx_id)
+			 uint32_t stats_ctx_id, uint32_t cmpl_ring_id)
 {
 	int rc = 0;
 	struct hwrm_ring_alloc_input req = {.req_type = 0 };
@@ -625,11 +625,12 @@ int bnxt_hwrm_ring_alloc(struct bnxt *bp,
 		/* FALLTHROUGH */
 	case HWRM_RING_ALLOC_INPUT_RING_TYPE_RX:
 		req.ring_type = ring_type;
-		req.cmpl_ring_id =
-		    rte_cpu_to_le_16(bp->grp_info[map_index].cp_fw_ring_id);
+		req.cmpl_ring_id = rte_cpu_to_le_16(cmpl_ring_id);
 		req.length = rte_cpu_to_le_32(ring->ring_size);
 		req.stat_ctx_id = rte_cpu_to_le_16(stats_ctx_id);
-		req.enables = rte_cpu_to_le_32(rte_le_to_cpu_32(req.enables) |
+		if (stats_ctx_id != INVALID_STATS_CTX_ID)
+			req.enables =
+			rte_cpu_to_le_32(rte_le_to_cpu_32(req.enables) |
 			HWRM_RING_ALLOC_INPUT_ENABLES_STAT_CTX_ID_VALID);
 		break;
 	case HWRM_RING_ALLOC_INPUT_RING_TYPE_CMPL:
@@ -796,7 +797,9 @@ int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp,
 	HWRM_CHECK_RESULT;
 
 	cpr->hw_stats_ctx_id = rte_le_to_cpu_16(resp->stat_ctx_id);
-	bp->grp_info[idx].fw_stats_ctx = cpr->hw_stats_ctx_id;
+	//Tx rings don't need grp_info entry. It is a Rx only attribute.
+	if (idx)
+		bp->grp_info[idx].fw_stats_ctx = cpr->hw_stats_ctx_id;
 
 	return rc;
 }
@@ -818,7 +821,9 @@ int bnxt_hwrm_stat_ctx_free(struct bnxt *bp,
 	HWRM_CHECK_RESULT;
 
 	cpr->hw_stats_ctx_id = HWRM_NA_SIGNATURE;
-	bp->grp_info[idx].fw_stats_ctx = cpr->hw_stats_ctx_id;
+	//Tx rings don't have a grp_info entry. It is a Rx only attribute.
+	if (idx)
+		bp->grp_info[idx].fw_stats_ctx = cpr->hw_stats_ctx_id;
 
 	return rc;
 }
@@ -1025,10 +1030,13 @@ int bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp)
 	for (i = 0; i < bp->rx_cp_nr_rings + bp->tx_cp_nr_rings; i++) {
 		unsigned int idx = i + 1;
 
-		if (i >= bp->rx_cp_nr_rings)
+		if (i >= bp->rx_cp_nr_rings) {
 			cpr = bp->tx_queues[i - bp->rx_cp_nr_rings]->cp_ring;
-		else
+			//Tx rings don't have a grp_info entry.
+			idx = 0;
+		} else {
 			cpr = bp->rx_queues[i]->cp_ring;
+		}
 		if (cpr->hw_stats_ctx_id != HWRM_NA_SIGNATURE) {
 			rc = bnxt_hwrm_stat_ctx_free(bp, cpr, idx);
 			if (rc)
@@ -1052,6 +1060,8 @@ int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp)
 		if (i >= bp->rx_cp_nr_rings) {
 			txq = bp->tx_queues[i - bp->rx_cp_nr_rings];
 			cpr = txq->cp_ring;
+			//Tx rings don't need grp_info entry.
+			idx = 0;
 		} else {
 			rxq = bp->rx_queues[i];
 			cpr = rxq->cp_ring;
@@ -1089,14 +1099,13 @@ int bnxt_free_all_hwrm_ring_grps(struct bnxt *bp)
 }
 
 static void bnxt_free_cp_ring(struct bnxt *bp,
-			      struct bnxt_cp_ring_info *cpr, unsigned int idx)
+			      struct bnxt_cp_ring_info *cpr)
 {
 	struct bnxt_ring *cp_ring = cpr->cp_ring_struct;
 
 	bnxt_hwrm_ring_free(bp, cp_ring,
 			HWRM_RING_FREE_INPUT_RING_TYPE_CMPL);
 	cp_ring->fw_ring_id = INVALID_HW_RING_ID;
-	bp->grp_info[idx].cp_fw_ring_id = INVALID_HW_RING_ID;
 	memset(cpr->cp_desc_ring, 0, cpr->cp_ring_struct->ring_size *
 			sizeof(*cpr->cp_desc_ring));
 	cpr->cp_raw_cons = 0;
@@ -1112,7 +1121,6 @@ int bnxt_free_all_hwrm_rings(struct bnxt *bp)
 		struct bnxt_tx_ring_info *txr = txq->tx_ring;
 		struct bnxt_ring *ring = txr->tx_ring_struct;
 		struct bnxt_cp_ring_info *cpr = txq->cp_ring;
-		unsigned int idx = bp->rx_cp_nr_rings + i + 1;
 
 		if (ring->fw_ring_id != INVALID_HW_RING_ID) {
 			bnxt_hwrm_ring_free(bp, ring,
@@ -1128,7 +1136,7 @@ int bnxt_free_all_hwrm_rings(struct bnxt *bp)
 			txr->tx_cons = 0;
 		}
 		if (cpr->cp_ring_struct->fw_ring_id != INVALID_HW_RING_ID)
-			bnxt_free_cp_ring(bp, cpr, idx);
+			bnxt_free_cp_ring(bp, cpr);
 	}
 
 	for (i = 0; i < bp->rx_cp_nr_rings; i++) {
@@ -1152,7 +1160,8 @@ int bnxt_free_all_hwrm_rings(struct bnxt *bp)
 			rxr->rx_prod = 0;
 		}
 		if (cpr->cp_ring_struct->fw_ring_id != INVALID_HW_RING_ID)
-			bnxt_free_cp_ring(bp, cpr, idx);
+			bnxt_free_cp_ring(bp, cpr);
+		bp->grp_info[idx].cp_fw_ring_id = INVALID_HW_RING_ID;
 	}
 
 	/* Default completion ring */
@@ -1160,7 +1169,8 @@ int bnxt_free_all_hwrm_rings(struct bnxt *bp)
 		struct bnxt_cp_ring_info *cpr = bp->def_cp_ring;
 
 		if (cpr->cp_ring_struct->fw_ring_id != INVALID_HW_RING_ID)
-			bnxt_free_cp_ring(bp, cpr, 0);
+			bnxt_free_cp_ring(bp, cpr);
+		bp->grp_info[0].cp_fw_ring_id = INVALID_HW_RING_ID;
 	}
 
 	return rc;
diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h
index 6519ef21a..32c74c8b1 100644
--- a/drivers/net/bnxt/bnxt_hwrm.h
+++ b/drivers/net/bnxt/bnxt_hwrm.h
@@ -65,7 +65,7 @@ int bnxt_hwrm_queue_qportcfg(struct bnxt *bp);
 int bnxt_hwrm_ring_alloc(struct bnxt *bp,
 			 struct bnxt_ring *ring,
 			 uint32_t ring_type, uint32_t map_index,
-			 uint32_t stats_ctx_id);
+			 uint32_t stats_ctx_id, uint32_t cmpl_ring_id);
 int bnxt_hwrm_ring_free(struct bnxt *bp,
 			struct bnxt_ring *ring, uint32_t ring_type);
 int bnxt_hwrm_ring_grp_alloc(struct bnxt *bp, unsigned int idx);
@@ -101,5 +101,7 @@ int bnxt_alloc_hwrm_resources(struct bnxt *bp);
 int bnxt_get_hwrm_link_config(struct bnxt *bp, struct rte_eth_link *link);
 int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up);
 int bnxt_hwrm_func_qcfg(struct bnxt *bp);
+#define HWRM_RING_ALLOC_INPUT_EN_STAT_CTX_ID_VALID \
+	HWRM_RING_ALLOC_INPUT_ENABLES_STAT_CTX_ID_VALID
 
 #endif
diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c
index 3f81ffcc5..2bceb4dba 100644
--- a/drivers/net/bnxt/bnxt_ring.c
+++ b/drivers/net/bnxt/bnxt_ring.c
@@ -61,13 +61,19 @@ void bnxt_free_ring(struct bnxt_ring *ring)
  * Ring groups
  */
 
-void bnxt_init_ring_grps(struct bnxt *bp)
+int bnxt_init_ring_grps(struct bnxt *bp)
 {
 	unsigned int i;
 
+	//One slot is still consumed by Default ring.
+	if (bp->max_ring_grps < 1 + bp->rx_cp_nr_rings)
+		return -ENOMEM;
+
 	for (i = 0; i < bp->max_ring_grps; i++)
 		memset(&bp->grp_info[i], (uint8_t)HWRM_NA_SIGNATURE,
 		       sizeof(struct bnxt_ring_grp_info));
+
+	return 0;
 }
 
 /*
@@ -219,7 +225,8 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp)
 
 		rc = bnxt_hwrm_ring_alloc(bp, cp_ring,
 					  HWRM_RING_ALLOC_INPUT_RING_TYPE_CMPL,
-					  0, HWRM_NA_SIGNATURE);
+					  0, HWRM_NA_SIGNATURE,
+					  HWRM_NA_SIGNATURE);
 		if (rc)
 			goto err_out;
 		cpr->cp_doorbell =
@@ -239,7 +246,8 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp)
 		/* Rx cmpl */
 		rc = bnxt_hwrm_ring_alloc(bp, cp_ring,
 					HWRM_RING_ALLOC_INPUT_RING_TYPE_CMPL,
-					idx, HWRM_NA_SIGNATURE);
+					idx, HWRM_NA_SIGNATURE,
+					HWRM_NA_SIGNATURE);
 		if (rc)
 			goto err_out;
 		cpr->cp_doorbell =
@@ -251,7 +259,8 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp)
 		/* Rx ring */
 		rc = bnxt_hwrm_ring_alloc(bp, ring,
 					HWRM_RING_ALLOC_INPUT_RING_TYPE_RX,
-					idx, cpr->hw_stats_ctx_id);
+					idx, cpr->hw_stats_ctx_id,
+					cp_ring->fw_ring_id);
 		if (rc)
 			goto err_out;
 		rxr->rx_prod = 0;
@@ -279,20 +288,21 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp)
 		/* Tx cmpl */
 		rc = bnxt_hwrm_ring_alloc(bp, cp_ring,
 					HWRM_RING_ALLOC_INPUT_RING_TYPE_CMPL,
-					idx, HWRM_NA_SIGNATURE);
+					idx, HWRM_NA_SIGNATURE,
+					HWRM_NA_SIGNATURE);
 		if (rc)
 			goto err_out;
 
 		cpr->cp_doorbell =
 		    (char *)bp->eth_dev->pci_dev->mem_resource[2].addr +
 		    idx * 0x80;
-		bp->grp_info[idx].cp_fw_ring_id = cp_ring->fw_ring_id;
 		B_CP_DIS_DB(cpr, cpr->cp_raw_cons);
 
 		/* Tx ring */
 		rc = bnxt_hwrm_ring_alloc(bp, ring,
 					HWRM_RING_ALLOC_INPUT_RING_TYPE_TX,
-					idx, cpr->hw_stats_ctx_id);
+					idx, cpr->hw_stats_ctx_id,
+					cp_ring->fw_ring_id);
 		if (rc)
 			goto err_out;
 
diff --git a/drivers/net/bnxt/bnxt_ring.h b/drivers/net/bnxt/bnxt_ring.h
index 8656549a5..22a56eb13 100644
--- a/drivers/net/bnxt/bnxt_ring.h
+++ b/drivers/net/bnxt/bnxt_ring.h
@@ -65,6 +65,7 @@
 #define MAX_CP_DESC_CNT (16 * 1024)
 
 #define INVALID_HW_RING_ID      ((uint16_t)-1)
+#define INVALID_STATS_CTX_ID	((uint16_t)-1)
 
 struct bnxt_ring {
 	void			*bd;
@@ -92,7 +93,7 @@ struct bnxt_tx_ring_info;
 struct bnxt_rx_ring_info;
 struct bnxt_cp_ring_info;
 void bnxt_free_ring(struct bnxt_ring *ring);
-void bnxt_init_ring_grps(struct bnxt *bp);
+int bnxt_init_ring_grps(struct bnxt *bp);
 int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
 			    struct bnxt_tx_ring_info *tx_ring_info,
 			    struct bnxt_rx_ring_info *rx_ring_info,
-- 
2.14.3 (Apple Git-98)

[dpdk-stable] [PATCH 2/2] net/bnxt: fix broadcast cofiguration

[Ajit Khaparde]

Depeding on how the request is made, we seem to configure incorrect
settings to the HW.

[backported from upstream commit d69851df12b2 ("net/bnxt:
			support multicast filter and set MAC addr")]

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 8eb559708..af6ae8bba 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -174,9 +174,9 @@ int bnxt_hwrm_cfa_l2_set_rx_mask(struct bnxt *bp, struct bnxt_vnic_info *vnic)
 	 * by ethtool.
 	 */
 	if (vnic->flags & BNXT_VNIC_INFO_PROMISC)
-		mask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_PROMISCUOUS;
+		mask |= HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_PROMISCUOUS;
 	if (vnic->flags & BNXT_VNIC_INFO_ALLMULTI)
-		mask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ALL_MCAST;
+		mask |= HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ALL_MCAST;
 	req.mask = rte_cpu_to_le_32(mask);
 
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));
-- 
2.14.3 (Apple Git-98)

Re: [dpdk-stable] [PATCH 0/2] bnxt patchset for 16.11

[Luca Boccassi]

On Fri, 2018-02-02 at 12:05 -0800, Ajit Khaparde wrote:
> 1st patch is a backport from upstream commit:
> ee5d7bddab27  net/bnxt: fix group info usage
> 
> 2nd patch fixes an issue with broadcast configuration.
> Instead of porting the complete upstream patch I just picked the
> relevant part of code from upstream commit:
> d69851df12b2  net/bnxt: support multicast filter and set MAC addr
> 
> Please apply.
> 
> Ajit Khaparde (2):
>   net/bnxt: fix group info usage
>   net/bnxt: fix broadcast cofiguration
> 
>  drivers/net/bnxt/bnxt_ethdev.c |  4 +++-
>  drivers/net/bnxt/bnxt_hwrm.c   | 42 ++++++++++++++++++++++++++----
> ------------
>  drivers/net/bnxt/bnxt_hwrm.h   |  4 +++-
>  drivers/net/bnxt/bnxt_ring.c   | 24 +++++++++++++++++-------
>  drivers/net/bnxt/bnxt_ring.h   |  3 ++-
>  5 files changed, 51 insertions(+), 26 deletions(-)

Thank you, merged and pushed!

-- 
Kind regards,
Luca Boccassi

[dpdk-stable] please help backporting some patches to LTS release 16.11.5

[luca.boccassi]

Hi commit authors (and maintainers),

I didn't manage to apply following commits from upstream to stable branch
16.11: conflict happens. I'm wondering can the authors check the following
list and backport those patches belong to you?

FYI, branch 16.11 is located at tree:
   git://dpdk.org/dpdk-stable

It'd be great if you could do that in one or two weeks. Also, please add a
heading line like below before the commit log body:
    [ backported from upstream commit xxx ]

Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=c4831394c7d1944d8ec27d52c22997f20d19718e

Please let me know if you have any comments, say, need more time, or it's
worthless to packport it. And please send it to "stable@dpdk.org", but not
"dev@dpdk.org".

Thanks.

Luca Boccassi

---
dbcabb69e  Ajit Khaparde    net/bnxt: fix number of pools for RSS
14ec04e1a  Anatoly Burakov  test/ring: fix memory leak
dd28bc8c6  Harish Patil     net/qede: fix VF port creation sequence
96fd032ba  Hemant Agrawal   eal: prefix mbuf pool ops name with user defined
59a3cae53  Jia He           eal/arm64: remove the braces in memory barrier macros
0d6a8752a  Jianfeng Tan     net/virtio-user: fix crash as features change
133b54779  Matan Azrad      ethdev: fix port data reset timing
8ee892a23  Matan Azrad      ethdev: fix port id allocation
ce26be6ed  Rasesh Mody      net/qede: fix clearing of queue stats
9e3343051  Rasesh Mody      net/qede: fix MTU set and max Rx length
e313ef4c2  Shahaf Shuler    net/mlx5: fix link state on device start
2ab9a9483  Thomas Monjalon  crypto/dpaa2_sec: fix build with GCC 7
0bf876008  Xueming Li       cmdline: avoid garbage in unused fields of parsed result
2acf7432a  Xueming Li       cmdline: fix dynamic tokens parsing
963898f0e  Yong Wang        crypto/qat: fix allocation check and leak

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Tan, Jianfeng]

Hi Luca,

> -----Original Message-----
> From: luca.boccassi@gmail.com [mailto:luca.boccassi@gmail.com]
> Sent: Thursday, February 8, 2018 3:14 AM
> To: dpdk stable
> Cc: Ajit Khaparde; Burakov, Anatoly; Yigit, Ferruh; Trahe, Fiona; Harish Patil;
> Hemant Agrawal; Jerin Jacob; Jia He; Tan, Jianfeng; Ananyev, Konstantin; Yao,
> Lei A; Matan Azrad; Nelio Laranjeiro; Olivier Matz; Rasesh Mody; Santosh
> Shukla; Shahaf Shuler; Thomas Monjalon; Bie, Tiwei; Xueming Li; Yong Wang;
> Yuanhan Liu
> Subject: please help backporting some patches to LTS release 16.11.5
> 
> Hi commit authors (and maintainers),
> 
> I didn't manage to apply following commits from upstream to stable branch
> 16.11: conflict happens. I'm wondering can the authors check the following
> list and backport those patches belong to you?
> 
> FYI, branch 16.11 is located at tree:
>    git://dpdk.org/dpdk-stable
> 
> It'd be great if you could do that in one or two weeks. Also, please add a
> heading line like below before the commit log body:
>     [ backported from upstream commit xxx ]
> 
> Example: http://dpdk.org/browse/dpdk-
> stable/commit/?h=16.07&id=c4831394c7d1944d8ec27d52c22997f20d19718e
> 
> Please let me know if you have any comments, say, need more time, or it's
> worthless to packport it. And please send it to "stable@dpdk.org", but not
> "dev@dpdk.org".
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> dbcabb69e  Ajit Khaparde    net/bnxt: fix number of pools for RSS
> 14ec04e1a  Anatoly Burakov  test/ring: fix memory leak
> dd28bc8c6  Harish Patil     net/qede: fix VF port creation sequence
> 96fd032ba  Hemant Agrawal   eal: prefix mbuf pool ops name with user
> defined
> 59a3cae53  Jia He           eal/arm64: remove the braces in memory barrier
> macros
> 0d6a8752a  Jianfeng Tan     net/virtio-user: fix crash as features change

We don't have to back-port the above fix if below commit is not back-ported.
commit 59fe5e17d930 ("vhost: propagate set features handling error")

Thanks,
Jianfeng

> 133b54779  Matan Azrad      ethdev: fix port data reset timing
> 8ee892a23  Matan Azrad      ethdev: fix port id allocation
> ce26be6ed  Rasesh Mody      net/qede: fix clearing of queue stats
> 9e3343051  Rasesh Mody      net/qede: fix MTU set and max Rx length
> e313ef4c2  Shahaf Shuler    net/mlx5: fix link state on device start
> 2ab9a9483  Thomas Monjalon  crypto/dpaa2_sec: fix build with GCC 7
> 0bf876008  Xueming Li       cmdline: avoid garbage in unused fields of parsed
> result
> 2acf7432a  Xueming Li       cmdline: fix dynamic tokens parsing
> 963898f0e  Yong Wang        crypto/qat: fix allocation check and leak

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Luca Boccassi]

On Thu, 2018-02-08 at 01:53 +0000, Tan, Jianfeng wrote:
> Hi Luca,
> 
> > -----Original Message-----
> > From: luca.boccassi@gmail.com [mailto:luca.boccassi@gmail.com]
> > Sent: Thursday, February 8, 2018 3:14 AM
> > To: dpdk stable
> > Cc: Ajit Khaparde; Burakov, Anatoly; Yigit, Ferruh; Trahe, Fiona;
> > Harish Patil;
> > Hemant Agrawal; Jerin Jacob; Jia He; Tan, Jianfeng; Ananyev,
> > Konstantin; Yao,
> > Lei A; Matan Azrad; Nelio Laranjeiro; Olivier Matz; Rasesh Mody;
> > Santosh
> > Shukla; Shahaf Shuler; Thomas Monjalon; Bie, Tiwei; Xueming Li;
> > Yong Wang;
> > Yuanhan Liu
> > Subject: please help backporting some patches to LTS release
> > 16.11.5
> > 
> > Hi commit authors (and maintainers),
> > 
> > I didn't manage to apply following commits from upstream to stable
> > branch
> > 16.11: conflict happens. I'm wondering can the authors check the
> > following
> > list and backport those patches belong to you?
> > 
> > FYI, branch 16.11 is located at tree:
> >    git://dpdk.org/dpdk-stable
> > 
> > It'd be great if you could do that in one or two weeks. Also,
> > please add a
> > heading line like below before the commit log body:
> >     [ backported from upstream commit xxx ]
> > 
> > Example: http://dpdk.org/browse/dpdk-
> > stable/commit/?h=16.07&id=c4831394c7d1944d8ec27d52c22997f20d19718e
> > 
> > Please let me know if you have any comments, say, need more time,
> > or it's
> > worthless to packport it. And please send it to "stable@dpdk.org",
> > but not
> > "dev@dpdk.org".
> > 
> > Thanks.
> > 
> > Luca Boccassi
> > 
> > ---
> > dbcabb69e  Ajit Khaparde    net/bnxt: fix number of pools for RSS
> > 14ec04e1a  Anatoly Burakov  test/ring: fix memory leak
> > dd28bc8c6  Harish Patil     net/qede: fix VF port creation sequence
> > 96fd032ba  Hemant Agrawal   eal: prefix mbuf pool ops name with
> > user
> > defined
> > 59a3cae53  Jia He           eal/arm64: remove the braces in memory
> > barrier
> > macros
> > 0d6a8752a  Jianfeng Tan     net/virtio-user: fix crash as features
> > change
> 
> We don't have to back-port the above fix if below commit is not back-
> ported.
> commit 59fe5e17d930 ("vhost: propagate set features handling error")
> 
> Thanks,
> Jianfeng

Ok perfect I'll drop it then, thank you very much for checking.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Ajit Khaparde]

On Wed, Feb 7, 2018 at 11:14 AM, <luca.boccassi@gmail.com> wrote:

> Hi commit authors (and maintainers),
>
> I didn't manage to apply following commits from upstream to stable branch
> 16.11: conflict happens. I'm wondering can the authors check the following
> list and backport those patches belong to you?
>
> FYI, branch 16.11 is located at tree:
>    git://dpdk.org/dpdk-stable
>
> It'd be great if you could do that in one or two weeks. Also, please add a
> heading line like below before the commit log body:
>     [ backported from upstream commit xxx ]
>
> Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=
> c4831394c7d1944d8ec27d52c22997f20d19718e
>
> Please let me know if you have any comments, say, need more time, or it's
> worthless to packport it. And please send it to "stable@dpdk.org", but not
> "dev@dpdk.org".
>
> Thanks.
>
> Luca Boccassi
>
> ---
> dbcabb69e  Ajit Khaparde    net/bnxt: fix number of pools for RSS
>
​16.11 does not need this change.​

​Thanks​



> 14ec04e1a  Anatoly Burakov  test/ring: fix memory leak
> dd28bc8c6  Harish Patil     net/qede: fix VF port creation sequence
> 96fd032ba  Hemant Agrawal   eal: prefix mbuf pool ops name with user
> defined
> 59a3cae53  Jia He           eal/arm64: remove the braces in memory barrier
> macros
> 0d6a8752a  Jianfeng Tan     net/virtio-user: fix crash as features change
> 133b54779  Matan Azrad      ethdev: fix port data reset timing
> 8ee892a23  Matan Azrad      ethdev: fix port id allocation
> ce26be6ed  Rasesh Mody      net/qede: fix clearing of queue stats
> 9e3343051  Rasesh Mody      net/qede: fix MTU set and max Rx length
> e313ef4c2  Shahaf Shuler    net/mlx5: fix link state on device start
> 2ab9a9483  Thomas Monjalon  crypto/dpaa2_sec: fix build with GCC 7
> 0bf876008  Xueming Li       cmdline: avoid garbage in unused fields of
> parsed result
> 2acf7432a  Xueming Li       cmdline: fix dynamic tokens parsing
> 963898f0e  Yong Wang        crypto/qat: fix allocation check and leak
>

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Luca Boccassi]

On Thu, 2018-02-08 at 13:47 -0800, Ajit Khaparde wrote:
> On Wed, Feb 7, 2018 at 11:14 AM, <luca.boccassi@gmail.com> wrote:
> 
> > Hi commit authors (and maintainers),
> > 
> > I didn't manage to apply following commits from upstream to stable
> > branch
> > 16.11: conflict happens. I'm wondering can the authors check the
> > following
> > list and backport those patches belong to you?
> > 
> > FYI, branch 16.11 is located at tree:
> >    git://dpdk.org/dpdk-stable
> > 
> > It'd be great if you could do that in one or two weeks. Also,
> > please add a
> > heading line like below before the commit log body:
> >     [ backported from upstream commit xxx ]
> > 
> > Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=
> > c4831394c7d1944d8ec27d52c22997f20d19718e
> > 
> > Please let me know if you have any comments, say, need more time,
> > or it's
> > worthless to packport it. And please send it to "stable@dpdk.org",
> > but not
> > "dev@dpdk.org".
> > 
> > Thanks.
> > 
> > Luca Boccassi
> > 
> > ---
> > dbcabb69e  Ajit Khaparde    net/bnxt: fix number of pools for RSS
> > 
> 
> 16.11 does not need this change.
> 
> Thanks

Great, thank you for checking.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Matan Azrad]

Hi Luca

 From: luca.boccassi@gmail.com, Sent: Wednesday, February 7, 2018 9:14 PM
> Hi commit authors (and maintainers),
> 
> I didn't manage to apply following commits from upstream to stable branch
> 16.11: conflict happens. I'm wondering can the authors check the following
> list and backport those patches belong to you?
> 
> FYI, branch 16.11 is located at tree:
>    git://dpdk.org/dpdk-stable
> 
> It'd be great if you could do that in one or two weeks. Also, please add a
> heading line like below before the commit log body:
>     [ backported from upstream commit xxx ]
> 
> Example:
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
> k.org%2Fbrowse%2Fdpdk-
> stable%2Fcommit%2F%3Fh%3D16.07%26id%3Dc4831394c7d1944d8ec27d52c2
> 2997f20d19718e&data=02%7C01%7Cmatan%40mellanox.com%7Cbe758d6ff1
> d1410db8da08d56e5f0db0%7C8c5c71989dbe4cf9a2099e499881116c%7C0%7C
> 0%7C636536276909341667&sdata=rvd%2FFaic781qiftZmojqZSwGBSHqVqa1%
> 2BxQo8cKPG2s%3D&reserved=0
> 
> Please let me know if you have any comments, say, need more time, or it's
> worthless to packport it. And please send it to "stable@dpdk.org", but not
> "dev@dpdk.org".
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> 133b54779  Matan Azrad      ethdev: fix port data reset timing
> 8ee892a23  Matan Azrad      ethdev: fix port id allocation

I think these 2 fixes are not relevant to 16.11 version.

Matan.

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Luca Boccassi]

On Sun, 2018-02-11 at 07:49 +0000, Matan Azrad wrote:
> Hi Luca
> 
>  From: luca.boccassi@gmail.com, Sent: Wednesday, February 7, 2018
> 9:14 PM
> > Hi commit authors (and maintainers),
> > 
> > I didn't manage to apply following commits from upstream to stable
> > branch
> > 16.11: conflict happens. I'm wondering can the authors check the
> > following
> > list and backport those patches belong to you?
> > 
> > FYI, branch 16.11 is located at tree:
> >    git://dpdk.org/dpdk-stable
> > 
> > It'd be great if you could do that in one or two weeks. Also,
> > please add a
> > heading line like below before the commit log body:
> >     [ backported from upstream commit xxx ]
> > 
> > Example:
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fd
> > pd
> > k.org%2Fbrowse%2Fdpdk-
> > stable%2Fcommit%2F%3Fh%3D16.07%26id%3Dc4831394c7d1944d8ec27d52c2
> > 2997f20d19718e&data=02%7C01%7Cmatan%40mellanox.com%7Cbe758d6ff1
> > d1410db8da08d56e5f0db0%7C8c5c71989dbe4cf9a2099e499881116c%7C0%7C
> > 0%7C636536276909341667&sdata=rvd%2FFaic781qiftZmojqZSwGBSHqVqa1%
> > 2BxQo8cKPG2s%3D&reserved=0
> > 
> > Please let me know if you have any comments, say, need more time,
> > or it's
> > worthless to packport it. And please send it to "stable@dpdk.org",
> > but not
> > "dev@dpdk.org".
> > 
> > Thanks.
> > 
> > Luca Boccassi
> > 
> > ---
> > 133b54779  Matan Azrad      ethdev: fix port data reset timing
> > 8ee892a23  Matan Azrad      ethdev: fix port id allocation
> 
> I think these 2 fixes are not relevant to 16.11 version.
> 
> Matan.

Ok, thanks for checking, dropped.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Olivier Matz]

Hi Luca,

On Wed, Feb 07, 2018 at 07:14:28PM +0000, luca.boccassi@gmail.com wrote:
> Hi commit authors (and maintainers),
> 
> I didn't manage to apply following commits from upstream to stable branch
> 16.11: conflict happens. I'm wondering can the authors check the following
> list and backport those patches belong to you?
> 
> FYI, branch 16.11 is located at tree:
>    git://dpdk.org/dpdk-stable
> 
> It'd be great if you could do that in one or two weeks. Also, please add a
> heading line like below before the commit log body:
>     [ backported from upstream commit xxx ]
> 
> Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=c4831394c7d1944d8ec27d52c22997f20d19718e
> 
> Please let me know if you have any comments, say, need more time, or it's
> worthless to packport it. And please send it to "stable@dpdk.org", but not
> "dev@dpdk.org".
> 
> Thanks.
> 
> Luca Boccassi

[...]

> 0bf876008  Xueming Li       cmdline: avoid garbage in unused fields of parsed result
> 2acf7432a  Xueming Li       cmdline: fix dynamic tokens parsing

These 2 patches do not need to be backported in 16.11. The first one
is a minor bug that has almost no impact (unused fields not zeroed in
the structure after parsing a command). The second one fixes a feature
that was introduced after 16.11.

Re: [dpdk-stable] please help backporting some patches to LTS release 16.11.5

[Luca Boccassi]

On Wed, 2018-02-14 at 09:46 +0100, Olivier Matz wrote:
> Hi Luca,
> 
> On Wed, Feb 07, 2018 at 07:14:28PM +0000, luca.boccassi@gmail.com
> wrote:
> > Hi commit authors (and maintainers),
> > 
> > I didn't manage to apply following commits from upstream to stable
> > branch
> > 16.11: conflict happens. I'm wondering can the authors check the
> > following
> > list and backport those patches belong to you?
> > 
> > FYI, branch 16.11 is located at tree:
> >    git://dpdk.org/dpdk-stable
> > 
> > It'd be great if you could do that in one or two weeks. Also,
> > please add a
> > heading line like below before the commit log body:
> >     [ backported from upstream commit xxx ]
> > 
> > Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=c483
> > 1394c7d1944d8ec27d52c22997f20d19718e
> > 
> > Please let me know if you have any comments, say, need more time,
> > or it's
> > worthless to packport it. And please send it to "stable@dpdk.org",
> > but not
> > "dev@dpdk.org".
> > 
> > Thanks.
> > 
> > Luca Boccassi
> 
> [...]
> 
> > 0bf876008  Xueming Li       cmdline: avoid garbage in unused fields
> > of parsed result
> > 2acf7432a  Xueming Li       cmdline: fix dynamic tokens parsing
> 
> These 2 patches do not need to be backported in 16.11. The first one
> is a minor bug that has almost no impact (unused fields not zeroed in
> the structure after parsing a command). The second one fixes a
> feature
> that was introduced after 16.11.

Perfect, thanks for checking.

-- 
Kind regards,
Luca Boccassi