From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 57BBC1B29A for ; Fri, 16 Feb 2018 15:27:05 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id 141so3442541wme.3 for ; Fri, 16 Feb 2018 06:27:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0kfykWZpJeAwWvHJXh2N3qIS/dHNiuF87h6SCP0lydY=; b=Jp3NUHy7jzJ/1HLkjfiiUGtF0BI44pZ7EMyaVQXF+2wB6ul3qCdWcEuQxZTpMvlwxY n/G2y19QkzXmwkHw3RIrCsG8xURjaOh0qqicTqy9QvPrntc/UYWQh4gr5e6I3iIH/8MO Kbt7tcNn5P+u3CiMHAt5HfmC8uYXP0k/2DFNQz6d8XmPNRxTVAAlxL/xo7niwmkDvbCy 8FYHiks89ZV6TzN5Yub6YawwCK9M1xuhqW2WnwSAfKxGV1kQ1vltHC+CfyKUzzxRpY+N yeTyo5p16jHWjB2tSMy1s4RiBECq1KXM9KC+j+ZAImrbPTjyurDsmioR7O59Nfwm7YhB H6iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0kfykWZpJeAwWvHJXh2N3qIS/dHNiuF87h6SCP0lydY=; b=S6Emw8ndWyI6zsVxodMIES+acTdvQU4Ltr31zpC93pr5+PVDuoIJGpG4+L+vx0Gy02 smVP4h91dk1Ls6VVSEMsXzw+qoitVAJLZpt7JnViSjc+4/jzaNwo7dDYnE+ekyc0AnED nzlVw1e+2oWWWqiyV6UaGaY+fczUUeaAItgBZjuxE6R+i8Qd+UpIXUutoh0GFpDyhNph s+dBvOQSkkER+pLkg0DwJ4yqTpwxl7Z4CiVkv4S+tOfIGIvoxbtYvnYbM6I8m6jhUIOy EQux0vp5lzVKzAiBDYlBNn6s2Gh96ub8pzZ8kg6fHLeESjEUip8fn/G8ND8W+538/hya EQ3w== X-Gm-Message-State: APf1xPDCrz9yCe3KrWHb1dDaNKXp9FslvzZB8In9IdMjVNJS23R/G3Jx bmDbL77jqEFgczE8Ic+V7DIw/w== X-Google-Smtp-Source: AH8x226FIMsoErz7VgiGLZpGbjYK13LmKJOy/W7Gldzc2b7SDIzMoA5ZQb2IenTannF5FPJUEMivhg== X-Received: by 10.28.94.211 with SMTP id s202mr4862770wmb.159.1518791224539; Fri, 16 Feb 2018 06:27:04 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 30sm13755174wri.48.2018.02.16.06.27.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Feb 2018 06:27:03 -0800 (PST) Date: Fri, 16 Feb 2018 15:26:51 +0100 From: Adrien Mazarguil To: Nelio Laranjeiro Cc: dev@dpdk.org, Yongseok Koh , stable@dpdk.org Message-ID: <20180216142651.GG4256@6wind.com> References: <20fc1ef17c45c727fe72182fa0ba89313fdb430d.1518686930.git.nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20fc1ef17c45c727fe72182fa0ba89313fdb430d.1518686930.git.nelio.laranjeiro@6wind.com> Subject: Re: [dpdk-stable] [PATCH 3/3] net/mlx5: fix traffic restart function to return errors X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2018 14:27:05 -0000 On Thu, Feb 15, 2018 at 10:29:27AM +0100, Nelio Laranjeiro wrote: > priv_dev_traffic_restart() was considering nothing could fail whereas it > can. How about simply describing it as: priv_dev_traffic_restart() must not ignore errors. > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") > Cc: stable@dpdk.org > > Signed-off-by: Nelio Laranjeiro > Acked-by: Yongseok Koh Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND