From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0071.outbound.protection.outlook.com [104.47.1.71]) by dpdk.org (Postfix) with ESMTP id 025205F35; Tue, 13 Mar 2018 22:55:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HGL8Q5hMJ/5Yf8mwH+hgr4D7qhgjbdtFm0VX6tQuYhs=; b=wXuHVgyuIa9GLsAPllfpfjFdkfaqVfisMCkqhkcl0p+tbZQoPSiRQzxZTEIVBswap0Q7SlBDpd4aJU3pjM6nseHWB9N5wz8D+7Gt9y7RfLIJehVrUnjVprWbUVsVrzQoANthMxOiDLqXg+3E8Az+YkpzIeXOi9qOZ+kNgq4Po0k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from yongseok-MBP.local (209.116.155.178) by VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Tue, 13 Mar 2018 21:54:56 +0000 Date: Tue, 13 Mar 2018 14:54:44 -0700 From: Yongseok Koh To: Nelio Laranjeiro Cc: dev@dpdk.org, Adrien Mazarguil , shahafs@mellanox.com, stable@dpdk.org Message-ID: <20180313215443.GB26229@yongseok-MBP.local> References: <21fb91002768a627d9c7f3d81e0c8a12fbf6811f.1518684427.git.nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM5PR20CA0023.namprd20.prod.outlook.com (2603:10b6:3:93::33) To VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 23c49fae-ca7e-462d-32ae-08d5892d0fde X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 3:zzeN89E8UNqOmp8xKxjLFft9IGursGpbyUe+EQvYdcqOwYP1OEC4tqWXURnWauJ88zZOBA48Z7v8jFJ4CY3gd3JvTx76dy/lsD1+FHOEdBJZcBeYYcTk4CB3z2G/4oYaCSDL86fxNZAXJhrweAJFloUxdaWTJDffPsj/dNp9ufO07fGGKp9u7cdb/JsGPK+qUWWaEmwHhxIcm8hvas5Vm7eaMUUvUidwpXJqcjLRaZF1Zxt+RvNHv49RYOGcm7XS; 25:XYU99dFamB4cjLdVtCGwF27N9PK2OGGOb0y8y9NRyecsQJvsJ37q23ZF/uAEpmsDW64xx2LZ+bta5RpzE1Rjy30Nmu3Vngbf+4iG8LXA9urny1g5ev/mhVqc1aIiBT5XyKz22uYPu0M8siBV5e1UP8bZthtFUiOWDg0gekUfPAV6Af0d5OP0G+rB2CWSweginuRy/9nLguDpZF4HDal5fY7I1NmNOgMoVt/vmiXxNcee0jeAc0z28AhzIAaWWVt7PKAANc6G92tQEdpxOcmlVKBedrk1lxRmtlrsoNiZeLwJYqSPtvMoKBGYA/E5PGsAR2kFXmxhCgeI4b9PxMiUaw==; 31:R2k1VDCCXFpkZLpPKpt3HhuzkzWzVz/JRujXNCw79itkD8RKcGjJosoDlcNPD0DfS4vDzny/2AGknCWa+CJikEbkPLQ5SkRbF32Wh5YbJODzebGtbKlN3fQ5gS8sPUlARVxbehd7BS3H56f+TQE8W9XqeicC/RzObAa5TL7Yq4bBDRK7U1msb7QmNN4PKesmVy2eaEaeUqkrR7z5PV66wpjceDYRCbNrHJXIi02jde4= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2045: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 20:DQW2iRxZds7NDFlaLu8I+GddW4rHWSNxuKO0Ip5fMApBenMfLz87Bd3jq9b1vhjUrAbXM7mN8CZsLT5KzZM1RYx3vQLq9pLnHZ3x6iAGnTC7/nfRMC4GPod4KPnW8fuqMGsF2K2SFvzQax9nn/t6N+J1R6/n9bVOmXxdlhBhrnqUd1c68DVRMZbjI/uFbnFRdHG06cok3+IPSfmNT2y0dCxk8itkBkqVC/PJeIl2qKbj5E9hffmbqa+eFCXAA6D3HzhklcGTh/KGEfMOIbz3j6se/5IQ4KOMSskAHL8u3p5jxJL18UXle2NEZO8dOqViqWb7glMnzdGOAPd0Pe/tCDXKOq8Mva+4vKaNy/1SuWzwD60Rvbj7HfvgYB215dg8/8PQ0LJsiBsseEk1RMoI1HJesbbVX0nkhVfSMio15Et69JdvILx65DJVmd+vPLNU+NrRJ84Z2xnCTqchvbe2HBwPRm6SptvJo8a/UApDAgfv33qzss6GJ6Lx/eStHjKp; 4:9/qXZmgO+m+n+Dws+qK/scy9WMlytyHcWks2oWWtO8PyCiG3ps/k7WVmqx4UUT/Z1vgmQ1KAyAKTPRM7FBKGoAoCH8zu9drIaCuQz/u0JW7hOu1br+eJhfmZFoaXr1aaQRE0SGa2lErBQcEPcws1Zumy64yP7ZpHj+VFvtvS+swmTbctAZ2g2tUuENNLlV71ww76g4I7NT+7aC356h0QGAW3O193KLAtPv/lEsIi7wRuC1aCG/4mebHp97XQ37fhKe8XHD9mMeun3QpLw40eGg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231221)(944501244)(52105095)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR0501MB2045; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2045; X-Forefront-PRVS: 0610D16BBE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(39860400002)(396003)(366004)(346002)(199004)(189003)(575784001)(86362001)(2950100002)(7736002)(98436002)(50466002)(386003)(33656002)(8676002)(4326008)(6506007)(25786009)(58126008)(16586007)(229853002)(97736004)(59450400001)(53376002)(26005)(6666003)(16526019)(53936002)(7696005)(6246003)(52116002)(478600001)(305945005)(966005)(186003)(66066001)(3846002)(47776003)(1076002)(316002)(23726003)(105586002)(6916009)(6116002)(2906002)(106356001)(55016002)(6306002)(5660300001)(81156014)(8936002)(33896004)(81166006)(9686003)(76176011)(68736007)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2045; H:yongseok-MBP.local; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2045; 23:RCGqh4NHBjYIMtN+dsTgQh74OnDkPnDj/nENZU+?= =?us-ascii?Q?TWSgXp37rdT+nvx6Qh6JmkHywqHgc5a2Ga75CHJHZV/mYKuYg6mLqsLXze73?= =?us-ascii?Q?aCb9RtFNtjpLqigmBnPkBYknf04IGfWvXUFwtSEtcTf/keZx/bm9WJVRCrID?= =?us-ascii?Q?zUGtkXRChTe/uskIVoUqrqCtuAGXYLF3I2BA6K9JSY+ydvvx3kfcQUzca035?= =?us-ascii?Q?AakEybj8z0DI4B6isiBtrm96VJISyLMIGy9YkaPxktyOeuZVlEYOrnMMVWts?= =?us-ascii?Q?cqc0naeCjaDXdJwdT2OYsyY5EDVbRFqF93hhRGBQ+rTh4GPmkXtb7pIwKaCx?= =?us-ascii?Q?C9lCIjjg4ki5Da+X5y6EIsKFgTgWc7Y1ESmWL0TOXkrkrtRYMHgPaLDpKP0R?= =?us-ascii?Q?opUcAASPENeT9NEbQZQF/lgeUsfWXMeSC3TGH5nGCDFDH6i8v3D/W+gOrqWC?= =?us-ascii?Q?Zqjggmib9W6dCZXe8kJ8X/b8JHRDshQUQ32+QVpD+A4iTOewz9HWleyaY2Wj?= =?us-ascii?Q?jO2oEVWu4cCFpJcpckRGUpahmhM1nng2dn9u9tBO5pZvQiqodIBwrKEZ9oNV?= =?us-ascii?Q?ilnlbaGD6nojaSrfa2dvRMq48F6MgJk7MDvEZHQRl5WosV2r6I1nIVU6M8q0?= =?us-ascii?Q?4JV+J7spg4tLW0UQWG+UNz17VPtcrg227k7jr27QGTB17mA6T1uiA3GSMNWw?= =?us-ascii?Q?uKodgQLqPpslP/j6sKdm1mHuFCmIOEDQ0EQLQgCw/ZqVtK2NeoJzDLTID8WY?= =?us-ascii?Q?pxLCt+SR6yq4k/FtBF/B6Z8i+fPQpVI4KW0DGl1Js8MFIgtLMdKsEs/Wxf4y?= =?us-ascii?Q?D/QWWE/CiPkY0OEXG1VeJ74MwwAN1QXu+pVGnAW+j3VfhIo7sJD9VaaUEEMH?= =?us-ascii?Q?m/ihnYh3O1ndXcAXZxzMxTPBAGcjUiNYiKdTtdXEndLjGN6pYzcPfQyqGLAE?= =?us-ascii?Q?1cayHQDzj1FeQqK2cJehXZ3/uyelTZ/09UlaRpNYcZNemOCZtIMkXJ7sOHHs?= =?us-ascii?Q?1oxP7KbXVu2kbOy1uZQ53b4G6mJl8E608XZm3gNkrXbXNg8AQX1A+922ki7h?= =?us-ascii?Q?ip/gRCAjxpPvbWRt5meBsuYACC/5JoRZouxxVUBP7Tjom/isLGb/aIRWbUzU?= =?us-ascii?Q?KT3VVlN1RM9PIaxO3BnKOL5y8PBpYY5eI1pPCOB3RwcP95CzRVkM2jo94TGL?= =?us-ascii?Q?594okz3+L1vIH5OkyK4Bh3lRR+YgCzPSKSPCuRgF1xgBxR8eQBVcNDqSihx6?= =?us-ascii?Q?tTkUPXOnHx4RXDzzWnOikr+DcHEarXuJY0ncvOjo72DiPZJGsS7HNJMgdVSO?= =?us-ascii?Q?LR3vVhXXsJvscUG+Jz2jFHqjPVhaGoOipuEJ2C3GTsX0w?= X-Microsoft-Antispam-Message-Info: tyAwa19BTRViMbRht6NmN0dCNPhtNLvdFCZT7weHvzSDCjBFj0Ub1piso6/7KIOaEcZIl8zGlkFsmBjtOefBoeRAHukCQw8109ph7fQk1+XJMAj7lBMd3/TdhV0zBPc84ARJxhFueG3K1vfQ+y05j7q2+0OTF4gSBtP+AFskC13nSClodzFGIaUxFljJmOzY X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 6:v+Pe9z/riYwqqGa4Xgl0E9OAwyTqpQnffJI+O4+MX9aczoZXqddh4RMcDxdhUZqKDiw43iqdFfmiTXJf41NvknS3paeV5yQXQ/NTZhagVXV1sZoHBrsunucPP51m1hNWVuztLhOo8ibb/WeLZsbJzCbNGJDtl9GdNieGags6r/wAZJDZB44P8IwB7sSYbkL2Z05klvIUlyOsxXq/17yKTUgHPdxpBoEeAatJ8WOq+lyYCwoM/yzyXYZL09MSqU2s5RlzKsn+sk0tqI+qXrH9e3i7EjpmvOuInrDUU2l5ihyH/7kA72MulVPDfxpqHjHIuxKB542usE9bN1DICVYsVanKtfHi2qUxIIhL1NI3ElA=; 5:p4nVv1Nljd+Pb++zqLb/MxEmis96jePFPvGGjh+uXKKARyuu338o73tXy5ZWGkDX3J1rhIgcIcVHC4JVlOvG7IiJeuXEZ0GUHjW0RNUfUAvTkaH6gv4wsNYBrRQPF964dztA+L18AIjBM9apKKUskmnkPr1uUfPF+TIPQHJVslY=; 24:BFsXVQxVHnYu22MdiS4YKgsZhepr3O1cXFGm1dMakKA18B2sltuj/pgw2IIhltWuttkQ5o1A4LxY4CUHx+fpO6GnRKwvsr0P1No2hve+uDM=; 7:zf+hOlcD+p5P7k3uOE5OMEwlmqtdhEXPUWRzVdWxuDnXCJ3/yKOFh47bPiqkLWsfBL4JBjfUGSm+hJ7jGiAbQ3aVAlJqqXN+XQnjWOwx14mH5zV2YoPR1W+WUXyE8WShrPDt81z7I8RuOhmOl3o5Cuy1gB4NgD24IgYcUHCYi3cPQP589ae7WNX4do5yli9emoswqCy1s7X8zTmetXGuDq/2+0qBJViAhtKjkRkiWMCJ/A94LHP58GOTC/CLpJGk SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2018 21:54:56.3202 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23c49fae-ca7e-462d-32ae-08d5892d0fde X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2045 Subject: Re: [dpdk-stable] [PATCH v2 2/3] net/mlx5: fix link status behavior X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 21:55:02 -0000 On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > This behavior is mixed between what should be handled by the application > and what is under PMD responsibility. > > According to DPDK API: > - link_update() should only query the link status [1] > - link_set_{up,down}() should only set the link to the according status [1] > - dev_{start,stop}() should enable/disable traffic reception/emission [2] The description of rte_eth_dev_set_link_up() is [1] : The device rx/tx functionality will be disabled if success, and it can be re-enabled with a call to rte_eth_dev_set_link_up() This means, if user runs "set link-down port 0" on testpmd, traffic should stop by disabling Rx/Tx on device. But unfortunately, mlx5 doesn't have a way to stop device but it rather relies on kernel implementation - e.g. SIOCSIFFLAGS. So, even if the command is run, traffic goes on. I guess the original implementation might be needed to workaround this situation. Shall we talk to HW and driver people regarding how to access dev (or PHY) from user-level? [1] http://dpdk.org/doc/api/rte__ethdev_8h.html#a51d7a0d2bb4202f9ebf9f174ba1f6e5c Thanks, Yongseok