From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DC1F32583 for ; Sun, 22 Apr 2018 17:10:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BC867212A0; Sun, 22 Apr 2018 11:10:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5jQM8A1yBo55gITM7 RkVYohTKsuQnyN61xDFYltNNaI=; b=vB3y42WUBIKNvpRFLlD/e2jykXHfLy8+V 74939q8Z7LqJJ2M5t8V87zqF1VeyECI15fmGxKVR2TG6WRVy8hix4uz23VKDpTiP gLmXe5PRcR+Dg2L+HmMEqh++rwSB+9yqQeA8Mx5V/LkIj9x/+zBJoCWZ1hC8u2th AL/2Df6CD8sCQ0tiGSDmw3GbqaN8P62xdHW7H0nLyJzg1DZvD0LA7PR6HYqvtXdk 4BzQdVYciOhLS2aiwCsl6XaLM9cyLvDebLSuXSMuXu4Ns+ft4r2AwfqQwJ5uPgu4 b4nE9yvDhUGfcJxrGahTA3C6Y9QuTL7XT0DYH/thbHzec4bV7lZqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=5jQM8A1yBo55gITM7RkVYohTKsuQnyN61xDFYltNNaI=; b=dwOfyQ7x Jl7zmCDouy/JNIM21E2gOGaNg+kclgv05Zk5N80+sTNOqNiCqzl7kkLU1NvpMb6D XnqNxRHsGpoNpkto2EB6OlEUDXCgCcMxc9sWlAloZiy0KTL1naiS8iPHw6V8JZ6K b2/JQcp82LCUhsnRg3G8lVRaZVmABUxHMNFGBYUDHcWUB2xrKZvTLh6lfNlj44WU gc0SqK5XUq+dkOIvm+1lDcMf5uuWsbhcRk6mBqGzMZ7Z75V7BypGcsujRDiydC3K iPlQI/6sc0ftPYH1pOVdChdUjVbr4zWLudAsGus4DS4DpXH0P4mBcTA7UYOiMD8p fzFP23Y/xT/h2A== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id D074810255; Sun, 22 Apr 2018 11:10:48 -0400 (EDT) From: Yuanhan Liu To: Gowrishankar Muthukrishnan Cc: Ferruh Yigit , dpdk stable Date: Sun, 22 Apr 2018 23:09:05 +0800 Message-Id: <20180422150949.17523-15-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bonding: fix primary slave port id storage type' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:10:52 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 9bf81086c3593e7581e5d086240607a21231ca53 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Tue, 6 Mar 2018 15:07:04 +0530 Subject: [PATCH] net/bonding: fix primary slave port id storage type [ upstream commit e54b560d2892e540567476e2588be42dbd15d957 ] primary_slave_port_id is uint16_t which needs to be correctly stored with the same data type of input parameter in bond_ethdev_configure. In powerpc, creating bond pmd results in below error due to wrong cast on input param. This is reproducible, only when using shared libraries. sudo -E LD_LIBRARY_PATH=$PWD/$RTE_TARGET/lib $RTE_TARGET/app/testpmd \ -l 0,8 --socket-mem=1024,1024 \ --vdev 'net_tap0,iface=dpdktap0' --vdev 'net_tap1,iface=dpdktap1' \ --vdev 'net_bonding0,mode=1,slave=0,slave=1,primary=0,socket_id=1' \ -d $RTE_TARGET/lib/librte_pmd_tap.so \ -d $RTE_TARGET/lib/librte_mempool_ring.so -- --forward-mode=rxonly Configuring Port 0 (socket 0) PMD: net_tap0: 0x70a854070280: TX configured queues number: 1 PMD: net_tap0: 0x70a854070280: RX configured queues number: 1 Port 0: 86:EA:6D:52:3E:DB Configuring Port 1 (socket 0) PMD: net_tap1: 0x70a854074300: TX configured queues number: 1 PMD: net_tap1: 0x70a854074300: RX configured queues number: 1 Port 1: 42:9A:B8:49:B6:00 Configuring Port 2 (socket 1) EAL: Failed to set primary slave port 7424 on bonded device net_bonding0 Fail to configure port 2 EAL: Error - exiting with code: 1 Cause: Start ports failed Fixes: f8244c6399 ("ethdev: increase port id range") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Ferruh Yigit --- drivers/net/bonding/rte_eth_bond_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index e816da31f..8c94cc617 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/net/bonding/rte_eth_bond_args.c @@ -273,7 +273,7 @@ bond_ethdev_parse_primary_slave_port_id_kvarg(const char *key __rte_unused, if (primary_slave_port_id < 0) return -1; - *(uint8_t *)extra_args = (uint8_t)primary_slave_port_id; + *(uint16_t *)extra_args = (uint16_t)primary_slave_port_id; return 0; } -- 2.11.0