From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DEB7B2583 for ; Sun, 22 Apr 2018 17:10:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8B4EB20E8C; Sun, 22 Apr 2018 11:10:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:10:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=JHKydRj6MnDQc43Em jLe9hNhpS6PF6A/7XQHhjs35/s=; b=ucX1gY8D9n/GNcwgSa7jdtJPwRwLRCfSG yAvAjkNpkMxTTC2Ln09LOAheJFDJXfp2kO7eIes3zxXjgCQgstqwSimKp/nXONw9 zV8fnXPc3Iim7z2+ko4/i0fq21VAqNXaZFWDQvLfIeK1TFs+ITBABZRE0m1EJ5Sc q7p72imikdKiXiGgsvKUPPl9eAAsA3vLgTgsqocaNYOWRJ/eP/a2YriNy/vz0ti+ 6SrDsC+E3paBZaJAQkqZN9zgyWtd7ZLkQp/pYmWfiMdwXmAxrQl8yvRijhQNxKEr cDkYCWNzgHXAOReHdxUnSAQCT7CQPOEeIA1oO+iXM0hTPmW797bUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=JHKydRj6MnDQc43EmjLe9hNhpS6PF6A/7XQHhjs35/s=; b=aHESfVQu JjFf4Ythr4Wqm09Mrll8rQ0nNfj9xhWowD15E89OCPoLl80DSlsA+XZISXKqU8Jh 5tLLac9WZQhtWaxQRly6GBHaozBwr2oNm+Q4TWyWa6tyw61SsDOGh/FsphZsGVLA PyCixwWNTGr3kxVfPLSj0vz3cKUo9lMrrT0nbTJi3dEWjryd68RYOfPlad9iRbYe oe8mDINGb53s9Jk03Qyd9/0iXuyKYNrBPBw9ttPOonpix6iyd4zBMN7Uj2gcR4oP h6sv9T0WlpqBDcSAzyrdfVb/M9lNbxb2WSiuXzg5KqJ4QO5y/00ZOYsRmaVkm7Px C9RfHUgA7br6QA== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id 1567C10253; Sun, 22 Apr 2018 11:10:56 -0400 (EDT) From: Yuanhan Liu To: Alejandro Lucero Cc: dpdk stable Date: Sun, 22 Apr 2018 23:09:09 +0800 Message-Id: <20180422150949.17523-19-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/nfp: fix barrier location' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:10:59 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 55c8d97724452f28558438ef6dafb2ff7d0c152c Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Thu, 22 Feb 2018 11:30:39 +0000 Subject: [PATCH] net/nfp: fix barrier location [ upstream commit f598e1a2d0e29293b924119c1b3cdd4e16756e95 ] The barrier needs to be after reading the DD bit. It has not been a problem because the potential reads which can not happen before reading the DD bit seem to be far enough, so the compiler is not rescheduling them. However, a refactoring could make this problem to arise. Fixes: b812daadad0d ("nfp: add Rx and Tx") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index f633a8df5..3cc3da6ee 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -1995,16 +1995,16 @@ nfp_net_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) break; } + rxds = &rxq->rxds[rxq->rd_p]; + if ((rxds->rxd.meta_len_dd & PCIE_DESC_RX_DD) == 0) + break; + /* * Memory barrier to ensure that we won't do other * reads before the DD bit. */ rte_rmb(); - rxds = &rxq->rxds[rxq->rd_p]; - if ((rxds->rxd.meta_len_dd & PCIE_DESC_RX_DD) == 0) - break; - /* * We got a packet. Let's alloc a new mbuff for refilling the * free descriptor ring as soon as possible -- 2.11.0