From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0DB56F3E for ; Sun, 22 Apr 2018 17:11:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4FB162127A; Sun, 22 Apr 2018 11:11:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zLPLgSIQFfeOKBT2o +f5wBSJOhIuQchmalktXgpqq5s=; b=JXUhQdk+sHTQG4kQZzZGnt0nhUUtndmYk 9BgrwHlSIyoFBQBg15eEcy30F1yV48LdezB37h9KNRpaNT+JBtNoKUxkWXIbtdgt XK9v8rqhhBQeUS2lrEFfTd3vOJuianmerGTeaa0qBWWvlNnG/YnlSIwVHrz352OP TO9UlNmzyengisbviP+kuvtCBNirowbGTMTj8ZHPBZFA7alZHPrk+gA4EDztig28 Cf9KIBaw1Y7S52RSxEFgVdSCO18rmeA0j7+/PXZIQXw2+/Igi+LnB3M3lpGl1769 DemZon8flC5QKux2wFEhQMK1JqaTSN0uJnd9YRMP6VgB0Zigw+eCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=zLPLgSIQFfeOKBT2o+f5wBSJOhIuQchmalktXgpqq5s=; b=Jad8uVBx uQKiUDsh0rrISEsLXbMe3k8MCKCbkL/GJHweWjwKl3jh05YgmEn7xdPA9jFu/9FI VpeUq6meAtBxR54pLbNHswmTWcZ1TaQJVoW0gH/+cpxPWou1fQcn1GnIb4GNo+28 0HKrq5R9tFnf9CePluwFDIdHuBiVek9dbpnh3B2Adc4AbZ9qL4p9hZjUgAR/chp7 YnjWToJLxsr6RVuWkrgbuviY5+3MZOroqcp2F9ED80E+9DTcDE5x5VrfOYV/nSIO lNUrt3pQegXbB/GLowqi+fmtI5LBJp96BByYDvm+a/qlFindtvjMfOrJVVcbB+c3 3lyEL8YIkR7S0A== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id 4598210253; Sun, 22 Apr 2018 11:11:18 -0400 (EDT) From: Yuanhan Liu To: Xueming Li Cc: Nelio Laranjeiro , dpdk stable Date: Sun, 22 Apr 2018 23:09:18 +0800 Message-Id: <20180422150949.17523-28-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix existing file removal' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:11:22 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From eefca081f86f15b13c059c45940d2258628aeaf6 Mon Sep 17 00:00:00 2001 From: Xueming Li Date: Fri, 16 Mar 2018 23:22:27 +0800 Subject: [PATCH] net/mlx5: fix existing file removal [ upstream commit be939f60f42673eaa99609ea2c9f876e29320eff ] There is no guarantee that the file won't be removed by external user/application between the stat() and remove() syscalls, remove() will fail if the file no longer exists. Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor") Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_socket.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c index 5cd1ab80f..ddfdc9a8e 100644 --- a/drivers/net/mlx5/mlx5_socket.c +++ b/drivers/net/mlx5/mlx5_socket.c @@ -59,7 +59,6 @@ priv_socket_init(struct priv *priv) }; int ret; int flags; - struct stat file_stat; /* * Initialise the socket to communicate with the secondary @@ -79,9 +78,7 @@ priv_socket_init(struct priv *priv) goto out; snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d", MLX5_DRIVER_NAME, priv->primary_socket); - ret = stat(sun.sun_path, &file_stat); - if (!ret) - claim_zero(remove(sun.sun_path)); + remove(sun.sun_path); ret = bind(priv->primary_socket, (const struct sockaddr *)&sun, sizeof(sun)); if (ret < 0) { -- 2.11.0