From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3275B2A66 for ; Sun, 22 Apr 2018 17:11:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B35D020EDC; Sun, 22 Apr 2018 11:11:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:11:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=R82TUqoAoCQ8rNTkE l8m1oKw8SXqKqFZgkTZHXBu1KY=; b=sfQqL08pxVvb8tuGYbE8ecynIqgluJ1M+ kSO8vhG5+T9NTlvvtfiFT7ZYIH/zXenmKkTYQX2rkiA3rsGuTqhA4KbYFLyRwvK6 HNiaVSdX5dqxYFR29GLZwmZ4qlyJcVR2a8l84J5nzndV9QirMzVcZ7ERMULbDDpm 6XwbVScbtiqLPG8brwjqQ4gN73dO2q8zsE3Yq6YEfBaOEAzxvz8ehE8sOdtkxIAl 6ZW6Kbqk7H/IBq/g01Ol9r/QXZd3SmaiLXBB606Y7eN+G7p4n2Pc9kNyjx5Ve31z wuxIxA+CM2gORS2WDXDhydxACdDw2hHZDZ9jVcjyify0NXvkooWUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=R82TUqoAoCQ8rNTkEl8m1oKw8SXqKqFZgkTZHXBu1KY=; b=jinWJbFs nH9nIOWxxYKsOST6uj1IPiSMvpAAM2/4VxRocd37s+hgtuOKD0LtlQIYpQT4pxxD UAcaxdAxTo82ewfOR3qlzsDf4Lpgj91hSXaO9V/1nDP9BKDoiPlCBp++KHbx1PpW SLwhTMpHVg5ZSUkSKbp/84v68/AgjjvPjZNqm+hu6rHoMEOzKYol74IKUth0WJNk 1dvt0iaPdZFYJfeXqP26QK2q5D3nAEaIhrUkiCIsCvq4Kl3xbLmCQpCHH6MHtrny 38HoaZbswYCWpcGizLslXyZefvUz3RGfDl4v2lYdIR8EZlWiZbU8R1YAHvQCsg+y d0rDnPq7o2/x0w== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id AEF2710253; Sun, 22 Apr 2018 11:11:25 -0400 (EDT) From: Yuanhan Liu To: Qi Zhang Cc: Konstantin Ananyev , dpdk stable Date: Sun, 22 Apr 2018 23:09:21 +0800 Message-Id: <20180422150949.17523-31-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'ethdev: fix queue start' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:11:28 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From e44d77b107e817189dd1b4dd3c54a4da00724468 Mon Sep 17 00:00:00 2001 From: Qi Zhang Date: Thu, 22 Mar 2018 20:59:01 +0800 Subject: [PATCH] ethdev: fix queue start [ upstream commit 239c9b435ad4abcac89b5d2480a0c21ce8b8288f ] Device must be started before start any queue. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Signed-off-by: Qi Zhang Acked-by: Konstantin Ananyev --- lib/librte_ether/rte_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 4d23bc1c2..eea11d066 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -533,6 +533,12 @@ rte_eth_dev_rx_queue_stop(uint16_t port_id, uint16_t rx_queue_id) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); dev = &rte_eth_devices[port_id]; + if (!dev->data->dev_started) { + RTE_PMD_DEBUG_TRACE( + "port %d must be started before start any queue\n", port_id); + return -EINVAL; + } + if (rx_queue_id >= dev->data->nb_rx_queues) { RTE_PMD_DEBUG_TRACE("Invalid RX queue_id=%d\n", rx_queue_id); return -EINVAL; @@ -585,6 +591,12 @@ rte_eth_dev_tx_queue_stop(uint16_t port_id, uint16_t tx_queue_id) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); dev = &rte_eth_devices[port_id]; + if (!dev->data->dev_started) { + RTE_PMD_DEBUG_TRACE( + "port %d must be started before start any queue\n", port_id); + return -EINVAL; + } + if (tx_queue_id >= dev->data->nb_tx_queues) { RTE_PMD_DEBUG_TRACE("Invalid TX queue_id=%d\n", tx_queue_id); return -EINVAL; -- 2.11.0