From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0CC9C2583 for ; Sun, 22 Apr 2018 17:10:23 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9A78E20FDE; Sun, 22 Apr 2018 11:10:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:10:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4mXiwVyZ332wV16Za hTePAqT0TYYr/eiDvamev3uLvY=; b=uUMwOkApJ9nYFMO/lY3iU751o1lGQSRI8 0Fi/uWOhjvwmuVLuuiE01jqYmQ4uv/vEeMmSactB9GcwbhupFyOiLTfZDmu4YZBs ucDrTLYvMpbQpEvIgP2AwC6aKVg8z8qbHo5s52JmQAxo2CtHCpMu17l33SRWn9Dh tDfV0KNgCjH+fHUcz4Ks+80SAuhXruq8Q4QPCTJXU6YK5Vo6c/RobPhCPqISx0Oi wKLWCBuEwhUUxzBA4Ia6nkaQ4T8D7XkIcJpgkgB6pAh2BIXQeA0epjPeueXuP6eD UWaMdLDH5sRbxo17EbO/tfk4tBDxuWDdL7hSw2+2vGedjumpYztiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=4mXiwVyZ332wV16ZahTePAqT0TYYr/eiDvamev3uLvY=; b=A3QaliZp tycS3/6WadKbiE901WqrTZuXlWm8qd3eM66/KuwHsyy99neQWNETnYeNVxYJh6rw BMAznViFq/7p2PzZWMzHDr8JMxKlU0fwyL8c4mSXnh8tzhqvvZ/gftgpKZql2BlS VK69+COmad2ZS4r7Upbe58zH6oFhBU8DVRJywk917uFk7GOYND6Tukg2ylGWM+df 6sDxsUklg2ODh+FKowOBIwr9y5Vh7ghS1Xwqlug4oLT2rqzRRFd9xK2ZcjDg5cMT 1Rzygmp4ksDkBr3QXhFG6IC0Li5HcmmvTfdVPVDvZ8ehkBI612i21XimFN7uGftA VUOwg8irsu0eFA== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id AB67910255; Sun, 22 Apr 2018 11:10:20 -0400 (EDT) From: Yuanhan Liu To: Nachiketa Prachanda Cc: Jianfeng Tan , dpdk stable Date: Sun, 22 Apr 2018 23:08:54 +0800 Message-Id: <20180422150949.17523-4-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'bus/vdev: fix finding device by name' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:10:23 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From f894e1f530c1aa8585bd1456b73696631c51f615 Mon Sep 17 00:00:00 2001 From: Nachiketa Prachanda Date: Mon, 12 Mar 2018 09:54:00 -0700 Subject: [PATCH] bus/vdev: fix finding device by name [ upstream commit fada6963ce735048b2d40f215ff110cb2f4cb6a4 ] Use strcmp to compare device names as the strncmp in original code causes find_vdev to return -EEXIST for names that are prefix of another. The creation of interfaces fails unpredictably based on the order of their creation. An easy way hit this bug is to create eth_vhost1 after eth_vhost11. Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct") Signed-off-by: Nachiketa Prachanda Acked-by: Jianfeng Tan --- drivers/bus/vdev/vdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index ba0ed7a27..a0ffb534e 100644 --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -129,7 +129,7 @@ find_vdev(const char *name) TAILQ_FOREACH(dev, &vdev_device_list, next) { const char *devname = rte_vdev_device_name(dev); - if (!strncmp(devname, name, strlen(name))) + if (!strcmp(devname, name)) return dev; } -- 2.11.0