From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 619052BA3 for ; Sun, 22 Apr 2018 17:11:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E21B620E8C; Sun, 22 Apr 2018 11:11:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:11:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=bovb8fWO101GZ8oy0 AW11aEfjAxZAThDQmS2Sf3gGXg=; b=axDVeftVegM2SeSl9cNIX+8NHKJgiPSkl flJ5al6T92KSy8vVrvbAnRQ8jKbLQxkxJmnQLBSUqYIffpFCgSMderQOv8er4LDS iIm4n7A2ZcsuYSD7Sb53a52QlSaG6Nn7OLJ/MlHp3qMcXaRRrarnY8tV7Qi8Dw0q 4LaSyRHTtwOk1Nz0QAq/iuHGBkwHthJJdax+fIrcQS1NMIDTXmXea81+nJajJ9Mj vz94ZgKrHIQ82XRjOh4aH3bfIbPuhYU0M28GgOLEBVDXdWIiCT+U/4cQuwkyDJQJ kf2Kyi8ragVGv9XYriYnViDV98/RRbAb3JZIZNeFrOShD7WNnX2MA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=bovb8fWO101GZ8oy0AW11aEfjAxZAThDQmS2Sf3gGXg=; b=T9lj/XJk +jvlhDcuG12uxApxie96m5+qRrGGz+ClXNOcYonhNl88fmf+81mHmrszAwfvS3dk LnXJcFysRyg/s2nSMYO5BamYdk2VzICGnnuNY+gynTqNEQJSHxgbKRDYyA/qYjwS UFvGp8YNqt/svqsfwYMOCoMcX3T1pe1CZl/VXluXc4YaLzOpL5fzzMtPRRdF9eW4 AsM+4t4ZFT6H7lasgx6nZJHdr5p3HDml3qxnKxvJbctLNiQEeZCtuy2gS0AuMIYY J4P8DKKr7k2sjtqcAjS+sWZKAo9Rh+mMVf/gqnZWLtDXmiTLsDUQcc+AeNQqK43Q qoSkj5SozYbQvQ== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id CBA6510255; Sun, 22 Apr 2018 11:11:53 -0400 (EDT) From: Yuanhan Liu To: Anatoly Burakov Cc: Santosh Shukla , dpdk stable Date: Sun, 22 Apr 2018 23:09:32 +0800 Message-Id: <20180422150949.17523-42-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'vfio: do not needlessly check for IOVA mode' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:11:56 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 9b5e52ab4bed30d8fa461fd17b92fe4497c0c4dd Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Wed, 4 Apr 2018 15:40:47 +0100 Subject: [PATCH] vfio: do not needlessly check for IOVA mode [ upstream commit bef5a2d629d536a82c81c02b84684da828c0e37f ] We already set IOVA addresses of memsegs and memzones to VA address during initialization, so we don't need to check whether we're in RTE_IOVA_VA mode anywhere else. Signed-off-by: Anatoly Burakov Acked-by: Santosh Shukla --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c index fb1a62261..a75ef5a10 100644 --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c @@ -710,10 +710,7 @@ vfio_type1_dma_map(int vfio_container_fd) dma_map.argsz = sizeof(struct vfio_iommu_type1_dma_map); dma_map.vaddr = ms[i].addr_64; dma_map.size = ms[i].len; - if (rte_eal_iova_mode() == RTE_IOVA_VA) - dma_map.iova = dma_map.vaddr; - else - dma_map.iova = ms[i].iova; + dma_map.iova = ms[i].iova; dma_map.flags = VFIO_DMA_MAP_FLAG_READ | VFIO_DMA_MAP_FLAG_WRITE; ret = ioctl(vfio_container_fd, VFIO_IOMMU_MAP_DMA, &dma_map); @@ -813,10 +810,7 @@ vfio_spapr_dma_map(int vfio_container_fd) dma_map.argsz = sizeof(struct vfio_iommu_type1_dma_map); dma_map.vaddr = ms[i].addr_64; dma_map.size = ms[i].len; - if (rte_eal_iova_mode() == RTE_IOVA_VA) - dma_map.iova = dma_map.vaddr; - else - dma_map.iova = ms[i].iova; + dma_map.iova = ms[i].iova; dma_map.flags = VFIO_DMA_MAP_FLAG_READ | VFIO_DMA_MAP_FLAG_WRITE; -- 2.11.0