From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 039192BA5 for ; Sun, 22 Apr 2018 17:12:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A7B4020EDC; Sun, 22 Apr 2018 11:12:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:12:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=9Iuavl4JLMRfVGoqQ /WVNjzZaEX5KlDulgP8IkRAXvk=; b=jFQbIROHL9gfpNyEen4IEGaEfXlnCLlOG 1qTTuNvM1AZ2OhS+210C0D1YiccPxD+MKrJ/WpCStgttBZlDM8BME6Rl1jkQffgi lfVE1AWxsEIIGfTgs1+unbZAXPHm25bgsfU89tquD1C49b3Iyqp27CseBY84sDer s+6/bq5PFLq5R29kkdPouP84Eljhz8k9bZAWP7546pxZ/D4qwsoG8I0BLCu7hPwl x9CgOUiOr4Wh0TfDlIN2YQDf4ydKggbt1BD2AUzBcQn3tv87SPm+axKE4L9R3S6u SqM2LNMHcZVKnhdF60G2PbNS4SwHshHbxbGM7Zaz2Ww+xVwzedh4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=9Iuavl4JLMRfVGoqQ/WVNjzZaEX5KlDulgP8IkRAXvk=; b=nMeIhdR4 HVAjLEje87bJX1u+IN9WtKzIzP8dFWb9Dv+dn6r4D0WThnPVlWBLXZEv+OTifD9r 9xxKuizbvICJ0rOid/MIkRu95p/YLBHefHJ+0YvHd7zaZnz0cZwvg6smd2ZFTWDe uC+5Mewcbnr9savxfz3hSN0b5rNBzK1lCxEVvEV40v6iWazXteo0JnF2uhIDXwAq Uyi2asHN8IoCTiUk+HskJhiE0u4OqG2wUUMjrtTz5SIr6MwqhfhGNpqHuNOl2GH7 v7SsGu/sLjDNl8S0KPnMithUiwFBguMs87g5NOA5RrOYbUsD/SYj2Wq4D8Z0qrvH nlKkdHDV1tdZ+w== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id A8E8510253; Sun, 22 Apr 2018 11:12:06 -0400 (EDT) From: Yuanhan Liu To: Stephen Hemminger Cc: Jerin Jacob , dpdk stable Date: Sun, 22 Apr 2018 23:09:37 +0800 Message-Id: <20180422150949.17523-47-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/octeontx: fix uninitialized speed variable' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:12:09 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 951d4d74a16a677dd2b5d65c2dc295b9ea8062cd Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 5 Apr 2018 08:12:28 -0700 Subject: [PATCH] net/octeontx: fix uninitialized speed variable [ upstream commit 3a4b87c897d6e746ce53bcbe70a35e44654c7434 ] This is fix for Coverity Defect 268319 about uninitialized speed in an error case. Also drop unnecessary assignment. Coverity issue: 268319 Fixes: 4fac7c0a147e ("net/octeontx: add link update") Signed-off-by: Stephen Hemminger Acked-by: Jerin Jacob --- drivers/net/octeontx/octeontx_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index ec03e4c8a..33c6e78e6 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -537,7 +537,6 @@ octeontx_dev_link_update(struct rte_eth_dev *dev, struct rte_eth_link link; int res; - res = 0; PMD_INIT_FUNC_TRACE(); res = octeontx_port_link_status(nic); @@ -571,6 +570,7 @@ octeontx_dev_link_update(struct rte_eth_dev *dev, case OCTEONTX_LINK_SPEED_RESERVE1: case OCTEONTX_LINK_SPEED_RESERVE2: default: + link.link_speed = ETH_SPEED_NUM_NONE; octeontx_log_err("incorrect link speed %d", nic->speed); break; } -- 2.11.0