From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8881B2BA3 for ; Sun, 22 Apr 2018 17:12:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 38BE920E8C; Sun, 22 Apr 2018 11:12:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:12:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tpAegmXIBLyDoFiCX iKEMGbHu28+/IysHosV3UyV7Ys=; b=V3j7sqQRoxCVbklskVPOIElQGAVJU+ht4 m+pGr7SvNF5cr9jNx4SVUJbAfwTDqzLz3674P63kKi14GK7CzIkU+88dMhqkRnyQ u6Zf9y4iAS/LXohbm3OewtDvMoqTbEs4Ag/WncSmpeCkuaBul0nKr9lwQ3rrgfDo +rD7BYtDnqTakglABn+xybqvveJYkHcj2jfDQu4cH0OmuGLXzSXVT0OcEoDyHjuW 8Uo6sYpnamufe4dJdWrBvN1Ptemyjjw8/d1zbSBywh1vkNxzpqKmYweEXrz/QFo7 WbWz9eX7vFp6slIaF7IF+AZOctiLUSEN0YbaKQgMewdIOzwivFCYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=tpAegmXIBLyDoFiCXiKEMGbHu28+/IysHosV3UyV7Ys=; b=lk1NWPuF SUdxvcVQrftydTpi/UX2KJTdOwQzUx8qMyb4/qzJRaP+S4lBACI3y+qSxjEnzLj+ erRwlvV++j1utyX+T3jaqhB7FQY5Q4ru0lTaYwNqr5QxybPcvKuI3G+OAVPtGVE8 vbNuSWhvh4XKUuYNQJG9PcqB1VrW9Wy9eIAPmQJ0iHzXdcGgYzbesYZ61AGHNGZt OSDHicujv5q0L8TWldttt4ZUD5QLTB4cIUxJR0nV2IRX8aNo4qYkkwjMb8i7Y4bz 6KAH6nxtURk3o9bliv0XmIKiPsNDz5wmOubDXuJF1ia+HEi7+rwbLqAkvpdQTZkf cZR2bz7j9B74eQ== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id 418E01025C; Sun, 22 Apr 2018 11:12:34 -0400 (EDT) From: Yuanhan Liu To: Tonghao Zhang Cc: Ferruh Yigit , dpdk stable Date: Sun, 22 Apr 2018 23:09:49 +0800 Message-Id: <20180422150949.17523-59-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bonding: free mempool used in mode 6' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:12:37 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 45955450becaf6f4d2801105151465fc5a2bc915 Mon Sep 17 00:00:00 2001 From: Tonghao Zhang Date: Tue, 10 Apr 2018 21:34:28 -0700 Subject: [PATCH] net/bonding: free mempool used in mode 6 [ upstream commit b9c0dea24beb4b893e88d93c1b52481003ff8999 ] When creating bond device with mode6, dpdk will create mempool for arp packets. If free the bond device and create it with same name, there will be an error. Because the mempool is not freed when destroying bond device. Fixes: 06fe78b98ccd ("bond: add mode 6") Fixes: ea0c20ea95fd ("apps: use helper to create mbuf pools") Signed-off-by: Tonghao Zhang Reviewed-by: Ferruh Yigit --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 08444d9fc..e58d8bde2 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2972,6 +2972,10 @@ bond_remove(struct rte_vdev_device *dev) eth_dev->tx_pkt_burst = NULL; internals = eth_dev->data->dev_private; + /* Try to release mempool used in mode6. If the bond + * device is not mode6, free the NULL is not problem. + */ + rte_mempool_free(internals->mode6.mempool); rte_bitmap_free(internals->vlan_filter_bmp); rte_free(internals->vlan_filter_bmpmem); rte_free(eth_dev->data->dev_private); -- 2.11.0