From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B91A12A62 for ; Sun, 22 Apr 2018 17:10:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2E56020FF8; Sun, 22 Apr 2018 11:10:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:10:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TeClDLtq9lKigLsWW LHjNd1piTvsCgEwSGCb5eIWX+U=; b=S86Xu0isz31GnTpIvldxUrogEGZw8sG45 YpkVaxVsK3LVAtOzrBjUShw/YpLuyDfRonDoz0mAjgiaq0G5cA9/SR+NBpraLY60 HpBOj+Kc5xpwvrtqjdhoJ+wmd8PP+JW1LaRI4ysGrjXMLFBINkqtiU6sXy7bFrIV mWlRiuKQq3j9FMMiUWu+mY/yARK5Wa/HvlHLvslW2w3u1e/V2Gm1q/Pdp6RZj+Pt xxdF8jIglV2mUn8qr5Px8o9wn/xwijanXX5Q2oZTCKmhDolCCaa02RvNoufTUOqy uiunKaTLmAw5gkJQ7XddBl2sKsWIvFV1WUgqx+SRoPY/ADI47zn2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=TeClDLtq9lKigLsWWLHjNd1piTvsCgEwSGCb5eIWX+U=; b=gHtKzqWH YB9xLb0cu2E7VY5nP/sx/noRxA8ttQUwn9J6kGiANWNXW8CzmR3PM3ApRv6vorvM yRTXNG21Qm6hGIcybVcUT54irv/spV6KAM5vA2Zo/nq9G13hv068leZg5Olz85t0 JhL/JRsSCI0OO3Kz8AzRuaVGYv8MHeFfX0WcjCpoMzkey5xn92w78bQk0j6YkqJU k2iJL6yTFNZ2mWb5xE7ymt0iMAmyEoh6kasyb9fof3Je2O5jddz3B4PlH+xmxSIC B4DeAR9y/C/59ZRMJONgKHs1mQoRNFwwpJrkZNkrIkseKYF/GLpv/ga2BsLFTLIV 0i+MF8Dw7TcRBQ== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id 8BA721025A; Sun, 22 Apr 2018 11:10:25 -0400 (EDT) From: Yuanhan Liu To: Radu Nicolau Cc: dpdk stable Date: Sun, 22 Apr 2018 23:08:56 +0800 Message-Id: <20180422150949.17523-6-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'examples/exception_path: limit core count to 64' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:10:28 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 5d8b7a35d8799ed1f1e5d0e503ab48c48604575f Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Tue, 20 Feb 2018 12:05:57 +0000 Subject: [PATCH] examples/exception_path: limit core count to 64 [ upstream commit f93c7cd0823c2b268dda209e1ca8827e01900b3f ] Application doesn't support more that 64 lcores due to command line limitation of using a coremask that is parsed as a 64bit value, so changed it to reflect this limitation. Coverity issue: 30688 Fixes: af75078fece3 ("first public release") Signed-off-by: Radu Nicolau --- examples/exception_path/main.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c index f8f5bbdf0..dc1d9641d 100644 --- a/examples/exception_path/main.c +++ b/examples/exception_path/main.c @@ -70,13 +70,21 @@ #include #include +#ifndef APP_MAX_LCORE +#if (RTE_MAX_LCORE > 64) +#define APP_MAX_LCORE 64 +#else +#define APP_MAX_LCORE RTE_MAX_LCORE +#endif +#endif + /* Macros for printing using RTE_LOG */ #define RTE_LOGTYPE_APP RTE_LOGTYPE_USER1 #define FATAL_ERROR(fmt, args...) rte_exit(EXIT_FAILURE, fmt "\n", ##args) #define PRINT_INFO(fmt, args...) RTE_LOG(INFO, APP, fmt "\n", ##args) /* Max ports than can be used (each port is associated with two lcores) */ -#define MAX_PORTS (RTE_MAX_LCORE / 2) +#define MAX_PORTS (APP_MAX_LCORE / 2) /* Max size of a single packet */ #define MAX_PACKET_SZ (2048) @@ -133,7 +141,7 @@ static uint64_t input_cores_mask = 0; static uint64_t output_cores_mask = 0; /* Array storing port_id that is associated with each lcore */ -static uint16_t port_ids[RTE_MAX_LCORE]; +static uint16_t port_ids[APP_MAX_LCORE]; /* Structure type for recording lcore-specific stats */ struct stats { @@ -143,7 +151,7 @@ struct stats { }; /* Array of lcore-specific stats */ -static struct stats lcore_stats[RTE_MAX_LCORE]; +static struct stats lcore_stats[APP_MAX_LCORE]; /* Print out statistics on packets handled */ static void @@ -362,7 +370,9 @@ setup_port_lcore_affinities(void) uint16_t rx_port = 0; /* Setup port_ids[] array, and check masks were ok */ - RTE_LCORE_FOREACH(i) { + for (i = 0; i < APP_MAX_LCORE; i++) { + if (!rte_lcore_is_enabled(i)) + continue; if (input_cores_mask & (1ULL << i)) { /* Skip ports that are not enabled */ while ((ports_mask & (1 << rx_port)) == 0) { -- 2.11.0