From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 152E72A62 for ; Sun, 22 Apr 2018 17:10:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5BB6120E8C; Sun, 22 Apr 2018 11:10:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 11:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=RXs0taRVKqvyGOoTP CQfHJnWzWF188O4VAQvDNMlstM=; b=pRiyhcBjcSYddTkrPQJkQ4RfGVNOv8CY5 m5/m+YIsrVe2070DMaRApAwnnv7CtGuzzCHYuRJRBJLIHyTvS03TD7Z17ADBXJeW v7NA+KI3+ModpzgOBbXvsLbVSgXJj7QCQNOglTke1lDjp90rvUDrGAJQRwpJfMAs RCVjgoUqS7hXFxlTU+TJDudqZX32D2fRVatvaN61uc7SV4lk1qGMZBCpvXmSgi9A xNbSltvsoWqHZ2C1vKYZcI/7WlUVKl/YyVj/CJma5ikGGiWRMREC8yr8ydlbDqum FBA4VjJVJuXbGR2aWUuLsIZgb7RUrMrPxNXBYPG/znsjnYob5y3iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=RXs0taRVKqvyGOoTPCQfHJnWzWF188O4VAQvDNMlstM=; b=KhR3v0Xc jIQg+IXGCcjXcdBC+eBCRv1zUJKh+iIqo8VaFNfqxEYYJgQRMEUfiugADj+sv8Df giYIg5WcFvIGZL9W4mIXbnhVSAXBSapNZLWQm1l+y8YnVhMgN+90uXsvLgxUEWiS rw4qOEVMbDmotiBUzVkSCRGlJv4/4F6sA0QW+UrMEnyBlMSxPyfCe4dLmHq4/9QO 7wJH3Fqy2iqX5yFACe72xtsJtmt5nTGCTLlr2ISXbmFF3vSl9sRKiS5Qfao0WXhW ae3NDSVtAl1x2kbX/6b3zAajSkf0yuQqAeJ1TyCeZTZMToAD7Js4hv/sfG7B9/1P 6Nayu+XtveyIsw== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id 91CF110253; Sun, 22 Apr 2018 11:10:27 -0400 (EDT) From: Yuanhan Liu To: =?UTF-8?q?N=C3=A9lio=20Laranjeiro?= Cc: Adrien Mazarguil , dpdk stable Date: Sun, 22 Apr 2018 23:08:57 +0800 Message-Id: <20180422150949.17523-7-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180422150949.17523-1-yliu@fridaylinux.org> References: <20180422150949.17523-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix flow creation with a single target queue' has been queued to LTS release 17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 15:10:30 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/29/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 889f8e89691e5047d3bad7ec352e22691e26f304 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?N=C3=A9lio=20Laranjeiro?= Date: Wed, 14 Feb 2018 16:04:45 +0100 Subject: [PATCH] net/mlx5: fix flow creation with a single target queue [ upstream commit c55a1667950f43be515c976269749a2a00c7268d ] Adding a pattern targeting a single queues wrongly behaves as it is an RSS request, ending by creating several Verbs flows rules to match the RSS configuration. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 092644ff1..3a9407b00 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -951,6 +951,16 @@ priv_flow_convert_finalise(struct priv *priv, struct mlx5_flow_parse *parser) unsigned int i; (void)priv; + /* Remove any other flow not matching the pattern. */ + if (parser->queues_n == 1) { + for (i = 0; i != hash_rxq_init_n; ++i) { + if (i == HASH_RXQ_ETH) + continue; + rte_free(parser->queue[i].ibv_attr); + parser->queue[i].ibv_attr = NULL; + } + return; + } if (parser->layer == HASH_RXQ_ETH) { goto fill; } else { @@ -1777,6 +1787,7 @@ priv_flow_create_action_queue(struct priv *priv, { int err = 0; unsigned int i; + unsigned int flows_n = 0; assert(priv->pd); assert(priv->ctx); @@ -1801,11 +1812,17 @@ priv_flow_create_action_queue(struct priv *priv, err = ENOMEM; goto error; } + ++flows_n; DEBUG("%p type %d QP %p ibv_flow %p", (void *)flow, i, (void *)flow->frxq[i].hrxq, (void *)flow->frxq[i].ibv_flow); } + if (!flows_n) { + rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, + NULL, "internal error in flow creation"); + goto error; + } for (i = 0; i != parser->queues_n; ++i) { struct mlx5_rxq_data *q = (*priv->rxqs)[parser->queues[i]]; -- 2.11.0