From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 06083E07 for ; Mon, 30 Apr 2018 16:08:25 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id a67so5819121wmf.3 for ; Mon, 30 Apr 2018 07:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ukZj0tz7FDKtXbP3ZAPI4TfxARA6jaHPtwgoPkmlxaw=; b=p1zIIgRfMd/ZgA3DbFx+iXAEFA0T+y9MtSy4zFXwG8Tg9AX98P0PE52gcD1ltoAU4t rUvWR3YijfWrQXmi9BCuzCYioNha2h8JmsGpqHHtJyNW0vGZLxrohOMR5wBJ+H6AtbKK vXpfyv2ZQhd3zx6K6pXwFUOcGeMNgVo2R405nyTHUxFlFArL0PrxVzMp+rVIku604LA0 Vw0GYyFVV5z+MRZtWGwNYag++jYE+ZuXBkS6fEHKhkdOGXoG59XH/lSWNOThXcJC7dYb wrNvR4Q8a09NF/KB0hY50+sOHc1RQOY37afUlUgbnrf3X/+Xkj7fW+YnItIQPSlPzXLI lRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ukZj0tz7FDKtXbP3ZAPI4TfxARA6jaHPtwgoPkmlxaw=; b=E1/vzilA+welPnDAOa16PDZ6P8Q5WpetonyJ+Is0gnvMyj46IvWoi+ul/3tgPvnSll 5vLBVylr1f74lvah5DlJBLw6ujO5TCYRBCmsHRLYbcmtNDUcK8FqJjCNMUxCvMot3AMb 1y9pb6XK9/wD5W0az96bzk9lEEBaGs64sNWQYktU7VMq8OIeDUsk3U2iZ9UrYpTdmnuL TH3ANmsalqpqw3cPDfnmVOavr956ll3G99liGeXPzVBsMqUYqDRC6HaQH/L8oJAKqKsk 2DfbVpB588RAON12Gct1n9WjxhUXgvfGWwS2FK1EHvpfkaoiWvdNaxgWN05sOgtPVepE ADqw== X-Gm-Message-State: ALQs6tBugsfOl9BlcyaVWKWjqKn5hEbU3RguN4zlt9ZgxxidZ94q6/Pd VLcu8KvgiCznEEaL4FNZUzOtpLqX034= X-Google-Smtp-Source: AB8JxZqpD/tl5+OC4JqPp6GzFPhZrRMp0NCfrs5Ahe+m8s5WszqY7OjAgXwa0qEf4no5Drgx6hBHXg== X-Received: by 10.28.26.83 with SMTP id a80mr7971915wma.36.1525097304685; Mon, 30 Apr 2018 07:08:24 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id y100sm14867536wmh.2.2018.04.30.07.08.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:08:23 -0700 (PDT) From: luca.boccassi@gmail.com To: Shahaf Shuler Cc: Nelio Laranjeiro , dpdk stable Date: Mon, 30 Apr 2018 15:03:54 +0100 Message-Id: <20180430140606.4615-76-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430140606.4615-1-luca.boccassi@gmail.com> References: <20180430140606.4615-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/mlx5: enforce RSS key length limitation' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:08:25 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From c8f1adb23ad453e40c14ee5da6327cd9394e26ff Mon Sep 17 00:00:00 2001 From: Shahaf Shuler Date: Mon, 26 Mar 2018 13:12:18 +0300 Subject: [PATCH] net/mlx5: enforce RSS key length limitation [ upstream commit a1572312f713f0b218063c6213499e36a8b47c86 ] RSS hash key must be 40 Bytes long. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rss.c | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index d5b755f54..b01dce27a 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -514,7 +514,8 @@ dev_configure(struct rte_eth_dev *dev) if (use_app_rss_key && (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len != rss_hash_default_key_len)) { - /* MLX5 RSS only support 40bytes key. */ + DRV_LOG(ERR, "port %u RSS key len must be %zu Bytes long", + dev->data->port_id, rss_hash_default_key_len); return EINVAL; } priv->rss_conf.rss_key = diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index d06b0bee1..c9db2a64f 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -50,6 +50,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, goto out; } if (rss_conf->rss_key && rss_conf->rss_key_len) { + if (rss_conf->rss_key_len != rss_hash_default_key_len) { + DRV_LOG(ERR, + "port %u RSS key len must be %zu Bytes long", + dev->data->port_id, rss_hash_default_key_len); + rte_errno = EINVAL; + return -rte_errno; + } priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key, rss_conf->rss_key_len, 0); if (!priv->rss_conf.rss_key) { -- 2.14.2