From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 361CD187 for ; Mon, 30 Apr 2018 16:42:28 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id i14-v6so5119016wre.2 for ; Mon, 30 Apr 2018 07:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cQSaYt5GRYURPXdVhDeZCEy+UyAoRuHe8k6XOmvJNrM=; b=jLAVWpLPYWwj4iOORDeDS0+ZEAkMIntamK1IAEvLqogk+p3peEcB0nks0oXJRquUEx DRd/0mtPhvOkXqAnupwQosp8ohGqu9aIrEUSTtBEtDcf7BqrL0q+BrCuQAId8MUWRTD/ t9Wjd5gXsnUlJ28PXfFcN0vdGu5zHOTYopNOw21CckSwsOlWsBjVhvEOMH0+bcS7m9DS cvIQW7ImZVZ4oXbbAxQGUt0K941bhjENMZ8s7W/0clWXk09lkXf5zR/4622l778BGfqL DIFaX4+sv3RE19QYHohPbjSgJz82r5b9HeWLkhfSdndLRZvk+Uf88g/nQglumwoe3Cyf g1nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cQSaYt5GRYURPXdVhDeZCEy+UyAoRuHe8k6XOmvJNrM=; b=d0iPZFUUl3JKiauLNF4CDw0beUfFgKZWEI1aXHuES2aEYwTA+XPxl68Lv9u8pKjcLT 04511mqiIUSLgXelwx/EKB1CsU8dDcfvA1KYcAIlHA2pEO/J/w1PejD8dSu/Cl5qfC5T lAqlGyvy3rHjyyAlNIiPmfJQn4JoN7iaxCILlD4O5KzwPTks2ULohxXUdMuguxR3S28z 3i2f+k/6L7mebQnAN5f1Lr81AOYoZSdumpQcpnxgI+Ccl6qCKBu69k0QmHPPmlqz0T/J 8UqtjKdRvGfgfVxW7s7uasi4Ji0n2HEjojy7sWu2UKjY8CQ+qiuCitg098TmNfOnGnz9 yJug== X-Gm-Message-State: ALQs6tDxr13aO1d6OYfolRRLqhqI7zqzRFk0vBP6SJft2tD1SYdPFcM8 sm8UCVMFMUJ60qNE8hMev8E= X-Google-Smtp-Source: AB8JxZqxwTIK8fa4Z5/xZAxV2NwCGHQjID1J8Up6I8FvhzzBNj97oHH74aKnJnAo+hxSUdZIcvqOSw== X-Received: by 2002:adf:c3cd:: with SMTP id d13-v6mr4307236wrg.282.1525099347420; Mon, 30 Apr 2018 07:42:27 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id b85sm3290302wme.46.2018.04.30.07.42.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:42:26 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Qi Zhang , dpdk stable Date: Mon, 30 Apr 2018 15:40:16 +0100 Message-Id: <20180430144223.18657-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430140606.4615-80-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/avf: fix link autoneg value' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:42:28 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 46002c658dea106154c93d4a8f8f85a462e29c05 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 9 Mar 2018 17:56:31 +0000 Subject: [PATCH] net/avf: fix link autoneg value [ upstream commit c3482deb7c5d5867fa8c631607421d78ae2829ed ] Intention of the logic is: If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0; Current logic is broken, fix it according above values. Fixes: 48de41ca11f0 ("net/avf: enable link status update") Signed-off-by: Ferruh Yigit Acked-by: Qi Zhang --- drivers/net/avf/avf_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index 4df661705..4442c3cd8 100644 --- a/drivers/net/avf/avf_ethdev.c +++ b/drivers/net/avf/avf_ethdev.c @@ -608,7 +608,7 @@ avf_dev_link_update(struct rte_eth_dev *dev, new_link.link_duplex = ETH_LINK_FULL_DUPLEX; new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; - new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds & + new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); if (rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link, -- 2.14.2