From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 31D36187 for ; Mon, 30 Apr 2018 16:42:53 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id 94-v6so6965912wrf.5 for ; Mon, 30 Apr 2018 07:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vIi9gUDXGfs1nxeVOocNMXgdVjfcpnv6L7m0lJZW6dM=; b=c6ClPGnvbMjjXGTQxXTwDHTdAEIgevATOzuUYYdikQPSNCPrkTXHVDxbjq4WA+uXkq WfZCVOsbSfmjOCgB9rCmlI7jpOLJl82kAcHtLxMGSgAdfFIhpwZTZ+0UUiInNaCJvWag AvRmBq5+QlvR18ZlJCCQ+mxRWqAzaWQ70EvOq1HQg8I2cBgHOdVagvf/x/bJdSJxr86O 3P/j+m5zjE+D3Y1gDOcYgAlFAlck3NKF/nLERBXS8s+tN+zF8bmRcv6OnyB8eOxOlWON qk90SIAQ2qhpLKuEC07KFh0fy/CfP4xaBWr3BYUNG6iSQrnOsYB5bcBzTwjjF7xM0YjZ n8Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vIi9gUDXGfs1nxeVOocNMXgdVjfcpnv6L7m0lJZW6dM=; b=JaY0E+VdTdOoyHjMfa2H6/XYzpFbXnff6j2heRvOzl0RZcfnFH3D1NbPOgx00H5pr5 CkzunHNpqUU2JPW85Zls0dbKhVvLhxoLoxuk6odZIprfE5eKsnrzJ+0NegqiU+CU/4v7 AnI4zxRtHHSSpV4Z9iXXDc82UtNIn/E8AjD+pbkeIl++gD5DajQs2tgE+zh6CRaN2KkF D79nZBWevvBtdQTfLxGIFac4/phj3WOekuJ3SrrWz7THIcBmEgkdAA2crdX1MEq5wYbZ Bt4k1xwEVyNo5K2iSRcdC+LvpDEz/MxqQvGeREZKf+Kp5sMsIUpcueidS20/eJQJoh5K wltQ== X-Gm-Message-State: ALQs6tBLnQvU2pLX678dnttAkcWLoBjI5geCNZ7bsKBa+bqrOiJsDpza OWvVJndL+x2uwmDldP8OMRs= X-Google-Smtp-Source: AB8JxZrRqW3brd9ptQUIccHSBvDXUr6glQRArYsJf4KLOmmhU8LkbRZmh4AAvHd71bO3BXQS+NKFpQ== X-Received: by 2002:adf:e210:: with SMTP id j16-v6mr9551239wri.118.1525099372195; Mon, 30 Apr 2018 07:42:52 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id v12-v6sm6503783wrm.68.2018.04.30.07.42.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:42:51 -0700 (PDT) From: luca.boccassi@gmail.com To: Sunil Kumar Kori Cc: Hemant Agrawal , dpdk stable Date: Mon, 30 Apr 2018 15:40:32 +0100 Message-Id: <20180430144223.18657-17-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'bus/dpaa: fix unchecked return value' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:42:53 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From ade0ca3edca5d0b3f5176e18c19f2a0b9bb0800f Mon Sep 17 00:00:00 2001 From: Sunil Kumar Kori Date: Mon, 9 Apr 2018 15:52:45 +0530 Subject: [PATCH] bus/dpaa: fix unchecked return value [ upstream commit 23386f2ece4b6d3a15b3940088edecbfc877917d ] Coverity issue: 268323 Fixes: 5d944582d028 ("bus/dpaa: check portal presence in the caller function") Signed-off-by: Sunil Kumar Kori Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index f2bb3b158..d64173972 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -309,9 +309,15 @@ rte_dpaa_portal_fq_init(void *arg, struct qman_fq *fq) /* Affine above created portal with channel*/ u32 sdqcr; struct qman_portal *qp; + int ret; - if (unlikely(!RTE_PER_LCORE(dpaa_io))) - rte_dpaa_portal_init(arg); + if (unlikely(!RTE_PER_LCORE(dpaa_io))) { + ret = rte_dpaa_portal_init(arg); + if (ret < 0) { + DPAA_BUS_LOG(ERR, "portal initialization failure"); + return ret; + } + } /* Initialise qman specific portals */ qp = fsl_qman_portal_create(); -- 2.14.2