From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
 [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 5E4A1187
 for <stable@dpdk.org>; Mon, 30 Apr 2018 16:42:29 +0200 (CEST)
Received: by mail-wr0-f195.google.com with SMTP id p5-v6so8271611wre.12
 for <stable@dpdk.org>; Mon, 30 Apr 2018 07:42:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references;
 bh=Wj8Tywqm7o7KapKkhW9aALeWg/y/ETbFesybz8hx1KA=;
 b=CFKd0c8sjZEfWNvxe6CupRARusuz9g5IPbRrUNKZ6fMUwsGF9cjcmZSRgHadKjCldN
 OCG/kfTrr0JOsHRYMVA0vK+4VuNp5tyYk94YKjtWSus0cL8us5750ZhShNiBvxZGpw50
 jVfD4I++2V7J/t5+HPUJ0YPE8SJ4lDkw2/IYmE39GL2WIiTVojlnJOsroMfXU8aJWi3H
 lrZHBmE5se2qAgxWrCsvfNZOOql3QsKFMzj6Uyi1v5G/Djx11qgZoAPnRGKTwvv1L/di
 m5vVLQlp8V116W7zZknrephWZGhb5JCFDe/c1JUd/MNWENaD9+44FaNqR6oV3GYjPqd6
 3WpA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references;
 bh=Wj8Tywqm7o7KapKkhW9aALeWg/y/ETbFesybz8hx1KA=;
 b=h6SnajjT17FDm9knFChPJ4rbq21Cs4DkJ1xxFVk+Jjid0WrPIxAqLEkxIrfEwU0Jw5
 OhMeJc4SySb2MQFsbYEwRr6E0+qz/mNlHgNerMFgqcMLHSTbSlMzqb+cAIYVNSG9u2fH
 c5/MfHvr0EABb8YFqFEn6fZbTVfemwnrD23mSIN3NnEQ5l31Kf0MskAAbIeyYATpD7De
 aYBKICyUiA7pRmEb9J5c43cqobF2fE/Twvea+nufA46N/2sc9ilYTCWDkXRVrjL26tbc
 8PgOYP0+G4N6oMwTu+tSKCzpRDzHS3+c7BLhkveipC2Cvk/HvgNoNBk/nfQVzNqZ41tV
 MdiQ==
X-Gm-Message-State: ALQs6tDBGHKhfjf8ynbrQUXbZhgRRXS6N88BhjpwyY82KBjoq82/w3mA
 cGsniJ8KwcGPg+yqdawN3Ss=
X-Google-Smtp-Source: AB8JxZqM6wfgtbxX997Q9SOVXq3BjTrvKXD3VJImcThuPJ1h75ppNxBBgP+VWJjeRycjWOp6ECHMpQ==
X-Received: by 2002:adf:93e5:: with SMTP id
 92-v6mr3858414wrp.230.1525099348979; 
 Mon, 30 Apr 2018 07:42:28 -0700 (PDT)
Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb])
 by smtp.gmail.com with ESMTPSA id o10-v6sm7421691wrg.90.2018.04.30.07.42.27
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 30 Apr 2018 07:42:28 -0700 (PDT)
From: luca.boccassi@gmail.com
To: Rasesh Mody <rasesh.mody@cavium.com>
Cc: dpdk stable <stable@dpdk.org>
Date: Mon, 30 Apr 2018 15:40:17 +0100
Message-Id: <20180430144223.18657-2-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.14.2
In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com>
References: <20180430140606.4615-80-luca.boccassi@gmail.com>
 <20180430144223.18657-1-luca.boccassi@gmail.com>
Subject: [dpdk-stable] patch 'net/qede: fix device stop to remove primary
	MAC' has been queued to stable release 18.02.2
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2018 14:42:29 -0000

Hi,

FYI, your patch has been queued to stable release 18.02.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/02/18. So please
shout if anyone has objections.

Thanks.

Luca Boccassi

---
>>From ca0da86b0468e5ec9ee9f59b0be42667e86189a6 Mon Sep 17 00:00:00 2001
From: Rasesh Mody <rasesh.mody@cavium.com>
Date: Tue, 27 Mar 2018 17:15:54 -0700
Subject: [PATCH] net/qede: fix device stop to remove primary MAC

[ upstream commit 83ade1ebdbfc8211d3cb5c2bc282c3fa396e4a34 ]

This fix is to remove primary MAC filter during dev stop. Without the
fix device start attempt to add the primary MAC fails. Perform MAC set
remove under IS_PF() check.

Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/qede/qede_ethdev.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index a91f43683..0708dc8ba 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -998,7 +998,7 @@ qede_mac_addr_remove(struct rte_eth_dev *eth_dev, uint32_t index)
 	ether_addr_copy(&eth_dev->data->mac_addrs[index],
 			(struct ether_addr *)&ucast.mac);
 
-	ecore_filter_ucast_cmd(edev, &ucast, ECORE_SPQ_MODE_CB, NULL);
+	qede_mac_int_ops(eth_dev, &ucast, false);
 }
 
 static void
@@ -1336,6 +1336,9 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
 	/* Disable traffic */
 	ecore_hw_stop_fastpath(edev); /* TBD - loop */
 
+	if (IS_PF(edev))
+		qede_mac_addr_remove(eth_dev, 0);
+
 	DP_INFO(edev, "Device is stopped\n");
 }
 
@@ -2391,6 +2394,9 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
 		dev->data->dev_started = 0;
 		qede_dev_stop(dev);
 		restart = true;
+	} else {
+		if (IS_PF(edev))
+			qede_mac_addr_remove(dev, 0);
 	}
 	rte_delay_ms(1000);
 	qede_start_vport(qdev, mtu); /* Recreate vport */
@@ -2418,7 +2424,9 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
 		dev->data->dev_conf.rxmode.jumbo_frame = 0;
 
 	/* Restore config lost due to vport stop */
-	qede_mac_addr_set(dev, &qdev->primary_mac);
+	if (IS_PF(edev))
+		qede_mac_addr_set(dev, &qdev->primary_mac);
+
 	if (dev->data->promiscuous)
 		qede_promiscuous_enable(dev);
 	else
-- 
2.14.2