From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 11C44FFA for ; Mon, 30 Apr 2018 16:43:09 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id j4so13610912wme.1 for ; Mon, 30 Apr 2018 07:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sjzq29Z/lNUZtTFnJAGtbtMTB5wMQpmfK+lzu/zh5Jc=; b=ejTvfUeVwZ+OJM6mICqKBk5vzfEfQlCklNzMCw+k/Zr5IBcOTnpqYfO2ZLr1R/tCPD orfRJBg5bdZbEK9ASD4CN8TmACV6uNPh0AKgV3L8aVymprUkXNVcYBhT84fQjJXJEKFv G3EW0cAXigkjW+Rb88wzwD5PoXPbuKZa3zUx5JL9W9R6olA3y1YHJBWOC+pmBWi+W5l2 BF3aAiaPi2Cqo6N3Zcdv6YiOG2JSzYfPH0eqTA7DHcGEDJr2YlXkhF6hdyO3wuOoDf/3 QjYJemaLVVL9hIaL34bsuZxAPbutFnFLDgiM0+PAWNE3seQim3glyYvQOp063k/ifOvd zvpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sjzq29Z/lNUZtTFnJAGtbtMTB5wMQpmfK+lzu/zh5Jc=; b=mpWTahAPE8tvGVpIat5MoGTUaIcTQgLo/am8TVvcMRvaP0JFGP7PGRX85ce8GDX8/1 o9XPKKI9+og0aYYrtcQuh3zw/+aZ9LEfcbgMJJAh+sIx0nHxS3nHe9hsbG4LHMpdMgL8 SaaP1jD0NssP96L6A4qoM8tj6HKj+e3yG1sd2gSmeAAyF1ySw9/P1z8Kkz2KE4JInmXl b9nLUNiv7puvWD96wuo4ziiNCfV2fPWfdvBJwu72c147Zr2rUu7iJUKt7g7ToI8Cbzqk bNzHmQvFKP+gsf7slaX9qhw5vhugqvgBrSgm/KbT+mL7oyMmnd+PO3+TJ8jYV2mq9HO+ V45g== X-Gm-Message-State: ALQs6tCr25QZl41cUrYLjKAefMS8edHS4dxo+DeMShQzNHrbuSZmYz8N K8F0Ry6JNyLU75rsH+py2gqkcU0u6vU= X-Google-Smtp-Source: AB8JxZq2dOUKXhVuCESMxLnbR9NID4ggovS1W1ozSstrOwlJI6gmEtvOcwrsFgfNX4g8cLBJufM+aA== X-Received: by 10.28.146.136 with SMTP id u130mr8236930wmd.125.1525099389368; Mon, 30 Apr 2018 07:43:09 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id p7-v6sm7743092wrj.85.2018.04.30.07.43.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:43:08 -0700 (PDT) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Yongseok Koh , dpdk stable Date: Mon, 30 Apr 2018 15:40:43 +0100 Message-Id: <20180430144223.18657-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/mlx: fix warnings for unused compiler arguments' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:43:10 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 25c48d65f98176221c9423c6d7236491e95cae0d Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 29 Mar 2018 14:36:20 +0100 Subject: [PATCH] net/mlx: fix warnings for unused compiler arguments [ upstream commit a11dfe9b65940106e6aab62a682b12a9324b16c0 ] When linking the mlx glue code libraries using CC, the linker arguments in LDFLAGS are not prefixed with -Wl. [The EXTRA_LDFLAGS are though.] This leads to warning messages on build: clang-5.0: warning: argument unused during compilation: '-e xport-dynamic' Fix this by checking for $LINK_USING_CC in the Makefiles and prefixing the LDFLAGS appropriately if set. Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in") Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in") Signed-off-by: Bruce Richardson Acked-by: Yongseok Koh --- drivers/net/mlx4/Makefile | 7 ++++++- drivers/net/mlx5/Makefile | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile index cc800493b..b6c05ed42 100644 --- a/drivers/net/mlx4/Makefile +++ b/drivers/net/mlx4/Makefile @@ -132,8 +132,13 @@ ifeq ($(CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS),y) $(LIB): $(LIB_GLUE) +ifeq ($(LINK_USING_CC),1) +GLUE_LDFLAGS := $(call linkerprefix,$(LDFLAGS)) +else +GLUE_LDFLAGS := $(LDFLAGS) +endif $(LIB_GLUE): mlx4_glue.o - $Q $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) \ + $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \ -Wl,-h,$(LIB_GLUE) \ -s -shared -o $@ $< -libverbs -lmlx4 diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index afda4118f..201f6f06a 100644 --- a/drivers/net/mlx5/Makefile +++ b/drivers/net/mlx5/Makefile @@ -181,8 +181,13 @@ ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y) $(LIB): $(LIB_GLUE) +ifeq ($(LINK_USING_CC),1) +GLUE_LDFLAGS := $(call linkerprefix,$(LDFLAGS)) +else +GLUE_LDFLAGS := $(LDFLAGS) +endif $(LIB_GLUE): mlx5_glue.o - $Q $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) \ + $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \ -Wl,-h,$(LIB_GLUE) \ -s -shared -o $@ $< -libverbs -lmlx5 -- 2.14.2