From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 28B77E5D for ; Mon, 30 Apr 2018 16:43:14 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id v5-v6so8287758wrf.9 for ; Mon, 30 Apr 2018 07:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Syl5/rk7hY16s52XF9ppaWzcGx5DSdpqoyNIx4Hl06Q=; b=gxijRjoq21+jv6towqMbEJ0sF3CMQlkWrcLNAds3NngAWhJysHW+t0xqI6DB36uLNK lbkiuMeG90xSqM3l/qP5V5F9nEFhbeLXH7s6L6hd8XAtX2XyX8LDPnvHU+oEt8vFKma1 icymjhZFVRaIzt37TqtTucIrprC/z5pAKQ0v1ETRaebPvPlznMTR/WVmnfScNt5hcHHj UAgRBmooeSCU9LsVIJIdodTASe30zvrKh1kQInIyVAP3tSJ4DK2WFukw2GiDY6h/qwT7 oM72TyEEnVsszNSfHMebDouk9/KyahHoT6BZHybI3tDEaLOJrGwd/8Z0Sc1pJtPKplc6 WUpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Syl5/rk7hY16s52XF9ppaWzcGx5DSdpqoyNIx4Hl06Q=; b=h/cmuPKHX1IMoTb7LaUYHa2SapP1dhYOL9xo+qCKmYybceEVdb4KGiZaJtyfPNbM2U Dhw1HICrgwbzxxHHHEE1Iz5BjMjXxVkv2COMrAcvyPwqW5j11hPVe6RFJKmQtAbVJ/63 z4x2HgtLE2oxHC7QOWxawaJ6peAS2163pFW9P7n3vIRqReOJem2UR3QXkeaejK6q5i2a L0Ty5eghQr94JM3VjURQQvkofAI2ahPJDlMt5n9Oq1dnAKbw7AW1VHKGqzdP2AfEUiVF tgC+wDV42TE3wjgO9QYQvX+QJ6kL4cYQjOHyNkB+BMWyZ6vMlZ3k5DBfvs7+c1By+BA6 b1Yw== X-Gm-Message-State: ALQs6tCQwQQOhKfZTBOcyiRM/UUswrgNk98x4KQ1BoBLPiGCmqPz45bI jshzd1dmKcofS6ALjsu+4kvaCIlZEuA= X-Google-Smtp-Source: AB8JxZqxkhFWv3AN+dyUFCw+EfPFzJFn6kE27t/Lo+Jht+1+joob+YtpOKytBrOR+1PzNP/EK3F1Zg== X-Received: by 2002:adf:d1d1:: with SMTP id m17-v6mr9423681wri.96.1525099393680; Mon, 30 Apr 2018 07:43:13 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id 44-v6sm7509539wrk.48.2018.04.30.07.43.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:43:12 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Jerin Jacob , dpdk stable Date: Mon, 30 Apr 2018 15:40:45 +0100 Message-Id: <20180430144223.18657-30-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/octeontx: fix uninitialized speed variable' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:43:14 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 90c702184941e222876816ed7ce16c27583e4873 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 5 Apr 2018 08:12:28 -0700 Subject: [PATCH] net/octeontx: fix uninitialized speed variable [ upstream commit 3a4b87c897d6e746ce53bcbe70a35e44654c7434 ] This is fix for Coverity Defect 268319 about uninitialized speed in an error case. Also drop unnecessary assignment. Coverity issue: 268319 Fixes: 4fac7c0a147e ("net/octeontx: add link update") Signed-off-by: Stephen Hemminger Acked-by: Jerin Jacob --- drivers/net/octeontx/octeontx_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 8058d27f9..311e9ce4c 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -532,7 +532,6 @@ octeontx_dev_link_update(struct rte_eth_dev *dev, struct rte_eth_link link; int res; - res = 0; PMD_INIT_FUNC_TRACE(); res = octeontx_port_link_status(nic); @@ -566,6 +565,7 @@ octeontx_dev_link_update(struct rte_eth_dev *dev, case OCTEONTX_LINK_SPEED_RESERVE1: case OCTEONTX_LINK_SPEED_RESERVE2: default: + link.link_speed = ETH_SPEED_NUM_NONE; octeontx_log_err("incorrect link speed %d", nic->speed); break; } -- 2.14.2