From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 6A6D21DA4 for ; Mon, 30 Apr 2018 16:43:15 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id f8so4106156wmc.4 for ; Mon, 30 Apr 2018 07:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6DiJAj/qv7rH86OYYjaKL1x9oBGliKUbVCzBEhneZZE=; b=BC2EFCPtMnw6PFwjTjk8faabZ74nAzD+7kMmQGT3nGgP0C1r2iuKk75lqLRIUjV6YA +oPxIAA14kpOJjPOnMFYfLQy4hqmi1FiDRyiagMJPBoYmHtK2ExKvkBT2NL9tkkmwS7Y tTeSCouVXe0JmR2Vo5kOJkdzflBydqJ8IgeYpDw2TH8n8wWhEV16hA6QcVALtTSbA+7l nbVX3Ev7PwRTJXxv/Fq2lh6KWSu9PA8r/cJ92sIX21QlzFkS+LPeMP3Aq4ET9eB6r7dM fCFDdRUF53EIb6pnXv1Yqo2sDkYMOTdSc3S11cycXexnL0WIGRbV7tDUXgc5JB5SYowz NOyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6DiJAj/qv7rH86OYYjaKL1x9oBGliKUbVCzBEhneZZE=; b=JddleqZTLAxjSp98w847wah0PijGuJWC+AiI+/R7P4oQsdBj+ZW046R0wMBhb+WLyd kO3EvSOI6I7KtlQ3hJinGoXqh1qEny8/c3KIBFYRgkqTIkifUP/hiuelAZ2zVgPEAyin gKtLaQ5DddtO4LqSl/h88JtSXXX9svW5Ukv0p7f9uMPzNjGqgva4/XHuePZV0hqtAbfJ pp32ME8Wj7iUGZkRuiBBs4/f7uASdNteg60dOZWwrPxtsg+O1uj5iV8kkl/r535E5a4e 59ciERDllQRYK8l9Zd5dfZpe8FuifNP14NkL+IzSqL1Kw+iKWt5hx6DJ27ljTku50v35 iJbg== X-Gm-Message-State: ALQs6tBCKIeHQY5J8YDg4TpurMnOBh6yrzc9XDX2by067/j3O3810Fb0 Bbnt2VxCH/iVfyl0ndl/2co= X-Google-Smtp-Source: AB8JxZrX0r3mHqbU0T7isuHO+wUwfn1V57Mq+oHUgT+75loln0XDbys42y0h3lhH+jskYtvVHbOEXQ== X-Received: by 10.28.167.80 with SMTP id q77mr5452694wme.111.1525099395154; Mon, 30 Apr 2018 07:43:15 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id a69sm7545721wma.7.2018.04.30.07.43.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:43:14 -0700 (PDT) From: luca.boccassi@gmail.com To: Chas Williams Cc: Radu Nicolau , dpdk stable Date: Mon, 30 Apr 2018 15:40:46 +0100 Message-Id: <20180430144223.18657-31-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bonding: fix setting VLAN ID on slave ports' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:43:15 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 6c7e0341c932ec4a5668a6e4e7084e4a524a54e6 Mon Sep 17 00:00:00 2001 From: Chas Williams Date: Tue, 3 Apr 2018 12:01:22 -0400 Subject: [PATCH] net/bonding: fix setting VLAN ID on slave ports [ upstream commit 3639903f488976e61752103bed546d5b87147ad0 ] The pos returned is just the offset of the slab. You need to use this to offset the bits in the slab. Fixes: c771e4ef38 ("net/bonding: enable slave VLAN filter") Signed-off-by: Chas Williams Acked-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_api.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index f854b7375..d5b7260e4 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -211,9 +211,12 @@ slave_vlan_filter_set(uint16_t bonded_port_id, uint16_t slave_port_id) for (i = 0, mask = 1; i < RTE_BITMAP_SLAB_BIT_SIZE; i ++, mask <<= 1) { - if (unlikely(slab & mask)) + if (unlikely(slab & mask)) { + uint16_t vlan_id = pos + i; + res = rte_eth_dev_vlan_filter(slave_port_id, - (uint16_t)pos, 1); + vlan_id, 1); + } } found = rte_bitmap_scan(internals->vlan_filter_bmp, &pos, &slab); -- 2.14.2