From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 2C8FDF3E for ; Mon, 30 Apr 2018 16:43:22 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id o4-v6so8285628wrm.0 for ; Mon, 30 Apr 2018 07:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=giAzTil6J3uw+NXTWvpVWLFXZTpjxDPaVS5Qtd/xyPI=; b=QLrCfbjM4WLNSy3rCpTZodbqKuW+va9NyyTDyvIuJUuhwhzHpCMPCIaaMjypgpRBlz +4UgKo3NoyW9gT7bL7JQqiI+t3qBhJA9MelqaQMdyfWMsAzpUiBTiWRNB1FWFGPF2FZ7 TDo5NQID35mfJNg8jBp2+dYFUYdVnmSW56tIWX3u6Dy1GI70LVy4w4W1p8eSFhg1Yv7V uCRbljIDhnJH9kt3IWVCSlmSSXztysxo+LXGwF6BYdkcNtGgtAjLZzA4UZ2H+71yVJ7W PFeFCH9d7NGtqvVC/XacZGibUSnUl5jn/+QhMAPOApDdrSIpfY1CGk572EZ74kZT90EX wojQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=giAzTil6J3uw+NXTWvpVWLFXZTpjxDPaVS5Qtd/xyPI=; b=CJc17BFcERCnYM5jRnVQSWznsHzMinA1fePgtenPCVY761m4eiIMgPusXS0WTMArh6 Uq9pTkaOfxJUgXyBvd3bbBaU/sBcsyBZ3mhTY9b0FyJjvZe8TkdLOPFwqIP6YYPjl4EN lz2VKV9Z4iKBCs+vVl0emU+WHIcV/bWJC2GaxeSiug/3oRhr0/45CH3C4rqPcrtyH/uI XiXP6oBOBg8+Sbtq4cGqe0uuCiMlwrway71wD2n1SfA9JsYfsv1lSHn21ZJN45xXjkfM i0zXVxeQL1PPSZX92V2/ZP2vW3Gsi+tXkWdtyheRVE8MYERgpB3LWrmi5qgKMaZRoEEe +C5g== X-Gm-Message-State: ALQs6tCbVvdR4Y8D5sfVO8T18iLMettm2PSnjRya596OQTKolkNtjjLo RbUdDRbS7QLRqxFBWVlxXztwDVnu57k= X-Google-Smtp-Source: AB8JxZpyBHUAuvpheZdvWXeF053Br7VjnT6qbqxKkH7T5PFSXdAEVZfUD9kS8pJn00zqYt3fvzHX8g== X-Received: by 2002:adf:db0b:: with SMTP id s11-v6mr8519365wri.241.1525099401424; Mon, 30 Apr 2018 07:43:21 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id e50-v6sm20740139wre.4.2018.04.30.07.43.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:43:20 -0700 (PDT) From: luca.boccassi@gmail.com To: John Daley Cc: Hyong Youb Kim , dpdk stable Date: Mon, 30 Apr 2018 15:40:50 +0100 Message-Id: <20180430144223.18657-35-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/enic: fix crash on MTU update with non-setup queues' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:43:22 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From be61adcbf957c0c7caa41e360ccc52ff2aac4dd5 Mon Sep 17 00:00:00 2001 From: John Daley Date: Wed, 4 Apr 2018 16:54:53 -0700 Subject: [PATCH] net/enic: fix crash on MTU update with non-setup queues [ upstream commit 33a2d6594945eb3278bfa441f79ae9a38ea538a0 ] The enic code called from rte_eth_dev_set_mtu() was assuming that the Rx queues are already set up via a call to rte_eth_tx_queue_setup(). OVS calls rte_eth_dev_set_mtu() before rte_eth_rx_queue_setup() and a null pointer was dereferenced. Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update") Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/enic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index caccdafff..b8147e37d 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1220,6 +1220,8 @@ int enic_set_mtu(struct enic *enic, uint16_t new_mtu) /* free and reallocate RQs with the new MTU */ for (rq_idx = 0; rq_idx < enic->rq_count; rq_idx++) { rq = &enic->rq[enic_rte_rq_idx_to_sop_idx(rq_idx)]; + if (!rq->in_use) + continue; enic_free_rq(rq); rc = enic_alloc_rq(enic, rq_idx, rq->socket_id, rq->mp, -- 2.14.2