From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id D9E581C01 for ; Mon, 30 Apr 2018 16:43:37 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id m70so13231266wma.2 for ; Mon, 30 Apr 2018 07:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ykJWEx/9g4Cob7dL05jfqMIzuagr+XwiI8oQlDlvSNc=; b=LcZecxavVT/oeB6UbjFu8DE8VHhTt/Wyun4SbslIR4zjNJ6iRuReaIxLHq2ZbubZ8s 2oQE/ZDbmtkUtwNsZm3guLQicEzyj8lpYCsrUIiLg9Sk1dVu2LyuXtneZ1ISojOmPAXn L7zRhZcGpjbN9uQHe/Hr1uYlnJEz/wpCcpN4bJsqVkXYqoV8AXgW9XJblZoc1TMjCWrG ceJflokXZ1TLhCmlvG8cEPr2Tpk+Sn0O5T7xxL0SuzCgWaFeUz5+CRa8UULT6t9FjKJk 0bovOYP4vDWeXy9HXxtXOBNg1bb2AAsFIVJniFDK5qw8n1Ms8XxYPIodEmr5Yu+KCyQp Q/fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ykJWEx/9g4Cob7dL05jfqMIzuagr+XwiI8oQlDlvSNc=; b=szICdURODk9YV15VCP9+NdWtsirs06LY/QcniasskUUK3P8iiHEGhZjRhHzD1CV1+u CZQNluHq5qewmaBIL8hiEHIxZUBQ54Fl5ZQwnmv0zA2KQtUJBvdKCM/8ZiODDM3HHSBd JMMZG2d0Sn92LEuv/aEU++PcEIWP6+JuiCdxBLoshb9Od18+zDEwSOVkuS4K3T2sJEU8 8cTmrNGUjEECEkQO/Wimk5uMdWxndUhMjqInzejJAyvK4PzQuvd5RtlGTZXgNdaE/iS8 d8mTu9DQYRYqCQh9wXt/IBU6J1053T8HnBucQehiE9vFvpdTkzZHNqe7ieyMMn3o7B9e mC5g== X-Gm-Message-State: ALQs6tBYIZ0KYzUxTA75GZZyk5Dp3rj5afU+gHvX3MJNIwjWJ6ZpDUXi 3hicyDd1KW6S/oGaK46bVU8= X-Google-Smtp-Source: AB8JxZpsP2xAdV1gAu7z2Vd7AIL0peyME+GgPpNe7HCxvVOLe3tAi2sJHNDNi38crHYNO9pMQklx9g== X-Received: by 10.28.110.30 with SMTP id j30mr7087597wmc.62.1525099417587; Mon, 30 Apr 2018 07:43:37 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id q194sm9870093wmd.26.2018.04.30.07.43.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:43:36 -0700 (PDT) From: luca.boccassi@gmail.com To: Wei Zhao Cc: Yuan Peng , Qi Zhang , dpdk stable Date: Mon, 30 Apr 2018 15:41:00 +0100 Message-Id: <20180430144223.18657-45-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/i40e: fix using error set function' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:43:38 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 6707d8d2b98bd55f10f400c271fe7431d50b42dc Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Mon, 9 Apr 2018 10:26:32 +0800 Subject: [PATCH] net/i40e: fix using error set function [ upstream commit 9ef8ebe790d8de796b50e5a1e389e07540d2ce4f ] There is a specific function to set error for flow configuration, so change to use that function. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao Tested-by: Yuan Peng Acked-by: Qi Zhang --- drivers/net/i40e/i40e_flow.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index c1b3ef4bb..f1c492a18 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -4266,20 +4266,29 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, conf_info->region[n].flowtype_num) { if (!((rte_is_power_of_2(rss->num)) && rss->num <= 64)) { - PMD_DRV_LOG(ERR, "The region sizes should be any of the following values: 1, 2, 4, 8, 16, 32, 64 as long as the " - "total number of queues do not exceed the VSI allocation"); + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + act, + "The region sizes should be any of the following values: 1, 2, 4, 8, 16, 32, 64 as long as the " + "total number of queues do not exceed the VSI allocation"); return -rte_errno; } if (conf_info->region[n].user_priority[n] >= I40E_MAX_USER_PRIORITY) { - PMD_DRV_LOG(ERR, "the user priority max index is 7"); + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + act, + "the user priority max index is 7"); return -rte_errno; } if (conf_info->region[n].hw_flowtype[n] >= I40E_FILTER_PCTYPE_MAX) { - PMD_DRV_LOG(ERR, "the hw_flowtype or PCTYPE max index is 63"); + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + act, + "the hw_flowtype or PCTYPE max index is 63"); return -rte_errno; } @@ -4292,7 +4301,10 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, if (i == info->queue_region_number) { if (i > I40E_REGION_MAX_INDEX) { - PMD_DRV_LOG(ERR, "the queue region max index is 7"); + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + act, + "the queue region max index is 7"); return -rte_errno; } -- 2.14.2