From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 737CBE5D for ; Mon, 30 Apr 2018 16:43:44 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id i3so14593380wmf.3 for ; Mon, 30 Apr 2018 07:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aPWE4qTQBC+TPIT+eg2V7UBl/+h7FlAmBauSw3SV8Ss=; b=n/3qUDc1IEoUoEecuh04ezPBZXSpRecwJAxteUeWg+WFORPYSOIscJhd9f/Qgx3i3H aItx2GBeken+DwOIPkpvl1LznElzQNXN9VIMvstXHVG1awLvvpyn6FoySeUvIMEnAf6V FtzKr5GFYAZs8A7zgA2cKBniHCTFpjAZd21OINYQzWOe8VOaq1Nsw/ECwDYECHZ286i/ V4FY2Q/KxBwJLKP8gqhJAk3F6pAgiqDO9GYkgZ/bVDMqRZm8jEXFvxifGXF3Pai9PRRQ hCuLTh1PtYeYa8FgTsHGud2W78Zdc3VpDJ7PLJNqxTXBLDEeR9vrOAsfTHENV5qTm0IJ Jjaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aPWE4qTQBC+TPIT+eg2V7UBl/+h7FlAmBauSw3SV8Ss=; b=bGSZ3TWXLpk/AtV55IXxmMJLuvYENF/hoPnc699sbSlgCGj2dqPvynO2O0O1rbcgrY pSXTIsr6jvtGYu4TkTdC5/7CRHHGmwAC901aWkgM4viwWM+Ui8kOzjhzaGLeOaO7yCPJ YF6FqswXYjmu/aRSCpOBqSPw3DXWe73PUQEBtqSi6tFoTkHHIOOsiCJyjAMnf/auAqDZ MOv2IIcnPoI64F6s436rLo9DfgM+mM6yxwlnlhM+GD7cMlhIw1NnQWGy4xuxznX/N8OC MNES1A6YfAM4QMYW/6Ih9HeVupTdejNBS5d2mV4uZyPTN/xK/xvEec4C3Iym+U50FuR6 nuuw== X-Gm-Message-State: ALQs6tBo8lZSPhFog1/uk+xkU8ogSoTUZduvp6s3DstSUztsnPskKgfS pNrJORZyFocwHEl3tzeDqN7SAH1oN34= X-Google-Smtp-Source: AB8JxZqp6jbS6GIjJ6qFNbXFDrJaBmxs0/u/npNwkgPJahU1L0DNUT98XGuEsL64XuK/MqCY1zNRgg== X-Received: by 10.28.18.208 with SMTP id 199mr6929310wms.153.1525099424104; Mon, 30 Apr 2018 07:43:44 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id 19sm8424758wmv.18.2018.04.30.07.43.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:43:43 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Pablo de Lara , dpdk stable Date: Mon, 30 Apr 2018 15:41:04 +0100 Message-Id: <20180430144223.18657-49-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'drivers/net: remove redundant icc flag' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:43:44 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 06f34e6b087937425003d915aea9f008433c8a46 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 13 Apr 2018 23:21:09 +0100 Subject: [PATCH] drivers/net: remove redundant icc flag [ upstream commit 91cf42f6c491ea707256d1778d89c4e852722b92 ] ICC warning #188 already disabled globally via commit [1], no need individual arguments in PMDs. [1] Fixes: 1b80b9c854c3 ("mk: disable icc warning 188") Signed-off-by: Ferruh Yigit Tested-by: Pablo de Lara --- drivers/net/bnx2x/Makefile | 4 ---- drivers/net/cxgbe/Makefile | 8 -------- drivers/net/e1000/Makefile | 2 +- drivers/net/i40e/Makefile | 2 +- drivers/net/qede/Makefile | 1 - 5 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile index e3a39a9e0..0c0f51aaa 100644 --- a/drivers/net/bnx2x/Makefile +++ b/drivers/net/bnx2x/Makefile @@ -17,10 +17,6 @@ EXPORT_MAP := rte_pmd_bnx2x_version.map LIBABIVER := 1 -ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) -CFLAGS += -diag-disable 188 #188: enumerated type mixed with another type -endif - # # all source are stored in SRCS-y # diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile index 5dee3c723..33267f6a6 100644 --- a/drivers/net/cxgbe/Makefile +++ b/drivers/net/cxgbe/Makefile @@ -45,12 +45,6 @@ EXPORT_MAP := rte_pmd_cxgbe_version.map LIBABIVER := 1 -ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) -# -# CFLAGS for icc -# -CFLAGS_BASE_DRIVER = -diag-disable 188 -else # # CFLAGS for gcc/clang # @@ -59,9 +53,7 @@ ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) CFLAGS += -Wno-deprecated endif endif -CFLAGS_BASE_DRIVER = -endif LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_bus_pci diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile index 01941ac69..87cfb265d 100644 --- a/drivers/net/e1000/Makefile +++ b/drivers/net/e1000/Makefile @@ -22,7 +22,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) # # CFLAGS for icc # -CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 -diag-disable 188 +CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259 else # diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile index c91545741..7e34b50a7 100644 --- a/drivers/net/i40e/Makefile +++ b/drivers/net/i40e/Makefile @@ -24,7 +24,7 @@ LIBABIVER := 2 # to disable warnings # ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) -CFLAGS_BASE_DRIVER = -diag-disable 593 -diag-disable 188 +CFLAGS_BASE_DRIVER = -diag-disable 593 else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) CFLAGS_BASE_DRIVER += -Wno-sign-compare CFLAGS_BASE_DRIVER += -Wno-unused-value diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile index db5ba966e..831ee15df 100644 --- a/drivers/net/qede/Makefile +++ b/drivers/net/qede/Makefile @@ -73,7 +73,6 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion endif else #ICC -CFLAGS_BASE_DRIVER += -diag-disable 188 #188: enumerated type mixed with another type CFLAGS_qede_ethdev.o += -diag-disable 279 #279: controlling expression is constant endif -- 2.14.2