From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 602291C0B for ; Mon, 30 Apr 2018 16:44:27 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id j4so13617873wme.1 for ; Mon, 30 Apr 2018 07:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=weiO7iOmxD91JOoxIONV6Md8MUFwo/fRgsQ2o9aPQYU=; b=HO7FwX+BDA0O9AcW0sos/73+eobdKNImtTHV1bs95QP1FJtWqOYrkimhqx69AXAPGG gj/xbCcntk/vByrF0sM2xIaEk7/SG4gmOW2+T2VUdLXS/ca397wh5mCmS7SIaXZdnrrt 9LLZLkNbQknUccKz2HG5lwNUUoDhBc1vcliSrMzRNqh1lb0yuHF4vBMlTARh85219jO3 XjjQk3fxOQutPL3rtCxUHDBZqGvq9UU1UpxLYXyDXXlRBXiFLQruTno3gcreQCHxrmZR 8HKvrFPGozMSCeYNwRGde1T+pRSSWYt+QdHlAJINXG+gO7r8BP9Wff62QeupfjgllFk1 bE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=weiO7iOmxD91JOoxIONV6Md8MUFwo/fRgsQ2o9aPQYU=; b=FKvUdLGdmnSwy5TseO8EwsSFu1JNJ9a6pyt9iffp/Ez4CqbqypZeRLMbOjT/QwRLGw ph5J6Qbr3cSUf7kWO9ZH1NzsiT3wuQEkS/0TvxREqXgWGpN1f3T5NFz4gUSXgQkmQ6GU 8DKp/ABSsvF6YjUot7LmruPgVbXFoSesqj5ksPY47FhcfQC4ozcrYiiqHbUypWcg6Gw8 WGghL/76pWcOOM/9/ItYfcIzVpVul2FR8g4Gyesm3hEhIvpzL19mYEWrAT/Qqv6WYNLT a31OdvnIyfjhWFxRVGHJTVfq1jUAGs+DxDRqQAfPCNwfAPApko0AlYqlnMkYrRrlwkQt evuQ== X-Gm-Message-State: ALQs6tC1OrGjT3w0Z3k1eCLCAQu35E8YA/lElP9kpXoJMv5gnWoaxNLU fYgVy+5Rshasy90j6r2K6lg= X-Google-Smtp-Source: AB8JxZrXkpic++HGv2vXa+F8dPmXDCC5sf8OBSzT81Rjg9el5kQF5kupqvUX/5ryRBZA0+PK9GfvbA== X-Received: by 10.28.95.131 with SMTP id t125mr7821324wmb.124.1525099466857; Mon, 30 Apr 2018 07:44:26 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id 16-v6sm13374993wrt.20.2018.04.30.07.44.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:44:26 -0700 (PDT) From: luca.boccassi@gmail.com To: Anoob Joseph Cc: Radu Nicolau , dpdk stable Date: Mon, 30 Apr 2018 15:41:31 +0100 Message-Id: <20180430144223.18657-76-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430144223.18657-1-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'examples/ipsec-secgw: fix usage print' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:44:27 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 37a9b53c80dc48767841d4227882da4ddf0501ce Mon Sep 17 00:00:00 2001 From: Anoob Joseph Date: Mon, 16 Apr 2018 17:53:15 +0530 Subject: [PATCH] examples/ipsec-secgw: fix usage print [ upstream commit ae43ebbe9366176ea2a84b5e7f2ba8962961ea07 ] The usage print was not updated when jumbo frames & crypto_dev mask support was added. Fixing that. Also, the optional arguments were not properly highlighted in the usage header. This is also fixed. General cleanup of the usage print was also done to make it look more cleaner and similar to what is existing in other applications like l3fwd. Fixes: bbabfe6e4ee4 ("examples/ipsec_secgw: support jumbo frames") Fixes: 2c68fe791538 ("examples/ipsec-secgw: add cryptodev mask option") Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Signed-off-by: Anoob Joseph Acked-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 36 ++++++++++++++++++++++-------------- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 6bbb920f9..c9d3f244f 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -924,20 +924,28 @@ init_lcore_rx_queues(void) static void print_usage(const char *prgname) { - printf("%s [EAL options] -- -p PORTMASK -P -u PORTMASK" - " --"OPTION_CONFIG" (port,queue,lcore)[,(port,queue,lcore]" - " --single-sa SAIDX -f CONFIG_FILE\n" - " -p PORTMASK: hexadecimal bitmask of ports to configure\n" - " -P : enable promiscuous mode\n" - " -u PORTMASK: hexadecimal bitmask of unprotected ports\n" - " -j FRAMESIZE: jumbo frame maximum size\n" - " --"OPTION_CONFIG": (port,queue,lcore): " - "rx queues configuration\n" - " --single-sa SAIDX: use single SA index for outbound, " - "bypassing the SP\n" - " --cryptodev_mask MASK: hexadecimal bitmask of the " - "crypto devices to configure\n" - " -f CONFIG_FILE: Configuration file path\n", + fprintf(stderr, "%s [EAL options] --" + " -p PORTMASK" + " [-P]" + " [-u PORTMASK]" + " [-j FRAMESIZE]" + " -f CONFIG_FILE" + " --config (port,queue,lcore)[,(port,queue,lcore)]" + " [--single-sa SAIDX]" + " [--cryptodev_mask MASK]" + "\n\n" + " -p PORTMASK: Hexadecimal bitmask of ports to configure\n" + " -P : Enable promiscuous mode\n" + " -u PORTMASK: Hexadecimal bitmask of unprotected ports\n" + " -j FRAMESIZE: Enable jumbo frame with 'FRAMESIZE' as maximum\n" + " packet size\n" + " -f CONFIG_FILE: Configuration file\n" + " --config (port,queue,lcore): Rx queue configuration\n" + " --single-sa SAIDX: Use single SA index for outbound traffic,\n" + " bypassing the SP\n" + " --cryptodev_mask MASK: Hexadecimal bitmask of the crypto\n" + " devices to configure\n" + "\n", prgname); } -- 2.14.2