From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 240411DBC for ; Mon, 30 Apr 2018 16:54:30 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id a8so13670600wmg.5 for ; Mon, 30 Apr 2018 07:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=x4ZsMHzjIz82WdXuCHKCOvS2sYoypKPye3GYVhpEtSg=; b=OZAYQinjtJLvP8Xk2G7qsUZoOos7mOX6eEeYikop6wHg1xru/uLh1slK4V4UCuER3L jbZXXvH74NBQcYd+1ElZt7Ny7CSVGeVcYtZsA7GF/oIo0tga63TEgfgZDdMQVeTiHrMM hBmyPwGjxd9h5hIyRpq1r7jm8Jp30ekiHCiCurprOLs7l7z3R9GMuC1Sz86NrHyFLJTS 5uNy3KqvHo0KLkPT2svtibVw/mUDcgSaa6WQ/VFN3AMhFPoD410S0j+bNrRJ0lFAkmcY 3G4LOMV4cQ8NEKcH6yekSs96rkApBEoZiYnruEA/pRXwI7rjx0QktzZoIoNVL4AGY5wV hkMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=x4ZsMHzjIz82WdXuCHKCOvS2sYoypKPye3GYVhpEtSg=; b=fUskPEOXS0ialWy8HcBrQPimqywdSbQ0gD7q+uROkTuX+RWqPulJPedKD+c24HN1FN fmHPPBSaNjpIIsDyUFfz16A0W/tMkE6+YgaDvNvNAuKBBLmF4RWkSRbfO0GVcidBqaGa 7DVZ6UC3WyodrSBQxr10jmasfpQwrU6YVADyossQSeqm8W5ydke+CTlqAL191Q21B0t8 x6e7taHLqmrG9pKm90AVpU6lIUt0dezXM4uGnHJZ9C0n7hNOnDSk8fE2o/lvS69PqEoJ 6Poz5Hc+5W/5qTPNGDY8EqV2EI8MKpK0xWDJE0PQsesSlSuQWS+3Dl82g2neafnkKi67 ctVw== X-Gm-Message-State: ALQs6tCowCNGpoU+qItpHb51CkUK/MHyEmuUwZEZL6bswGQg25O/xjzL 8OPfRkYGN4Zuuh+pPu95xY8= X-Google-Smtp-Source: AB8JxZqYDgtOe+JzvehEw+seEBkU1/PkNkCfllyJ/JLwUCZrYYOb0roMg+J+DPPCQ0qz1x73JS3xkQ== X-Received: by 10.28.134.69 with SMTP id i66mr8233776wmd.40.1525100069863; Mon, 30 Apr 2018 07:54:29 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id k9-v6sm9791005wre.1.2018.04.30.07.54.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:54:29 -0700 (PDT) From: luca.boccassi@gmail.com To: Adrien Mazarguil Cc: Nelio Laranjeiro , Ferruh Yigit , dpdk stable Date: Mon, 30 Apr 2018 15:53:35 +0100 Message-Id: <20180430145402.23057-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430145402.23057-1-luca.boccassi@gmail.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/mlx4: fix RSS resource leak in case of error' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:54:30 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From c737e4f5b68e9fce256cf9b17d2fc06f9a999846 Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Thu, 19 Apr 2018 12:07:25 +0200 Subject: [PATCH] net/mlx4: fix RSS resource leak in case of error [ upstream commit cb43322fbd00c7f7c13ad2095fb0331bf8a5f262 ] When memory cannot be allocated for a flow rule, its RSS context reference is not dropped. Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro Acked-by: Ferruh Yigit --- drivers/net/mlx4/mlx4_flow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 2d55bfe03..a3b4480b4 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -820,11 +820,14 @@ fill: }, }; - if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) + if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) { + if (temp.rss) + mlx4_rss_put(temp.rss); return rte_flow_error_set (error, -rte_errno, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "flow rule handle allocation failure"); + } /* Most fields will be updated by second pass. */ *flow = (struct rte_flow){ .ibv_attr = temp.ibv_attr, -- 2.14.2