From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 20F6A1C01 for ; Mon, 30 Apr 2018 16:54:36 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id j5so14731050wme.5 for ; Mon, 30 Apr 2018 07:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SpktVQmRmg7JiUzPsuS+G+kfB4M0JKE2/9Hf/pSNSBY=; b=J8Go8J3nZ9bgTVXBZapbKLd6gtLcWQRHatp/fHr9oA6KEe5VTHlbVswzYNYH0a0LB5 QcyxqYcPKVq1riz6EvG+7ZUkqZkxCFZRzxQvD9uYccQcOG4rCOmjBEDlYK+J/0QJIjgI IHMbA/ZScmvjoerMp06HZvndDcIFmuJ2gV9FLuIHvlNig0ysDf0wWIUuh6H1net+6ZSd VWN6DDcDxNijoOAwOvVw1yh9FIly6cKfizoLKW7QNHf0bva1ebNSv158RcZpTto0d1Yc bcd4mdcSbAmFcB6dhVP459d6boWgoU8EWsTeC4c15EVPEk1yQUS761F+nvCmn3yfkSLA rkzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SpktVQmRmg7JiUzPsuS+G+kfB4M0JKE2/9Hf/pSNSBY=; b=DbQQHpNqTIe0/NhxolpdeU29GsC4ev98h00L9f/MHoVS8GcAYHfARG170n+Sq7hJq9 LPppjeewk2VcWwNmkymFmcPbRNicnCALc+3mjTPjDaPVGKfRW5igGkAKP6XujMiqA+XR Zl1upiPlmxam4WpUDW7sayHMLdRj1TjWJEN//u7tBlunfpovqvQ59bIrxFQ8t2iDzOJw mRM0Ap0IqLvbegcfGFi00eZpM5NTPUCD6ulWCTklWqCep4ZrETBBeqt8jV1wLJlUONzJ sDsQoULoGt4cBwfDzysnXuFYVphn0WDi04YiucuqlaVIiPOlCCX+XLBoLalCf3DByRnS c2pQ== X-Gm-Message-State: ALQs6tCbmKUzoNptYnEoT3ILzSMaDSjo7RTI4sTJ1p1lkFG3P60gwZer WWCZGqWDi528koZ01pl23f0= X-Google-Smtp-Source: AB8JxZrzyuBt0hHvRgrrIf3m77EHooLQFhgIvYXRvnx2ldB2JbXGZ+83pAHKlc1don7Ecu2gIQK2WA== X-Received: by 10.28.63.86 with SMTP id m83mr8249273wma.88.1525100075753; Mon, 30 Apr 2018 07:54:35 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id c21-v6sm7278141wre.43.2018.04.30.07.54.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:54:34 -0700 (PDT) From: luca.boccassi@gmail.com To: Adrien Mazarguil Cc: Ferruh Yigit , dpdk stable Date: Mon, 30 Apr 2018 15:53:39 +0100 Message-Id: <20180430145402.23057-20-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430145402.23057-1-luca.boccassi@gmail.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix flow completion for RSS queues' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:54:36 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 66e7a5b218fe707831e132d888760d530bee550d Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Thu, 19 Apr 2018 12:07:33 +0200 Subject: [PATCH] app/testpmd: fix flow completion for RSS queues [ upstream commit 7a17b969e9257546d967900719f2168cdc9653de ] The lack of a working completion for RSS queues was overlooked during development; until now only "end" was displayed as a valid token. Fixes: 05d34c6e9d2c ("app/testpmd: add queue actions to flow command") Signed-off-by: Adrien Mazarguil Acked-by: Ferruh Yigit --- app/test-pmd/cmdline_flow.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a5cf84f79..9cac8e9bf 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -2663,17 +2663,15 @@ static int comp_vc_action_rss_queue(struct context *ctx, const struct token *token, unsigned int ent, char *buf, unsigned int size) { - static const char *const str[] = { "", "end", NULL }; - unsigned int i; - (void)ctx; (void)token; - for (i = 0; str[i] != NULL; ++i) - if (buf && i == ent) - return snprintf(buf, size, "%s", str[i]); - if (buf) - return -1; - return i; + if (!buf) + return nb_rxq + 1; + if (ent < nb_rxq) + return snprintf(buf, size, "%u", ent); + if (ent == nb_rxq) + return snprintf(buf, size, "end"); + return -1; } /** Internal context. */ -- 2.14.2