From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 3F8F91DBE for ; Mon, 30 Apr 2018 16:54:48 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id i14-v6so5158930wre.2 for ; Mon, 30 Apr 2018 07:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1YJmQr44Vr3isUML0R4mSYlNKgoyKqkct/Mdh/XoLDM=; b=GpMkinTiUvBsd0C2x1yKmN4bVJ5FJc0rfz1rT9yyYoHA3ZYAQF96uO10yB0yOzngHk tAQLXDkY8tFJEoN9CWmAK+8WA0wjkICSReCEBVWpzSw1Ng4gPEqZS182BcFyeDQaCeoh p7mZT4zf4WJNtO5IhywPl1UfBebno9cefVffZtWPljWA4ayK25Bj0V3hF1m0XybPp7yG 1g7E0cXGKB1Xs+KT5EmRc+VH4rdD8toA1WOO9HQC6BCZZrG1c0ejSTYITkG1IadCtiKE lrAzS5fFY7/quOckQEIwHS4mszs40lCkhq5ui1whF2ga+gRm+kQ8Nwq8Nn0R0hPu+ViO /7UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1YJmQr44Vr3isUML0R4mSYlNKgoyKqkct/Mdh/XoLDM=; b=LZdkkcddeJpYgT/4o05zwirJ3ZIJ2xXbTjgj2WFjvvOUXQbcmblRnqmEpWAJSJ6wKa VLbKlD22ZkXwDL0Yl08yDXboKG/hLw2bQ/v+WzDblNk0M+Iu4A0GEcJckpslAgLWXYyc /yPZT21zzEQPSuC7HGh6SIMiCdSW7V46a4gydoTibnbzHm1XxblsH1Zr+h0qMxCP80xh zl+ftRYAYRsYwa8zooBsE+7fF6iPXp+H7viwWlH2TGeOhe+gRQJrliD2KFstnAupJsQg d2AGqwSeJEx1OA44B/b3du3BaYO5rWKT63g1QmaiGFPCvOARftsQesCYuZUW2nnEJBME i4EQ== X-Gm-Message-State: ALQs6tCtYj9TnJCE05sFpVVX5WZir2srBdGeD7p8kHZ17lJrMF8UD+kc sAx8qyiEEs4WGHTP+6sx9kk= X-Google-Smtp-Source: AB8JxZqO7QvUSBkRm4xkVakGXZkm36Ya+4cXHwYLGQPmaHCVOcHHXObxTBHEnpmnWCk4V6lHSRPWQg== X-Received: by 2002:adf:8004:: with SMTP id 4-v6mr8326775wrk.274.1525100087962; Mon, 30 Apr 2018 07:54:47 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id d125sm5190437wmd.24.2018.04.30.07.54.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:54:47 -0700 (PDT) From: luca.boccassi@gmail.com To: Chas Williams Cc: Yong Wang , dpdk stable Date: Mon, 30 Apr 2018 15:53:47 +0100 Message-Id: <20180430145402.23057-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430145402.23057-1-luca.boccassi@gmail.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/vmxnet3: keep link state consistent' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:54:48 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 3228b47aefd53432074c2d55479834798ced2938 Mon Sep 17 00:00:00 2001 From: Chas Williams Date: Sat, 17 Mar 2018 21:45:52 -0400 Subject: [PATCH] net/vmxnet3: keep link state consistent [ upstream commit 3a14b29bff9cc427920c83391b37cededa48fd2f ] The vmxnet3 never attempts link speed negotiation. As a virtual device the link speed is vague at best. However, it is important for certain applications, like bonding, to see a consistent link_status. 802.3ad requires that only links of the same cost (link speed) be enslaved. Keeping the link status consistent in vmxnet3 avoids races with bonding enslavement. Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") Signed-off-by: Chas Williams Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index f1c24c7bc..9f44a4661 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1149,7 +1149,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev, link.link_status = ETH_LINK_UP; link.link_duplex = ETH_LINK_FULL_DUPLEX; link.link_speed = ETH_SPEED_NUM_10G; - link.link_autoneg = ETH_LINK_AUTONEG; + link.link_autoneg = ETH_LINK_FIXED; } vmxnet3_dev_atomic_write_link_status(dev, &link); -- 2.14.2