From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id EABD0FFA for ; Mon, 30 Apr 2018 16:54:55 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id i3so14653927wmf.3 for ; Mon, 30 Apr 2018 07:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FSifd6qsqnmhdYLgN1cpmsA8nr7lQ/lNLkgfHKRkrgE=; b=n9e5VupQh9PKJPdfkVf4Uo1t5LmZAuSbyn+Z0z0H6kXhOy9daqT9PoNpl5f/6ovhui owc2Gwq5d08QDaPnbeRFI8ikEt2g/gzIJb9CWa19IS+v3o1X/uEfPAukP9KvN7xdDcVm 4t9qwGvYSIssGj2ZzTVWXmolJxjxOafyxTryyM8cbIg7dWeKGNd4gr8JX9lpbW5YM6WU 0sM8V2KFTB0xUZLP/RyRdWhbSRFPuTyYBsGXqiUo9J98+W/cgQXhsssDhNlOZiAirgrQ IKdeBHWufMKV1zK+c/H1YwmLolI2sJwWk3LP3pvcEdMb7yfbD1Uxpl848NpRluNK4HYv tcNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FSifd6qsqnmhdYLgN1cpmsA8nr7lQ/lNLkgfHKRkrgE=; b=mlafvVq5muDZxovbwJdviR0esB+UnTLNTAOxO9HgATDDJ/RMz3aD4Nj6w7XEkR2LsA PGS42jw8pf6Lq6/EnGMBPqsFyixU/DRJtZ7VX63cpQypBBp2DCViXF73NS5iVS6QWGyc G7LGflTD3AolF5OynCBMBUawhna9E3Dfb0KMYNczLnslPW4Wrc6uTQ0JaWaFVw5HzAVu GtcB4oOcJs6bZE189iH5gdne3gHTWR08z5Lc48+WFXIT6ATp6rF8P/E35v9NLcyZqHYO 78y19ckV986Pn4oRmQi8/PG3JSjLIQxGCvmP5K7eqOyxw4nAsqU2jL8Ey+vr407Nbcqi /mpA== X-Gm-Message-State: ALQs6tBA23NArIU6LUBSmsgdzVG7yT2iWtewmoZFNm45A5uDAwi1Mixu BVT+g8Uiy42NhepvbYRcywXFVV2/aVk= X-Google-Smtp-Source: AB8JxZp+s5gmtpbCIh3bMFImJSg8yW9sBy0v27/m98QYlQ+wM2wCTTLnehc3L+wsEeDsIyfEDs98tQ== X-Received: by 10.28.217.67 with SMTP id q64mr7534237wmg.12.1525100095668; Mon, 30 Apr 2018 07:54:55 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id 4sm8334157wmg.40.2018.04.30.07.54.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:54:54 -0700 (PDT) From: luca.boccassi@gmail.com To: Matan Azrad Cc: dpdk stable Date: Mon, 30 Apr 2018 15:53:52 +0100 Message-Id: <20180430145402.23057-33-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430145402.23057-1-luca.boccassi@gmail.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/vdev_netvsc: remove specified devices IP check' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:54:56 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From f0e7a03e4e8bfedd482e86d2e8bb3d7f236ab959 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Tue, 10 Apr 2018 13:32:06 +0000 Subject: [PATCH] net/vdev_netvsc: remove specified devices IP check [ upstream commit 0b39cc820ae57319d9d9a3609843c94d0b9a4bbb ] If the netvsc driver starts in blacklist mode, it does not automatically probe IP associated netvsc devices. Therefore, the only way to probe them is to specify them by the EAL command line, using the "force" parameter to skip the IP check in the driver. >>From now on, the user does not need to add the "force" parameter if he specifies an IP associated netvsc device by the EAL command line, and the responsibility of the IP check is now in the user's hands. However, in the absence of any specification, the driver still skips IP associated netvsc devices. Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 10 +++++++--- drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/vdev_netvsc.rst b/doc/guides/nics/vdev_netvsc.rst index 55d130a3e..a2d49f4f0 100644 --- a/doc/guides/nics/vdev_netvsc.rst +++ b/doc/guides/nics/vdev_netvsc.rst @@ -89,12 +89,16 @@ The following device parameters are supported: - ``force`` [int] If nonzero, forces the use of specified interfaces even if not detected as - NetVSC or detected as routed NETVSC. + NetVSC. - ``ignore`` [int] If nonzero, ignores the driver runnig (actually used to disable the auto-detection in Hyper-V VM). -Not specifying either ``iface`` or ``mac`` makes this driver attach itself to -all unrouted NetVSC interfaces found on the system. +.. note:: + + Not specifying either ``iface`` or ``mac`` makes this driver attach itself to + all unrouted NetVSC interfaces found on the system. + Specifying the device makes this driver attach itself to the device + regardless the device routes. diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index db0080a18..d2c41a577 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -569,7 +569,7 @@ vdev_netvsc_netvsc_probe(const struct if_nameindex *iface, /* Routed NetVSC should not be probed. */ if (vdev_netvsc_has_route(iface, AF_INET) || vdev_netvsc_has_route(iface, AF_INET6)) { - if (!specified || !force) + if (!specified) return 0; DRV_LOG(WARNING, "probably using routed NetVSC interface \"%s\"" " (index %u)", iface->if_name, iface->if_index); -- 2.14.2