From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 71B2ADD2 for ; Mon, 30 Apr 2018 16:54:57 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id j5so14733175wme.5 for ; Mon, 30 Apr 2018 07:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iGINA+8ay72+qeAWdTem8q3YeR19LCxde0GugMJaCLU=; b=lSVGfeiuCiaPcdLtuUnqfdhm+xn5qvLSGQopek+BBjIOZVQmTWp68VNvYc8DvoZJmY Z7fgWCPOdiBW6TlMUtSO+VAZeKYqK7C0hR8RZnxf5uNOlIo5TwQePiysSaPPwe+eKEnS SlwNgakMbi+p+AlqwybcLg7kNOOHyBjkIvz/TWDvNAtTNza2tunUgP/5P+IFXQGCIEkh kT5SNqwjY1Taz9kOK4WFfRVdQqlvLqvIVjTYb+AVy9XUt0xHcvKv8bT/A9p31HMXlWvo WqKRExsFZjoJQczWzHxG4ouywJwGLgsHkIO9dqK6k1TNDbNqsgG49ZkGOiTuq4GpPBD/ Y4mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iGINA+8ay72+qeAWdTem8q3YeR19LCxde0GugMJaCLU=; b=IAzNA46XNmssXVWwJSHvnz4+L8IeuYZQLjVQ8R/5fhziaGvvtU9Dto8qFrWzX3io98 a3a9LBhYOUxn2b6w4Wx7FtUH22os/fDSS2GGU6dzCVeA45FkEmtVOXA99vToxqvjJ/3F dxBUTR7X0agA/9F3Jd8nsE/NJIP7QiSbPiaOR1oHFIyHrfMkyhpsts9+P2XmRoSrzu1O WsI77scoDirmzUaw+y/vtbsIa2L2UupDgGUBvI8SqD1kdNICt/EN97RR6InW/fM/+VJX Ep4SXc4J8ubd4oTu2I0osobLQ8m2WVB6idsZNWo61OURa9TbRSR/NlAYogPMrSI26G+2 a+fw== X-Gm-Message-State: ALQs6tCbMYEyqYADH3tTN2XPX4gYpvnzDBSiotP6IQunbKPzRy9rbxAg n2GtZaqLW4LMTqUpgZyr1YBcqTTHCzY= X-Google-Smtp-Source: AB8JxZqwB+/xE9ey1zBqOEjam+7VOAqt99ch55lp7nSo9ZOnD9rAV08Ga3jmkLT48J4/fARZq7/GvQ== X-Received: by 10.28.50.135 with SMTP id y129mr1201709wmy.22.1525100097136; Mon, 30 Apr 2018 07:54:57 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id 42-v6sm13925530wrx.24.2018.04.30.07.54.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:54:56 -0700 (PDT) From: luca.boccassi@gmail.com To: Matan Azrad Cc: dpdk stable Date: Mon, 30 Apr 2018 15:53:53 +0100 Message-Id: <20180430145402.23057-34-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430145402.23057-1-luca.boccassi@gmail.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/vdev_netvsc: add check for specifying by 1 way' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:54:57 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From a97393ad0f10745e633867555df356b570861fe8 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Tue, 10 Apr 2018 13:32:07 +0000 Subject: [PATCH] net/vdev_netvsc: add check for specifying by 1 way [ upstream commit 118d2f8096a528b46e1fa5fe2104cf7140278d94 ] There are now 2 ways to specify a netvsc device by the EAL command line - either by the interface name or by the MAC address. The user should not specify a netvsc device using more than 1 way, Thus, if a device is specified in more than 1 way, the driver stops to probe it. Validate it in the driver initialization. Signed-off-by: Matan Azrad --- drivers/net/vdev_netvsc/vdev_netvsc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index d2c41a577..018ffae5d 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -702,6 +702,11 @@ vdev_netvsc_vdev_probe(struct rte_vdev_device *dev) rte_kvargs_free(kvargs); return 0; } + if (specified > 1) { + DRV_LOG(ERR, "More than one way used to specify the netvsc" + " device."); + goto error; + } rte_eal_alarm_cancel(vdev_netvsc_alarm, NULL); /* Gather interfaces. */ ret = vdev_netvsc_foreach_iface(vdev_netvsc_netvsc_probe, name, kvargs, -- 2.14.2