From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 1FA451DBB for ; Mon, 30 Apr 2018 16:55:02 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id o2-v6so5413845wrj.13 for ; Mon, 30 Apr 2018 07:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kxt5q+t7i1nLik/WdVvDB6td9PpuwLDWjcHd2NGuNMo=; b=GaE17xH4LqMgdjwtfv3F34SALMPA6V474CyjFddSFj1b/fTB8oWw9XjEkvPmMx7zLf eHWHOrociSSta2K2f0LsP67Qp7iD1SVfUIjHkzdZD+gIssKBhPv0tbrxXa5U0dKisTDU l7gF8qyQIDU67YQ6Uz2Hk18McN2iJhgblC7m0eJ36rSa8izEpz3u8qAXItwxEYS3cv/g 9w97GIaRqJYtgbjFmbbm8ae//b+sPCLH/5BOUpIdTnMNOoLDEI0nLE6q3LVW0cCO5Iqg djWnlXHVYBr9q4cUhqUiChOE1hoE5NQ4W1BIFHe/P2neFVX/kh6i+tbPH7vrdVoOn4Zn Y0tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kxt5q+t7i1nLik/WdVvDB6td9PpuwLDWjcHd2NGuNMo=; b=OzAA2+cX7M1Es0RWc/8qjIozilxbByBg7DF8MP+p6ADxKhXBZEabVCfl6E1YHs3r1j /DD//7b0hzRsU4yNJYzcXpLXsW5hN/vjoFhyGAmwITNm0MGmpz+IrzyBAniSjj6g+dr2 PsRdR92WhT71bqMKI+oIbY8jvU36My/WdVjFKM9jGNSVvYoR6DpwIWU0IENAAHUZxvyI bpm9XC6I1PYtigDRxhBx5y9dgemR0Nwv3SD59EeaJfWITUtkdXO+9pgyhFdg+IxcYY// WwoltmrFrf8ql8OtX0TaCOfShTxDj8fDw7oeAaILGEiuJ3z6gcxRwX11UyR4PCEsnGKg FzsQ== X-Gm-Message-State: ALQs6tB6fSUnsEcuuctLZlmSCLBBFhUmB+HwEq43dgBd2LoqXettXsIh cBVayn9N14Jq+CvAxXPUGQc= X-Google-Smtp-Source: AB8JxZrOzVHZhuo2HS/oVYtP0iAlIgGRtNdvNMRJ5x5aog8PI00g+Iu6L8q7299m3/TMuP8HUG7WFQ== X-Received: by 2002:adf:abc6:: with SMTP id s64-v6mr9055029wrc.66.1525100101782; Mon, 30 Apr 2018 07:55:01 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id p17sm6742467wmc.17.2018.04.30.07.55.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:55:00 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Pablo de Lara , dpdk stable Date: Mon, 30 Apr 2018 15:53:56 +0100 Message-Id: <20180430145402.23057-37-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430145402.23057-1-luca.boccassi@gmail.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/tap: fix icc build' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:55:02 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 9c23d323db4d8e0db53708995a6a22447a3a6857 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 12 Mar 2018 19:31:33 +0000 Subject: [PATCH] net/tap: fix icc build [ upstream commit 6db80eb7c97e7db9c006641cc7ecae46c625d64e ] build error: .../dpdk/drivers/net/tap/rte_eth_tap.c(598): error #279: controlling expression is constant RTE_ASSERT(!"unsupported request type: must not happen"); Although RTE_ASSERT helps debugging this issue when assert enabled, constant expression in assert means this path can be taken during runtime and there is no protection against it when assert is disabled. Adding error log and error return back, replacing RTE_ASSERT. Fixes: 7748a4b44196 ("net/tap: add debug messages") Signed-off-by: Ferruh Yigit Acked-by: Pablo de Lara --- drivers/net/tap/rte_eth_tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index f09db0ea9..4bf2d9618 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -593,7 +593,9 @@ apply: case SIOCSIFMTU: break; default: - RTE_ASSERT(!"unsupported request type: must not happen"); + RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n", + pmd->name); + return -EINVAL; } if (ioctl(pmd->ioctl_sock, request, ifr) < 0) goto error; -- 2.14.2