From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 822281DA4 for ; Mon, 30 Apr 2018 16:55:03 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id q3-v6so8324025wrj.6 for ; Mon, 30 Apr 2018 07:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1YqgnHxnSVm0bAvmqxNjHM0Qrt5+01sr/QJiEdyn2K8=; b=YTJPP+ClUMomI3AnMo06lxR+NxGleFB+IWFZ8TQFrkbs+I8ICl3q5ru/ulXbyaMBfh UR80Koq5waqBaiiHlr4o1qWKGlzw/psw+0jyPK/NRdNeF/jM2/2v7i+ptQNvCkljYcEu QVJuN0fh/RT06RQ/Z0VkaqBLi3y31PXJBIR7xC2O0X1zzuAsmV5RaK2sBxBmZRqWPXgp RmZVFtozN7CeTn75xgjPHNu6j2nlpNgDWAPcNAuLzpCsylZJnn+cTsKk1AaTGqzWP2zU 3QoJkFb6jpfMdSaGQKtyf3AJRirBrD0JXtOREop4FLvHHTvs4ml1zwWuqrXtvPwU/bp0 FkFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1YqgnHxnSVm0bAvmqxNjHM0Qrt5+01sr/QJiEdyn2K8=; b=mBUXccc7BXYY7crlXyXWQ8TRmqC1LNdiVELBxBr8p9SzUJ4XsKNxz0Qt40FS1mdL+m 9K9nXUT2O4hcuY9+1+OMCdylO7HNBVWFmI9XOxVPpgFCMQge35qEDrkeea6wn8Gptn+p UhHP3uXuzL1EXgcsovviPK08wTODrbpcmylncRb++v2PGESDp03F4fsSlBgMp/ZdInUP WvoCDYbqLJfbYEQ9kJgTDfnh5J4ZxUClCfHfVpTVdZ7AhHbqzVA9VAuEOasSQO66OIHl xeb7omjSgfWqw8UnwQnCY2wUARIBQFna/TdXAZz/A3Oyb4xi6SFyNZg/wb8OcsMd+a1L ad7Q== X-Gm-Message-State: ALQs6tCPPhSW31KFs5wDilekzcrfZhCjFP7z9Ah7v58aGtM9wVHjQ887 MaheKEvtjIOFeWZChGJCdKiU2o/xh0Y= X-Google-Smtp-Source: AB8JxZp8b6BQ9cbKYPbKue8EXXEI4DqhFMyyTTD9oF4O5p/WQQqQSqEdr3bfyLNEm5ueZxB0/hQ+vw== X-Received: by 2002:adf:8756:: with SMTP id 22-v6mr8392736wrz.117.1525100103227; Mon, 30 Apr 2018 07:55:03 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id v18-v6sm7334522wrf.76.2018.04.30.07.55.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:55:02 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Thomas Monjalon , dpdk stable Date: Mon, 30 Apr 2018 15:53:57 +0100 Message-Id: <20180430145402.23057-38-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430145402.23057-1-luca.boccassi@gmail.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'drivers/net: fix link autoneg value for virtual PMDs' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:55:03 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From f713b58e2fd8224e3291422f62f9514549e4fd3c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 20 Apr 2018 01:01:24 +0100 Subject: [PATCH] drivers/net: fix link autoneg value for virtual PMDs [ upstream commit 18869f97f163a58d29d45a2e85c6ed444b1c72e1 ] These drivers never attempt link speed negotiation. Change link_autoneg value to ETH_LINK_FIXED to be more accurate and consistent between PMDs. Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon --- drivers/net/af_packet/rte_eth_af_packet.c | 2 +- drivers/net/kni/rte_eth_kni.c | 2 +- drivers/net/null/rte_eth_null.c | 2 +- drivers/net/pcap/rte_eth_pcap.c | 2 +- drivers/net/ring/rte_eth_ring.c | 2 +- drivers/net/softnic/rte_eth_softnic.c | 2 +- drivers/net/tap/rte_eth_tap.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 57eccfd04..7694b21ca 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -94,7 +94,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG + .link_autoneg = ETH_LINK_FIXED, }; static uint16_t diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index dc4e65f5d..57f3c50e3 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -61,7 +61,7 @@ static const struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG, + .link_autoneg = ETH_LINK_FIXED, }; static int is_kni_initialized; diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index d003b2839..181785b48 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -91,7 +91,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG, + .link_autoneg = ETH_LINK_FIXED, }; static uint16_t diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index c1571e1fe..814beedc8 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -96,7 +96,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG, + .link_autoneg = ETH_LINK_FIXED, }; static int diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index df13c44be..311ec3d5a 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -60,7 +60,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG + .link_autoneg = ETH_LINK_FIXED, }; static uint16_t diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c index b0c134152..d8ecfc2f0 100644 --- a/drivers/net/softnic/rte_eth_softnic.c +++ b/drivers/net/softnic/rte_eth_softnic.c @@ -522,7 +522,7 @@ pmd_ethdev_register(struct rte_vdev_device *vdev, soft_dev->data->dev_private = dev_private; soft_dev->data->dev_link.link_speed = hard_speed; soft_dev->data->dev_link.link_duplex = ETH_LINK_FULL_DUPLEX; - soft_dev->data->dev_link.link_autoneg = ETH_LINK_AUTONEG; + soft_dev->data->dev_link.link_autoneg = ETH_LINK_FIXED; soft_dev->data->dev_link.link_status = ETH_LINK_DOWN; soft_dev->data->mac_addrs = ð_addr; soft_dev->data->promiscuous = 1; diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 4bf2d9618..a55bf8463 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -65,7 +65,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG + .link_autoneg = ETH_LINK_FIXED, }; static void -- 2.14.2