From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 99630F64 for ; Mon, 30 Apr 2018 16:54:17 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id t11so13701868wmt.0 for ; Mon, 30 Apr 2018 07:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=flgAWAJ2A0oUdBc5zHZEd9T/OwOMd0UjsTPOfBWAIo0=; b=pp2HMgXVMdOLI3zUfxcL4CbR7Z+8eClrI5vPTNj243BIaVJvn1SHXP2vQScIy2naND NYaG8vmGEnSpuioRqUi2S3HuN/2ZqPZbTLvTheaqSJ3W5KAWCYbNHqoNj8wvvVOzPkwe oAhvGy39X0NcaO625bdDir/KvPlVc3na1QwjaLT/XqNMCpKRR2FNXNxHk7vFhs9R+Vi2 /QOfs9xslxTr1ECcNNXJfIa0F7/+hqcqJTqzwyxfXQIs5VcXJbOnQ4nyxWsaELv9hAsf w9GccunYoJm32KM7zDlcFPGapaJPqIeFtv4/pQBGOwt3LRW+nnJwPdP4XjZ6uzvaxLia U70w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=flgAWAJ2A0oUdBc5zHZEd9T/OwOMd0UjsTPOfBWAIo0=; b=eMpcbkkMNRA6bzanSfgAgyrqcOC+tlbBsgV+FUfOeFkoZrks6f2HtUfFEi/oRpE8tO TKGwDhJo/wHXx2kJADx2PYtGMKPZv3RnTIdpwRwIP5labeEE2nr6OlaYssr6aD2Zg3kA Q/EaJK0x5UjaRN08dgpHB/7p2DBYen3dSAPjhgKiidIF7b4B3caCDVULDMNmnbOMDCdr xeRKXsLpgQkgc72oPfM8eSjuaJF3Pi20SyHW5Di/v2AiI2flsJ5eZgY3/T3G3rXsqzu/ jWGaUL6PkQdyAXYL487zljPvULWytdJ5lfIjWg602vnhfqoyf/4NEYXjW4rKR101kCY5 80QQ== X-Gm-Message-State: ALQs6tCK8yfcIuHm8nw5M2CQGZiXG8HiVAp6Vnl85/vt1ocAW4GnC28m C7lOS4GCDIzOx5Hccphrs1k= X-Google-Smtp-Source: AB8JxZo4SjBwO+MhK1UpeEa4X/wv90GJMIGGi3PPOptr2UWf3IUk6Ju1aEn7f33KmNPRm2KsINyZVQ== X-Received: by 10.28.9.194 with SMTP id 185mr5729820wmj.53.1525100057262; Mon, 30 Apr 2018 07:54:17 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id r3sm8377918wmg.5.2018.04.30.07.54.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 07:54:16 -0700 (PDT) From: luca.boccassi@gmail.com To: Ajit Khaparde Cc: dpdk stable Date: Mon, 30 Apr 2018 15:53:27 +0100 Message-Id: <20180430145402.23057-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180430145402.23057-1-luca.boccassi@gmail.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bnxt: fix L2 filter cleanup' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 14:54:17 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/02/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From b92061898cc3af278059c3ed17869d1cae30e0b1 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Mon, 16 Apr 2018 18:11:18 -0700 Subject: [PATCH] net/bnxt: fix L2 filter cleanup [ upstream commit 0b5ca74dda4085a80c4b8cdc1933377a9b4444d5 ] We are wrongly freeing up a filter in the driver while it is still configured in the HW. This can cause incorrect L2 filter id to be used for filters created subsequently. This filter will be cleared on cleanup anyway. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c index e318d4a02..b7718cdca 100644 --- a/drivers/net/bnxt/bnxt_filter.c +++ b/drivers/net/bnxt/bnxt_filter.c @@ -957,11 +957,6 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev, goto ret; } - if (filter1) { - bnxt_free_filter(bp, filter1); - filter1->fw_l2_filter_id = -1; - } - act = nxt_non_void_action(++act); if (act->type != RTE_FLOW_ACTION_TYPE_END) { rte_flow_error_set(error, EINVAL, -- 2.14.2