From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 11D5B2BD5 for ; Tue, 1 May 2018 12:46:50 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id j4so17226206wme.1 for ; Tue, 01 May 2018 03:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F8kqgZvXt6zDMkX09LvuYpQ3ldbMjiljCsLRSNxxva4=; b=UTP4S1TuU8fIco/iZA3U5N5cdRg11dFT8X3F88lDBEbu92Fx52LLiN2d7lNSot55xw mPioZ/IKeoYDJFS9YcAPFVKODsqfnF+ZOXegHAYVsMTUivmyRHF0DyYGEJbYqfqj5Evx 1WqOV0KJVIByflM0LiqA7O3E1RdokIVudAOLV2NTO4LSDgILf/AnMYP6XYa2hzOp8Y8w DeUHM2my4flCL9umfqwbig/jdTY33TX43+7Oeu8VbAi4A0FiSC1aMYq41XmtLV7sKzhF NFGrAYnQ/be7HtrvKmqiP2qgPDhDfQ0fGM3wpfcf7JoUTla4Tx/zW7oVSHIBaNNWrGTG EOSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F8kqgZvXt6zDMkX09LvuYpQ3ldbMjiljCsLRSNxxva4=; b=JLry6W4HPH0qX+XJfGy+mE3Lhell85p2A83+kXgNt+NU4AQRl4smbdCi0lthLjPQaA bRAsjstqPXS/jt4k7/ISH+Pfc2P2icXqK0xMn60ELxmgEeWaC2WeubnwyJzGh1HeIZxf I9bnbaSL5zWGPj4Cbo/ztugI3c18wv7HkPVVbRgdB2vKXo1hKcAlaHb27LMbrYceX71Z VZVMb+/bm8m3xP5ToljlpVXHUD87lFiYLAqu8hnIhUeo0ZiYKqoQORac1k57RQi5jKHv d5NRnkLe77KiuRuT7IAm//TjcUusRksDWYwPR9wam2owH9k8VaI7EfmpjZHv2ANy79Xj lflA== X-Gm-Message-State: ALQs6tAvvfC4/YlNkBAshp6Gyf8e6Ie/6CZrutL52PVLLmthC1F47vTB UhBdQ2dv5tEF1LhJL7OEiy0= X-Google-Smtp-Source: AB8JxZqhCAUV6W6fNDDdBiQBOL/a5PNb5xQ9M21Pc02jGhNHLhRSF7Bx7JmHU5bbSM3ymq/1IkwaWg== X-Received: by 10.28.156.195 with SMTP id f186mr8700734wme.87.1525171609698; Tue, 01 May 2018 03:46:49 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id w5sm6715726wmd.26.2018.05.01.03.46.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:46:48 -0700 (PDT) From: luca.boccassi@gmail.com To: Alejandro Lucero Cc: dpdk stable Date: Tue, 1 May 2018 11:44:34 +0100 Message-Id: <20180501104509.17238-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/nfp: fix barrier location' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:46:50 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From f0769b9d31a53713a5a1081a5a405a1618f8a567 Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Thu, 22 Feb 2018 11:30:39 +0000 Subject: [PATCH] net/nfp: fix barrier location [ upstream commit f598e1a2d0e29293b924119c1b3cdd4e16756e95 ] The barrier needs to be after reading the DD bit. It has not been a problem because the potential reads which can not happen before reading the DD bit seem to be far enough, so the compiler is not rescheduling them. However, a refactoring could make this problem to arise. Fixes: b812daadad0d ("nfp: add Rx and Tx") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 06c225fff..f70c94f08 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -1731,16 +1731,16 @@ nfp_net_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) break; } + rxds = &rxq->rxds[idx]; + if ((rxds->rxd.meta_len_dd & PCIE_DESC_RX_DD) == 0) + break; + /* * Memory barrier to ensure that we won't do other * reads before the DD bit. */ rte_rmb(); - rxds = &rxq->rxds[idx]; - if ((rxds->rxd.meta_len_dd & PCIE_DESC_RX_DD) == 0) - break; - /* * We got a packet. Let's alloc a new mbuff for refilling the * free descriptor ring as soon as possible -- 2.14.2