From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id BF5F22BE2 for ; Tue, 1 May 2018 12:46:51 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id c14-v6so10478310wrd.4 for ; Tue, 01 May 2018 03:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HI1jV6/APvQlkY2K4NRGulR0JsPS+nlUrOtaVaS+dEE=; b=olf8DwTI3Nh7Ynhg7M1eKuEzR3mD5nD420QTwO3m6ka70VRaks2uYXZHDbydR6YmZs ylGERIkRXzqiE3eObRm8V70Az23lY+CJCXhgdn9oYbjkxWzTI2eI9dHAmLXrS5DNMUKs Ix/z2TyI6KY9g0ZX7w+mm4rSzL6e++1BYRetWDSp5yK98tWOMBSvMGbaAvmLmJooKJcN 0+kuU8FVoaq06m2nlD1YiDWhvsEcR3gUIOeODun75kRJrKnalpnve31emDM4Xsp6gZeo 7gcQpzfnkLY368KNq9tJwyZrjifKbMWaDzuzPY6mzvpIO6oqfnLPBz1NPZImw1GHaj5K o6Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HI1jV6/APvQlkY2K4NRGulR0JsPS+nlUrOtaVaS+dEE=; b=uVLMDc3yS8+a3VAQsec88Lxf98RQ0mkcT8QkAd2UdHOXGF7uzDpSjcbFQ93gjmoI9R 7PXP/KGpYLudo9RBrqjh/E5TivhNNiz3GkIRthbdJbcsPAFW52J3UZcOmQVkKKRcGFRR KsY/I6ezBXYvVZhEufawpxpASIvc+IH3SRlbCzF9o9XGneSx4ZlHTMFwbHoO5U9Ky8// SQuKxySTYj0DIQH0DCNOO8ORvSuniUjQ3OsnWX+30P98emZm5kwS2Zth8kxEMI6d/eds 9vn92rz9FzJrH0y7Y4BSmDwX2ziUUPisuGlpd7V4JwmJg4/mMmQHbv37X4ue9zzNJ6+m AKSw== X-Gm-Message-State: ALQs6tBbAmmpCRHTy61Queehk9m4r+24P4nEum3xC/5tSvWedFeRPUT6 Lnu7SP2PDhcaWvhg66Iy9lo= X-Google-Smtp-Source: AB8JxZqFJJ5PRVFndLZey0mDowF2tUzt9iTfxWwzpu9mtAtB/P+T1vMh4JjMb7i5wrZ5EONSImPALA== X-Received: by 2002:adf:a48d:: with SMTP id g13-v6mr11196191wrb.7.1525171611244; Tue, 01 May 2018 03:46:51 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id f6-v6sm2833545wrj.66.2018.05.01.03.46.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:46:50 -0700 (PDT) From: luca.boccassi@gmail.com To: Pascal Mazon Cc: Harish Patil , dpdk stable Date: Tue, 1 May 2018 11:44:35 +0100 Message-Id: <20180501104509.17238-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/qede: fix alloc from socket 0' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:46:51 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From d05b692ce8f2e20df16ba6b9e0771c4cbed14c5a Mon Sep 17 00:00:00 2001 From: Pascal Mazon Date: Mon, 26 Feb 2018 09:01:10 +0100 Subject: [PATCH] net/qede: fix alloc from socket 0 [ upstream commit 368b11185c8c35f95c6b4db1b24fa7757e5678f9 ] In case osal_dma_alloc_coherent() or osal_dma_alloc_coherent_aligned() are called from a management thread, core_id turn out to be LCORE_ID_ANY, and the resulting socket for alloc will be socket 0. This is not desirable when using a NIC from socket 1 which might very likely be configured to use memory from that socket only. In that case, allocation will fail. To address this, use master lcore instead when called from mgmt thread. The associated socket should have memory available. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Pascal Mazon Acked-by: Harish Patil Acked-by: Harish Patil --- drivers/net/qede/base/bcm_osal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/base/bcm_osal.c b/drivers/net/qede/base/bcm_osal.c index 3f895cd46..b9dc1d6d4 100644 --- a/drivers/net/qede/base/bcm_osal.c +++ b/drivers/net/qede/base/bcm_osal.c @@ -122,7 +122,7 @@ void *osal_dma_alloc_coherent(struct ecore_dev *p_dev, snprintf(mz_name, sizeof(mz_name) - 1, "%lx", (unsigned long)rte_get_timer_cycles()); if (core_id == (unsigned int)LCORE_ID_ANY) - core_id = 0; + core_id = rte_get_master_lcore(); socket_id = rte_lcore_to_socket_id(core_id); mz = rte_memzone_reserve_aligned(mz_name, size, socket_id, 0, RTE_CACHE_LINE_SIZE); @@ -152,7 +152,7 @@ void *osal_dma_alloc_coherent_aligned(struct ecore_dev *p_dev, snprintf(mz_name, sizeof(mz_name) - 1, "%lx", (unsigned long)rte_get_timer_cycles()); if (core_id == (unsigned int)LCORE_ID_ANY) - core_id = 0; + core_id = rte_get_master_lcore(); socket_id = rte_lcore_to_socket_id(core_id); mz = rte_memzone_reserve_aligned(mz_name, size, socket_id, 0, align); if (!mz) { -- 2.14.2