From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 366C828F3 for ; Tue, 1 May 2018 12:46:53 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id f8so7932798wmc.4 for ; Tue, 01 May 2018 03:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ha530V3Mp/jRpR4k2wukdTooQp1Jr/1xRv7uC4jXJn4=; b=YZvgap7SORuX8jO9RQjcnWljAjGaXeJ4Ri3Y1mesrL29oOdwh12hKqMqbubWKE/6Hw L7l0ruxEIbtjhLFhzPL5pKsWwYusJ/7xmFMLanluH2Ymu6SkJVeEHwtqJHV3aIZmeZ7x 4VaiF3zapqSu+ewmVUmoDcgdqtzdUnYC1EiShZlEXszTuCDCT2BRbCJDU3N4ldQPht+0 QD+0i/xOclJvb6H5kzjSyRNGhDa27zk+DwIKG/jvGLM958Jbu55G0zmZ25wqVi5gYt4g uxibvCltintIOyBrr1NPyIapnK6H1VP8jh5wOEaZW8fbjtcluIQG156AM2kXqSWtwVkZ rIxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ha530V3Mp/jRpR4k2wukdTooQp1Jr/1xRv7uC4jXJn4=; b=uD6Sujdcu7KEVMIxM/cAj02zldQTUnavlN/zLFLVjxoNmM3DMlQZfPYdFi/Ii33rDe BEIeGnbnFM2cOt2MUnaegVSuWdqQGGiXYKMDzgLEvvcFNKmH/qZSMbjj5HxMbP9l5OLG 0nWxq6PjE2kb+xKphCU4Fyyqp/nFXWkuVmlC7dCoyTRT+iTJcKr4x5gfgXSdQvw3I+kS T6F1urx1VOul41ZexwV5a29uisy7ohu00dCKDvZOuynzjGL9fHy4iBRIcu0gq2SDlnJB MpQqqkeAwPxz7C7IFMPuEm/rb6dDnuTNhb1iImMIKr3/Xdfqyebr0lQGDzTfo68bMy0D nDag== X-Gm-Message-State: ALQs6tBeaFYSEtQuhKY3uhT4nJw8NWJKQQ8V8o7TAj6jqNJ7BqfUapXi 5bLUArBTHIpdRyx/QKMeKqBP7Kze9ss= X-Google-Smtp-Source: AB8JxZoMwTMlAwKtLBcwAHMcnIGQrkb6mSf9gxwGWGkQd7V/OY8VsRoc8RwF9qd6dChwlzuHnXLaEw== X-Received: by 10.28.84.81 with SMTP id p17mr9550326wmi.26.1525171612909; Tue, 01 May 2018 03:46:52 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id y42-v6sm12472204wry.21.2018.05.01.03.46.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:46:52 -0700 (PDT) From: luca.boccassi@gmail.com To: Mohammad Abdul Awal Cc: Konstantin Ananyev , dpdk stable Date: Tue, 1 May 2018 11:44:36 +0100 Message-Id: <20180501104509.17238-13-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'ethdev: fix string length in name comparison' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:46:53 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 8c943c2de3a2ed1e6848ed6e194bb20efd149a0c Mon Sep 17 00:00:00 2001 From: Mohammad Abdul Awal Date: Tue, 27 Feb 2018 08:58:27 +0000 Subject: [PATCH] ethdev: fix string length in name comparison [ upstream commit b4572daa2c1056ba5a346841135747e8a2ea356e ] The current code compares two strings upto the length of 1st string (searched name). If the 1st string is prefix of 2nd string (existing name), the string comparison returns the port_id of earliest prefix matches. This patch fixes the bug by using strcmp instead of strncmp. Fixes: 9c5b8d8b9fe ("ethdev: clean port id retrieval when attaching") Signed-off-by: Mohammad Abdul Awal Acked-by: Konstantin Ananyev --- lib/librte_ether/rte_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 4679dc698..fed09c90e 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -438,8 +438,7 @@ rte_eth_dev_get_port_by_name(const char *name, uint8_t *port_id) for (i = 0; i < RTE_MAX_ETHPORTS; i++) { - if (!strncmp(name, - rte_eth_dev_data[i].name, strlen(name))) { + if (!strcmp(name, rte_eth_dev_data[i].name)) { *port_id = i; -- 2.14.2