From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id EE01628F3 for ; Tue, 1 May 2018 12:47:02 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id t11so17262141wmt.0 for ; Tue, 01 May 2018 03:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lTgp6sl1oOKD0DI8XWmrba5xvZrCYbhLTu7pJu0KmrY=; b=FisFiZ0Yp64D9ftzZ/48aD6lek5VJyHdjlRRkbTCEsgE/Gf7LNSOk8F2T2ItUVSyfd JhFWNwQg7DQbBJoc6z+X0tf8ZNH6VW5f/96qYQXX3fjUQ6TD1uWrwYOGxLAmgkjdfoBN Dqv7MgoNakm9oDNnGKrMVLV5bxnINqbWzMmCP29LwBEhiiYvDk9gGWprdB1fkz4H59VG kCmr5xFvj4em/kZelsUBc7S1LTtbe3jRzJJhm/BF/1NoS+7w1bDWqs/vhNcQD7wsDGsx k/5pPKYigYUUfRZ6HeXwUG2iy4TuavEF20EfXnZvtN4NTtfCYi/CBLE065fAkX6wtsu9 irjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lTgp6sl1oOKD0DI8XWmrba5xvZrCYbhLTu7pJu0KmrY=; b=IaYFNAKY5tRuBhrMOHUNHz9jt1ZxlQdRK6/jyh7IQKRBJI4hvXhBlaVtg6NRnQlema EQlRPd35vLFlTmTR4E0925jxojtyM470UAiL1kLNVJF24xePPlRakJ6jOteuc4V+bs8L rJ4pgLcOwkQ2TQz4iIZUW31wVqLTryUVCm8ru+KtmfAKH8Ll8vGjdQoLd5Y+EitDiTSh uTKXhn8GGruQlNEBkmioO8qHr/Ot3YwnGvtgxiZTcQMCwqY2t5ObGHpud1Wke4ngQp/H 0y19ab5hYxnAbxdapNCdAbkH1AVN453+qCNgqyl+f0Kt9NzJ+laNNOhaX0GTHg4BWXVK G1DA== X-Gm-Message-State: ALQs6tABArLStfJCWCSXHlKG+p7srb2Q1S/ryESiN1dmUd4aypl3C24I KFm0php2bbWkbfpckUjAd/7R7fcamoA= X-Google-Smtp-Source: AB8JxZroJ3BU41hlXImAbS6dOJIPkDhcP6L2HKlSsOhclfVRrC6/7KX9m5SMWJvkY41jQX9LkP2BQw== X-Received: by 10.28.211.1 with SMTP id k1mr1316372wmg.43.1525171622642; Tue, 01 May 2018 03:47:02 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id a69sm8903685wma.7.2018.05.01.03.47.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:47:01 -0700 (PDT) From: luca.boccassi@gmail.com To: Qi Zhang Cc: Konstantin Ananyev , dpdk stable Date: Tue, 1 May 2018 11:44:41 +0100 Message-Id: <20180501104509.17238-18-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'ethdev: fix queue start' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:47:03 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 84a9ab0424d20ab500a15492da8bdd7ced027ba1 Mon Sep 17 00:00:00 2001 From: Qi Zhang Date: Thu, 22 Mar 2018 20:59:01 +0800 Subject: [PATCH] ethdev: fix queue start [ upstream commit 239c9b435ad4abcac89b5d2480a0c21ce8b8288f ] Device must be started before start any queue. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Signed-off-by: Qi Zhang Acked-by: Konstantin Ananyev --- lib/librte_ether/rte_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index fed09c90e..a698fc00a 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -627,6 +627,12 @@ rte_eth_dev_rx_queue_stop(uint8_t port_id, uint16_t rx_queue_id) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); dev = &rte_eth_devices[port_id]; + if (!dev->data->dev_started) { + RTE_PMD_DEBUG_TRACE( + "port %d must be started before start any queue\n", port_id); + return -EINVAL; + } + if (rx_queue_id >= dev->data->nb_rx_queues) { RTE_PMD_DEBUG_TRACE("Invalid RX queue_id=%d\n", rx_queue_id); return -EINVAL; @@ -679,6 +685,12 @@ rte_eth_dev_tx_queue_stop(uint8_t port_id, uint16_t tx_queue_id) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); dev = &rte_eth_devices[port_id]; + if (!dev->data->dev_started) { + RTE_PMD_DEBUG_TRACE( + "port %d must be started before start any queue\n", port_id); + return -EINVAL; + } + if (tx_queue_id >= dev->data->nb_tx_queues) { RTE_PMD_DEBUG_TRACE("Invalid TX queue_id=%d\n", tx_queue_id); return -EINVAL; -- 2.14.2