From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 4AC042BA7 for ; Tue, 1 May 2018 12:47:10 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id p18-v6so10487592wrm.1 for ; Tue, 01 May 2018 03:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ayBbDi5V2Xg/YroArr2xblZ+wqsj3+iUnk2gvPSFvt8=; b=I7y6jUzAdEuHMBbBPfNDPjnhN0dbTbmNCPR+1DYWYIWgcGMDp82QziEh6b7pE6L/jP rAnF438vtXLDScqfSjOhuyfE/2LKgbqRHiyvruJe58Ctqp1amxBBtZKm9ASelF9LiZHD gtqlK2m+qB4Khl7xYkPyb3Cwck8vrtMdktelRMksXCTMQqx0MPh1woDTTVTy6AkK1CyY kRJIF1ccQXHKzAo7x8RCRK2W5SaC7dYiaPAg3d+1iOlhmhnHKGQeanZPSYne9/iVIxC9 V0qpWA1SAgTOffK4pEMNWc4vUn28O/H1uWp6CmMfMkvIdRqM9x524CSy77jV0wIh+qr8 7OOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ayBbDi5V2Xg/YroArr2xblZ+wqsj3+iUnk2gvPSFvt8=; b=VFTgvGNLns0oiuxKgD6ju3r3Mmxlaf/7GH4q7hMYzmppu+UWr0gRu/a8BrxS1P2MPM K3qrVooRu/Uy6IaoCWph9N5RZHbv2ua86fByRu7wffIvn/JK6EyRL0ihLwOTXbt+LRt4 YQV2OJW/AFN9YxofSGkagVIejEN/bDrKVtB3Cc2BacSf3AwdmW/J+C+CbufBn2yllKzU xln2COkYZS+3Fsio6creddAGYoL/XOqOkD7wn/F4Zj7DV3pScC92IOSlSrVkODAgX420 pDSrAVaDoXUmT6sYgLkaTWqP6hkOukTCG5S0Sn4xUnjG2Ke4EvN7OrFcaGsSQklXkAWm moOg== X-Gm-Message-State: ALQs6tA2MH9gidYuKeThlh7fPyAWVM/cFZHplIIjcNq0cyL8gVh5qcN1 qA5DMZ6NV46nhmyZSAlH+LY= X-Google-Smtp-Source: AB8JxZpy3ZG+AvW98UOlur+YH9AjS8vJvUCr0wQtN+ZLUS/rFEBgEz+Tz3vWvqU/nR9z64Fcx++smA== X-Received: by 2002:adf:9745:: with SMTP id r63-v6mr12013303wrb.57.1525171630043; Tue, 01 May 2018 03:47:10 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id t46-v6sm12613506wrc.95.2018.05.01.03.47.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:47:09 -0700 (PDT) From: luca.boccassi@gmail.com To: Chas Williams Cc: Radu Nicolau , dpdk stable Date: Tue, 1 May 2018 11:44:46 +0100 Message-Id: <20180501104509.17238-23-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bonding: fix setting VLAN ID on slave ports' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:47:10 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 064d2c44a801a9d0a34a1b3ca498d698dd90596c Mon Sep 17 00:00:00 2001 From: Chas Williams Date: Tue, 3 Apr 2018 12:01:22 -0400 Subject: [PATCH] net/bonding: fix setting VLAN ID on slave ports [ upstream commit 3639903f488976e61752103bed546d5b87147ad0 ] The pos returned is just the offset of the slab. You need to use this to offset the bits in the slab. Fixes: c771e4ef38 ("net/bonding: enable slave VLAN filter") Signed-off-by: Chas Williams Acked-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_api.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index 4b6f1471c..7bb2fe1ec 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -361,9 +361,12 @@ slave_vlan_filter_set(uint8_t bonded_port_id, uint8_t slave_port_id) for (i = 0, mask = 1; i < RTE_BITMAP_SLAB_BIT_SIZE; i ++, mask <<= 1) { - if (unlikely(slab & mask)) + if (unlikely(slab & mask)) { + uint16_t vlan_id = pos + i; + res = rte_eth_dev_vlan_filter(slave_port_id, - (uint16_t)pos, 1); + vlan_id, 1); + } } found = rte_bitmap_scan(internals->vlan_filter_bmp, &pos, &slab); -- 2.14.2