From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 9260F2B86 for ; Tue, 1 May 2018 12:47:16 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id a67so9627312wmf.3 for ; Tue, 01 May 2018 03:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eL9+vWsdPGhxr3ekWFCSmnY/mI5C8XfvFGVWML4p9gA=; b=vgnWssSEw7VVWlRd61kVDKA6p7l5NqCFf+U49NjAJAAkXkXHil3PzAn+vzaBZptNww aHBSwIvfEtxAt87awiHy7yRrq+oFP24dpwQxXtxiH8oqXiWrL9TUnntRZym1Ug2db0IL RepS85IN/CQ/S1Kewv/0ukbgDeoctM3FPY6EkijMsudbUsfvZRAp1XHWcjqc3QXCK5od svZB2AesyJmG7mGCW0CLnriRH55qqt9X8cT70xxBFpka2qZ4g6RZkD6wyDMcgpQybBvv oFVjqopJC14PJAPUgNo0nFF7ylK3vKQBh/PnDXcl/L9QoDXVMqRxknz5NmvXbeOfzTa8 LpvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eL9+vWsdPGhxr3ekWFCSmnY/mI5C8XfvFGVWML4p9gA=; b=k/AORq/6EZ/0zSY6iy38JjSswbWSxRSEZduhZTL0sN8QM+p95I0hFhfF0YdfVGRmZo m8mDzU59Ebvron/o2N/ukysHqPhaMFWWpohFtVbjeIkaWZmvKjoXMhWq/iuAPYpTYGI/ q0kMU5r0o/HcvkwU2BCQFW63l+16uMeL/PMDLxw+vor0uTPQq+iL5T57E9zIXmCDBnFV faAYaNJX/elCfEpZ/GZrV4C6PkBbE+0sMIvNQQ5kkSL03/LGZ9uQ90WnELnZOQ95y4Vu Fesvvg+2re8nsrwetm7i2MQyANWJgIFIw3XtK48B4aASCgrowSyg9kDLY25lDTZpE63z BFqA== X-Gm-Message-State: ALQs6tAlP//vbcj+4V93sA9gns6WYzdxBUh60yApI2LClyG7OxIniTrj izJnso44paqgo68qEaxwqUg= X-Google-Smtp-Source: AB8JxZq1IJRpixrdOeatWJ2iSsMPoScnZWkI7PdN8crT6WBJjNmvRVS+4xemuHEIKhlLhMHGYDkIvw== X-Received: by 10.28.137.129 with SMTP id l123mr10341235wmd.160.1525171636178; Tue, 01 May 2018 03:47:16 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id o12-v6sm8986241wri.78.2018.05.01.03.47.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:47:15 -0700 (PDT) From: luca.boccassi@gmail.com To: John Daley Cc: Hyong Youb Kim , dpdk stable Date: Tue, 1 May 2018 11:44:50 +0100 Message-Id: <20180501104509.17238-27-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/enic: fix crash on MTU update with non-setup queues' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:47:16 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From a79ae67733089400f81ab9ecec81e464e60512df Mon Sep 17 00:00:00 2001 From: John Daley Date: Wed, 4 Apr 2018 16:54:53 -0700 Subject: [PATCH] net/enic: fix crash on MTU update with non-setup queues [ upstream commit 33a2d6594945eb3278bfa441f79ae9a38ea538a0 ] The enic code called from rte_eth_dev_set_mtu() was assuming that the Rx queues are already set up via a call to rte_eth_tx_queue_setup(). OVS calls rte_eth_dev_set_mtu() before rte_eth_rx_queue_setup() and a null pointer was dereferenced. Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update") Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/enic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index bcac51b55..ef5ecd44e 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1254,6 +1254,8 @@ int enic_set_mtu(struct enic *enic, uint16_t new_mtu) /* free and reallocate RQs with the new MTU */ for (rq_idx = 0; rq_idx < enic->rq_count; rq_idx++) { rq = &enic->rq[enic_rte_rq_idx_to_sop_idx(rq_idx)]; + if (!rq->in_use) + continue; enic_free_rq(rq); rc = enic_alloc_rq(enic, rq_idx, rq->socket_id, rq->mp, -- 2.14.2