From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id EB3ED2B82 for ; Tue, 1 May 2018 12:47:22 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id f8so7934335wmc.4 for ; Tue, 01 May 2018 03:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=meIsbDSzIEu3JFljgAJmZmN9Jit/aBsABX79omorIRs=; b=kJZSGmWswXqpIaZO+QWqVC1iYbXsJEI/cULGUrjbUL5oIg6GWiT1ytCGrbSFdJ8gw3 tR4Wlugwn77Gax21u/cqrzvJlANzzEGio9egzrDwjUbACFSyoja1CCNPMDyu8cH4ppt+ 4fWdz+bjYefSNU8Ac3l4KPzxUwYs2eOgQ6QH+AkB0j4oXIyPhi4VjUsNT5pORSESaPeJ FPVojYKukHN/EpyZaSxZGEFT6b31+smYf8kqEQit6MC29Vna7B5C0k7T5ZW41sNd4BXL rJvy1ztByfhpxk5ASIuxtmErLQNrU7pLon3aD1umzgLlN4jsx9E/8x0X+bT/sQVfMasZ l/YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=meIsbDSzIEu3JFljgAJmZmN9Jit/aBsABX79omorIRs=; b=D2sZtqdOMjS4Xw1xwOi1BRQWpPEMTdOGsom4EIkJZU74U6+tgB2149Tya0BfeZCKUP EgCOWNOr/KzuXrcOEttuSMTMBlTzks6oDqn2ULFsph9LRSqmEgWGbByKqKH+cwYBlwZN 8cq/enjQITaNnIbcxXNwTCf7YFmxwJaBtWZ8d1goRaUSM5gqGzCCkHDa50uLRT1GUe0l ZgSKXb8KX8Mr/48RtOWZAZkn+iERK/3LpVhiWEgS8px7U4cqIlM6E203Gs2uMYUaqgu7 xfaokdqxIorz0s6JovXaUC7EDYfSFes4jehFU0kvDsah4KEcRlltJtkVVNZ1fNNf2gbA EjyA== X-Gm-Message-State: ALQs6tB3bNRlGg13knwSxMHkYHIIICqMjtqo8BWkA6JH3xiyMHQuyF9W 47A5KhQUWKseR6J1jaFCAVb5GJCviyo= X-Google-Smtp-Source: AB8JxZo272ljF4RdZGlCJiO+S6Ng05QBKo+FlsAgGlnD/Thtya7H78AfdgRWcPdBMSPqndzWzoyQXw== X-Received: by 10.28.122.11 with SMTP id v11mr9965567wmc.58.1525171642137; Tue, 01 May 2018 03:47:22 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id l53-v6sm27343510wrc.80.2018.05.01.03.47.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:47:21 -0700 (PDT) From: luca.boccassi@gmail.com To: Thomas Monjalon Cc: Olivier Matz , dpdk stable Date: Tue, 1 May 2018 11:44:54 +0100 Message-Id: <20180501104509.17238-31-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'mbuf: fix Tx checksum offload API doc' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:47:23 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 24e25138d6ca6b5bd9b20a8ba05fac67c74deda4 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Fri, 20 Apr 2018 01:39:52 +0200 Subject: [PATCH] mbuf: fix Tx checksum offload API doc [ upstream commit f00dcb7b0a74928b8b846f73b37386d7b1bb4869 ] When introducing rte_eth_tx_prepare(), the constraints on checksum pre-filling for Tx offloads were relaxed because implemented in the PMDs with rte_net_intel_cksum_flags_prepare() helper. As a consequence, these old requirements are removed for: - PKT_TX_OUTER_IP_CKSUM - PKT_TX_IP_CKSUM - PKT_TX_[L4]_CKSUM - PKT_TX_TCP_SEG Not sure SCTP offload is properly implemented though. A reference to rte_eth_tx_prepare() is added in rte_eth_tx_burst() doc. Fixes: 609dd68ef14f ("mbuf: enhance the API documentation of offload flags") Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") Signed-off-by: Thomas Monjalon Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index bc015d033..b6a01c992 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -204,12 +204,8 @@ extern "C" { * - set the PKT_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies * PKT_TX_TCP_CKSUM) * - set the flag PKT_TX_IPV4 or PKT_TX_IPV6 - * - if it's IPv4, set the PKT_TX_IP_CKSUM flag and write the IP checksum - * to 0 in the packet + * - if it's IPv4, set the PKT_TX_IP_CKSUM flag * - fill the mbuf offload information: l2_len, l3_len, l4_len, tso_segsz - * - calculate the pseudo header checksum without taking ip_len in account, - * and set it in the TCP header. Refer to rte_ipv4_phdr_cksum() and - * rte_ipv6_phdr_cksum() that can be used as helpers. */ #define PKT_TX_TCP_SEG (1ULL << 50) @@ -222,9 +218,6 @@ extern "C" { * - fill l2_len and l3_len in mbuf * - set the flags PKT_TX_TCP_CKSUM, PKT_TX_SCTP_CKSUM or PKT_TX_UDP_CKSUM * - set the flag PKT_TX_IPV4 or PKT_TX_IPV6 - * - calculate the pseudo header checksum and set it in the L4 header (only - * for TCP or UDP). See rte_ipv4_phdr_cksum() and rte_ipv6_phdr_cksum(). - * For SCTP, set the crc field to 0. */ #define PKT_TX_L4_NO_CKSUM (0ULL << 52) /**< Disable L4 cksum of TX pkt. */ #define PKT_TX_TCP_CKSUM (1ULL << 52) /**< TCP cksum of TX pkt. computed by NIC. */ @@ -236,7 +229,6 @@ extern "C" { * Offload the IP checksum in the hardware. The flag PKT_TX_IPV4 should * also be set by the application, although a PMD will only check * PKT_TX_IP_CKSUM. - * - set the IP checksum field in the packet to 0 * - fill the mbuf offload information: l2_len, l3_len */ #define PKT_TX_IP_CKSUM (1ULL << 54) @@ -261,10 +253,8 @@ extern "C" { /** * Offload the IP checksum of an external header in the hardware. The - * flag PKT_TX_OUTER_IPV4 should also be set by the application, alto ugh - * a PMD will only check PKT_TX_IP_CKSUM. The IP checksum field in the - * packet must be set to 0. - * - set the outer IP checksum field in the packet to 0 + * flag PKT_TX_OUTER_IPV4 should also be set by the application, although + * a PMD will only check PKT_TX_OUTER_IP_CKSUM. * - fill the mbuf offload information: outer_l2_len, outer_l3_len */ #define PKT_TX_OUTER_IP_CKSUM (1ULL << 58) -- 2.14.2