From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 1AB5A2B82 for ; Tue, 1 May 2018 12:47:41 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id l1so18504951wmb.2 for ; Tue, 01 May 2018 03:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rvu6i2qiqDGE+q1ZaZIBaY0GBGK8roecyzMgIQZKsJA=; b=Hs0ll4i2jyQBDkQ/OzGTUImwyAmy721KLZqBotuInamma/58iJ7WcK/qCbLgXOIrQM 29dgGudcqDma5akknBS88UVNbQutzCSqYvTiBVLxqaDn8pBat2SvMW/q6sx0kfuYBqd/ xNSgy2Pu4esiIrS6FhsiLscfQKCcvlo2NsOHLMd4DNLcmwYZbmMFocejE1ol44LqfkNB Q+ANsJyuH6yI7lCjJKgkqi96dR7JHpXTTpmc/uCiQbLYkpOxZNJCJGSFSsaKJJTHHpEV 4ZCvtLzEDjcyhfQJ0RjPwZj0TXwB8BN6A6989TxdGYQjzZeps3hXyBIL6moR/RTKK52/ DTLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rvu6i2qiqDGE+q1ZaZIBaY0GBGK8roecyzMgIQZKsJA=; b=Qf9oU0QoXLzJFUI+qEx6yWNqhTO/ilL/san58CUUDtMUwfcPqZvD7Gs0Vhs2FZONjn ykd6/L7xEjcjFvJwNy5JOBwQoYMEksJrKtRdPvytArgfXn/Pj81ZqDu9pDtWPjuXEDxn 4QGMuri2pa3n1B871+JoNhukhzH1FFCEj4Srao8l4BJkHH4mjV+cEJIpoRpNd2uJ6Z0h WkrUjRfbq2uFEJ7o4oUmvvzL/3D7zKZEXx35qs1gnpNLFeHIIKJBy0D5wq8Ak8ZdMNfw OgEvyWbsAMfeSxIcX3kEHYEDvPw5ndRYFUW73JoLIK9WgZ8AiuqGcuP+1lyNVLyQ1ctn SVDQ== X-Gm-Message-State: ALQs6tBMhM/oRitWCb835uFI/OO3T41WgavN3xr7/Aaqkd+K4wDIRTym V7aF+zKG3KvndWJXmyDRDg8= X-Google-Smtp-Source: AB8JxZo2zlEw/Bje+fMEFal0vJJzA6WCuW4QxTtX8Gqcd/vJCu/tO4q5CjFEq+Zqxg8QkmutHZyHcQ== X-Received: by 10.28.133.12 with SMTP id h12mr10826270wmd.136.1525171660812; Tue, 01 May 2018 03:47:40 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id k30-v6sm16468010wrf.17.2018.05.01.03.47.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:47:39 -0700 (PDT) From: luca.boccassi@gmail.com To: Chas Williams Cc: Yong Wang , dpdk stable Date: Tue, 1 May 2018 11:45:05 +0100 Message-Id: <20180501104509.17238-42-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/vmxnet3: keep link state consistent' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:47:41 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 982600ace70b6ac6e308e9f50e42e967487183a8 Mon Sep 17 00:00:00 2001 From: Chas Williams Date: Sat, 17 Mar 2018 21:45:52 -0400 Subject: [PATCH] net/vmxnet3: keep link state consistent [ upstream commit 3a14b29bff9cc427920c83391b37cededa48fd2f ] The vmxnet3 never attempts link speed negotiation. As a virtual device the link speed is vague at best. However, it is important for certain applications, like bonding, to see a consistent link_status. 802.3ad requires that only links of the same cost (link speed) be enslaved. Keeping the link status consistent in vmxnet3 avoids races with bonding enslavement. Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") Signed-off-by: Chas Williams Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index effb360b4..4c898d8e2 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -794,7 +794,7 @@ vmxnet3_dev_link_update(struct rte_eth_dev *dev, link.link_status = ETH_LINK_UP; link.link_duplex = ETH_LINK_FULL_DUPLEX; link.link_speed = ETH_SPEED_NUM_10G; - link.link_autoneg = ETH_LINK_AUTONEG; + link.link_autoneg = ETH_LINK_FIXED; } vmxnet3_dev_atomic_write_link_status(dev, &link); -- 2.14.2