From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 20EAF2B82 for ; Tue, 1 May 2018 12:46:43 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id a67so9625781wmf.3 for ; Tue, 01 May 2018 03:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PM+VzOzZhhnkoN2YmrTMVtgUazUkykXI6BdWQOEVtLM=; b=PkjWGWnHhLgpol9RRsNZ4sO2pl2HuXSu++pl03vO4QV6DGjHJwBhxD5AyvOUyHVp8H vFYRt0ZBlp4f8UblTqreAopd4Bf5oNsd9VQFDdURkjOLXNfE/bowahB85kD+hr4mbOad NpQzH2Fq3HMQwqLm0hTmtHojnHCv1clm7hFqvLR7fqQkLsQJyg+TECz7FmC8cf/qePtt Gbs6VXWHzWiUgaVS8jKnlsdQUK3jnRNP43f194SUxmdRJVOhlhkMO6pGyES++hkRTDiL aQLTCIpMoBxP5fHrvo9uwHOrkJHoFm22qxOxhOE+j3No9WUChwaHVhb7wSePW5oCtRIV lGXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PM+VzOzZhhnkoN2YmrTMVtgUazUkykXI6BdWQOEVtLM=; b=BIvkYf/y85Kr7wjnXoMqFEG6CbV4qmV1KX+TLReckJzJHRVCLohyRQfnvJEhpKJGs5 S89IoUCX4W/3wBcbGjyEApajqPzOE1jPPomhsXvvlL0n3xDYuZNCfSoAacKUXXF1PXWV HPjyEhZa+1YabnM8jWHGMBPeqhr9LT3jHpGmN4miU6o6qbgfNgRXh49sUROnYTen1RNB i3jj7KE4skopmeUYjJv6PXXkvJJ8x4iwGBNyEVTFO2MpMNp1kLGMRjQ28eGzSdkGzC/1 HTLc303TmPsfso6yDmiIBxdp/pqAaDf9wAiHdKI/2L7YPCpcvSZeHgphJQIOzRRkLFhS j6nw== X-Gm-Message-State: ALQs6tDHGdsRNjrRx0/WboyTBr1XYwjE3K1G+/C3m9zB8y5xHjGQNPIH qA3rBcTvuZCFUaLTV4SQviQ= X-Google-Smtp-Source: AB8JxZq7PLhqJfkWbbzju4TY8EmS+i6HOA/TXMDP7riJH6u+uSMmk2L4I/WzhcwPQT/IPZPiKXaxhA== X-Received: by 10.28.32.84 with SMTP id g81mr8777701wmg.122.1525171602795; Tue, 01 May 2018 03:46:42 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id 42-v6sm16902170wrx.24.2018.05.01.03.46.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 03:46:41 -0700 (PDT) From: luca.boccassi@gmail.com To: Tomasz Kulasek Cc: Dariusz Stojaczyk , Jianfeng Tan , Maxime Coquelin , dpdk stable Date: Tue, 1 May 2018 11:44:30 +0100 Message-Id: <20180501104509.17238-7-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-1-luca.boccassi@gmail.com> References: <20180501104509.17238-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'vhost: fix device cleanup at stop' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 10:46:43 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/03/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 357f27736c79d0258409666277b6e113d11c757b Mon Sep 17 00:00:00 2001 From: Tomasz Kulasek Date: Fri, 9 Feb 2018 18:10:00 +0100 Subject: [PATCH] vhost: fix device cleanup at stop [ upstream commit ace7b6b7859e1dc410589610a8e436c1a3b430f3 ] This prevents from destroying & recreating user device in "incomplete" vring state. virtio_is_ready() was returning true for devices with vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL hasn't arrived yet) Fixes: 8f972312b8f4 ("vhost: support vhost-user") Signed-off-by: Dariusz Stojaczyk Signed-off-by: Tomasz Kulasek Reviewed-by: Jianfeng Tan Reviewed-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index abcb6ac14..0d30f11ef 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -800,6 +800,11 @@ vhost_user_get_vring_base(struct virtio_net *dev, vq->kickfd = VIRTIO_UNINITIALIZED_EVENTFD; + if (vq->callfd >= 0) + close(vq->callfd); + + vq->callfd = VIRTIO_UNINITIALIZED_EVENTFD; + if (dev->dequeue_zero_copy) free_zmbufs(vq); rte_free(vq->shadow_used_ring); -- 2.14.2