From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id CD903DD2 for ; Wed, 2 May 2018 16:24:08 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id v15-v6so14241575wrm.10 for ; Wed, 02 May 2018 07:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=5IT7gGZYw9YACvFPhpglg/8mz9EjzxwCDfs8b5MFkyk=; b=iF3ltoGtGgVgmNkFG/+7WplO962a6WJ/Vm/h+EW2hivrPDl0+It5WdpdHz4Ig+lLXZ HwYlTc2K7TSSCU7iTmV4aU+qkgfPgznRjfxg4KL6sOKshBboZuSsCxEo1pgCtN6pwMcQ df4JzCHNv9iPe3qkuPJPgoUHRW3LrK4hCncJVnKMNMjEDovu6r7GC2mPleG10hx/W/uY 41BMljVsC1tmfJHVc24UVQebE96kNP31pMBx+j9s31Rse4YovFz0vNPCuAwMIuJerX2/ dkxsGRHpt35QPVTuuF5Mame9Al5RM44HD1MgRTg6mHA/y/eTK99zijCbnE5Q1iNQ7/zz ZeeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=5IT7gGZYw9YACvFPhpglg/8mz9EjzxwCDfs8b5MFkyk=; b=Z+O6acCL0QHcXNb3K68Bx8/OX2S24Z6UUiv+0O7E7mqeC4lno+z02yBChkCPYWWCgf mWCKCZEwbMtSs5qnP/neO9Ie7oW8gtVfMcpY7x8n8YPD+tUif3Ej8ThPm/ltlEkzM5JN eRv7a+zpub+5E4dd+KGjp7eLjTVKAUj5GK/AwAGkewg6ZMgYwcVKL06W1mXED5nYChoX ODDUvUD3wfEb6UN0WrPfP9CipVyENW12BoOyec31F+/3DQBNx/N998WRoPEnTDWyiRJg asjpPb0k1OymdFdhJSgoK7xOl7Qom35Br+koCN/Q8xciJw1Qey0ekYgIqV+kdR+4hh7l lTEA== X-Gm-Message-State: ALQs6tAFNjk25AGpEIOPLDKgK1XV0ucBdr+H5LABBU5EjdDTjjKcTrQS fqq9QrrARYvGtmb+DeMzqqjMdQ== X-Google-Smtp-Source: AB8JxZrKWErBX9YmcvETU3hDH2/zOQhbxjKzoSHOE7ZtVNPFdZqyVzTGembAhODj/ywJKBuKH5lLdg== X-Received: by 2002:adf:a00d:: with SMTP id k13-v6mr14857660wrk.39.1525271048297; Wed, 02 May 2018 07:24:08 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k30-v6sm21492887wrf.17.2018.05.02.07.24.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 May 2018 07:24:07 -0700 (PDT) Date: Wed, 2 May 2018 16:23:53 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Luca Boccassi Cc: dpdk stable Message-ID: <20180502142353.vee3746dkcxy6unp@bidouze.vm.6wind.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> <20180430145402.23057-2-luca.boccassi@gmail.com> <20180502082602.bqg4ctdkyyaom6g2@bidouze.vm.6wind.com> <1525258673.23337.40.camel@debian.org> <20180502121645.cwdamjgmgwsfw5tw@bidouze.vm.6wind.com> <1525269747.23337.45.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1525269747.23337.45.camel@debian.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-stable] patch 'bus/vdev: fix find device implementation' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2018 14:24:09 -0000 On Wed, May 02, 2018 at 03:02:27PM +0100, Luca Boccassi wrote: > On Wed, 2018-05-02 at 14:16 +0200, Gaëtan Rivet wrote: > > On Wed, May 02, 2018 at 11:57:53AM +0100, Luca Boccassi wrote: > > > On Wed, 2018-05-02 at 10:26 +0200, Gaëtan Rivet wrote: > > > > Hi Luca, > > > > > > > > On Mon, Apr 30, 2018 at 03:53:21PM +0100, luca.boccassi@gmail.com > > > > wrote: > > > > > Hi, > > > > > > > > > > FYI, your patch has been queued to stable release 18.02.2 > > > > > > > > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stabl > > > > > e > > > > > yet. > > > > > It will be pushed if I get no objections before 05/02/18. So > > > > > please > > > > > shout if anyone has objections. > > > > > > > > This patch will be bogus while still compiling in a stable > > > > release, > > > > without the commit: 35f462839b69 ("bus/vdev: add lock on device > > > > list"). > > > > > > > > It should be slightly reworked to function without. The previous > > > > version > > > > of this patch [1] could be used instead. > > > > > > > > [1]: https://dpdk.org/ml/archives/dev/2018-April/098822.html > > > > > > > > Regards, > > > > > > Do you think it's worth including or can I skip it? > > > > > > > It is an actual bug with a simple fix, so I think it's worth > > including > > yes. > > This is the diff when removing v2 and applying v1 instead: > > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -397,7 +397,7 @@ vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp, > } > while (dev != NULL) { > if (cmp(&dev->device, data) == 0) > - break; > + return &dev->device; > dev = TAILQ_NEXT(dev, next); > } > return NULL; > > > Please let me know if this is correct. Thanks! Yes, in the end this is the only difference between the two versions (aside from context). This should be correct. -- Gaëtan Rivet 6WIND