From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 5CBA02BCE for ; Thu, 3 May 2018 13:59:59 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id j4so27908447wme.1 for ; Thu, 03 May 2018 04:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dqO/VVvNF8LIU0N8C6GY0YAsVFE053o5ErKcVcpQCXc=; b=vet683mddNk+D92mU2rD1nVo+ohD5ZLc/G9XO6pi0H8umZoYpyHRDgnH8FC3ZgUlJL 6+9ilMqJS+gmsQJPERPaq0mfehH6XLYu8vEEm1ZF/PCFEvXX7xKrfnurEylAvH8B0Xd1 4d02NMGMxnPtakB+o59vRzj6R47b24FJ3/oVaaH1xiw+sF1zI6o9EYamxuUh1TkvWktN dm6zRG6XAk0iSYS+d+mDP2r0/HselYIMyBRVSSv9f0Ml0bue0ogb1/5OwK5o52HlA6S/ TpeO6UgHQ84TmjdvyY1nTf3ALjyUAjGo6gAoCwdn3jngl2PWaoLnupRq8AWPiWorjk7V ty1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dqO/VVvNF8LIU0N8C6GY0YAsVFE053o5ErKcVcpQCXc=; b=TTdw/mW1tTnE5BjwnmQ0X5WZCxZJb8qYck0w22yTVaVT33pJkrLQeceR8KA3YWIPjy 30AgRcpRBNuxROKBlcZcNFF4TvzK9ZTeauGoEygNSocNu9WvTGefLErdjdcCUTBXkIPc EvaK8mPv/nHaMjoH6+ebV+z3D664XtZisD3/Pos93JoS6FsDmyi0zI/LPVyS4lGVaZtx 7tqtfi3jRBlt68Phr6Ntlar1OJgnOFcKnzfWamOOO5NrJs5W6c8Aj/aW95K9XYA0YkBj pbgE91czTjoiZZJBiNry02+6NNr8vGTzYtofgE8+GvOqQBIAN9i0qheVfSbnENNWWvJS DPEQ== X-Gm-Message-State: ALQs6tCSw5j7LFJMsN4Ykbu8AsJ2m0ZTNbTPWDrgWzTi+p0oqqmrlaHy jyt8UedznfnYh5jmcsuGOK/r5A== X-Google-Smtp-Source: AB8JxZr9kY4kZ3lC3VecwP8JkVNwDrfStrm6egNZDTrDHc4RVAd5Z3fFKluJrmFPtEsLAj8f8h+L6Q== X-Received: by 10.28.167.80 with SMTP id q77mr12386451wme.111.1525348799118; Thu, 03 May 2018 04:59:59 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q2-v6sm14160526wrm.26.2018.05.03.04.59.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 04:59:58 -0700 (PDT) Date: Thu, 3 May 2018 13:59:44 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Shahaf Shuler , dev@dpdk.org, stable@dpdk.org Message-ID: <20180503115818.19744-2-adrien.mazarguil@6wind.com> References: <20180503115818.19744-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180503115818.19744-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-stable] [PATCH 2/2] app/testpmd: fix weak RSS hash key for flow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 11:59:59 -0000 The default RSS hash key automatically provided by testpmd for RSS actions specified without one is so weak that traffic can't spread properly on L4 with it (as seen with TCPv6). It is only 30 bytes long, zero-padded to RSS_HASH_KEY_LENGTH (64 bytes), later truncated to 40 bytes for most PMDs. The presence of padding is really what kills balancing. This patch provides a full 64-byte (non-zero-terminated) string to address this issue. Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index f4ea0a5cf..9918d7fda 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -2772,7 +2772,8 @@ parse_vc_action_rss(struct context *ctx, const struct token *token, .key = action_rss_data->key, .queue = action_rss_data->queue, }, - .key = "testpmd's default RSS hash key", + .key = "testpmd's default RSS hash key, " + "override it for better balancing", .queue = { 0 }, }; for (i = 0; i < action_rss_data->conf.queue_num; ++i) -- 2.11.0