patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/bnx2x: fix for PCI FLR after ungraceful exit' has been queued to LTS release 17.11.3
Date: Sun,  6 May 2018 14:36:32 +0800	[thread overview]
Message-ID: <20180506063639.23196-19-yliu@fridaylinux.org> (raw)
In-Reply-To: <20180506063639.23196-1-yliu@fridaylinux.org>

Hi,

FYI, your patch has been queued to LTS release 17.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/09/18. So please
shout if anyone has objections.

Thanks.

	--yliu

---
>From 9e492ac6e7b204b97b13aaa102649f143aa54c0b Mon Sep 17 00:00:00 2001
From: Rasesh Mody <rasesh.mody@qlogic.com>
Date: Wed, 18 Apr 2018 13:15:08 -0700
Subject: [PATCH] net/bnx2x: fix for PCI FLR after ungraceful exit

[ upstream commit 66ba596aa6b5750b16549a322ef9a09fa7f0e3f6 ]

This patch provides a fix for PCI function level reset after an
ungraceful exit from an application. The fix is to enable internal
target read as part of device attach before getting device information
from device config space, device itself and shared memory. In addition
to that, add a 200ms delay for the recovery flow to complete.

Fixes: 540a211084a7 ("bnx2x: driver core")

Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
---
 drivers/net/bnx2x/bnx2x.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 9394f6c50..7927d2a67 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -8289,16 +8289,6 @@ static int bnx2x_get_device_info(struct bnx2x_softc *sc)
 			REG_WR(sc, PXP2_REG_PGL_ADDR_90_F1, 0);
 			REG_WR(sc, PXP2_REG_PGL_ADDR_94_F1, 0);
 		}
-
-/*
- * Enable internal target-read (in case we are probed after PF
- * FLR). Must be done prior to any BAR read access. Only for
- * 57712 and up
- */
-		if (!CHIP_IS_E1x(sc)) {
-			REG_WR(sc, PGLUE_B_REG_INTERNAL_PFID_ENABLE_TARGET_READ,
-			       1);
-		}
 	}
 
 	/* get the nvram size */
@@ -9675,7 +9665,17 @@ int bnx2x_attach(struct bnx2x_softc *sc)
 	bnx2x_init_rte(sc);
 
 	if (IS_PF(sc)) {
-/* get device info and set params */
+		/* Enable internal target-read (in case we are probed after PF
+		 * FLR). Must be done prior to any BAR read access. Only for
+		 * 57712 and up
+		 */
+		if (!CHIP_IS_E1x(sc)) {
+			REG_WR(sc, PGLUE_B_REG_INTERNAL_PFID_ENABLE_TARGET_READ,
+			       1);
+			DELAY(200000);
+		}
+
+		/* get device info and set params */
 		if (bnx2x_get_device_info(sc) != 0) {
 			PMD_DRV_LOG(NOTICE, "getting device info");
 			return -ENXIO;
@@ -9684,7 +9684,7 @@ int bnx2x_attach(struct bnx2x_softc *sc)
 /* get phy settings from shmem and 'and' against admin settings */
 		bnx2x_get_phy_info(sc);
 	} else {
-/* Left mac of VF unfilled, PF should set it for VF */
+		/* Left mac of VF unfilled, PF should set it for VF */
 		memset(sc->link_params.mac_addr, 0, ETHER_ADDR_LEN);
 	}
 
-- 
2.11.0

  parent reply	other threads:[~2018-05-06  6:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-06  6:36 [dpdk-stable] patch 'mbuf: fix Tx checksum offload API doc' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'mbuf: improve tunnel Tx offloads " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'app/crypto-perf: fix excess crypto device error' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'examples/l2fwd-crypto: fix the default aead assignments' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'crypto/zuc: do not set default op status' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'crypto/zuc: batch ops with same transform' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'crypto/dpaa2_sec: fix HMAC supported digest sizes' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'mk: fix make defconfig on FreeBSD' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'mempool: fix leak when no objects are populated' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'test: fix memory flags test for low NUMA nodes number' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'test/mempool: fix autotest retry' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'bus/pci: fix find device implementation' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/sfc: add missing Rx fini on RSS setup fail path' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/bnxt: set padding flags in Rx descriptor' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/bnxt: fix endianness of flag' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/bnxt: fix Rx checksum flags for tunnel frames' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/bnxt: free memory allocated for VF filters' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/ixgbe: enable vector PMD for icc 32 bits' " Yuanhan Liu
2018-05-06  6:36 ` Yuanhan Liu [this message]
2018-05-06  6:36 ` [dpdk-stable] patch 'net/bnxt: avoid invalid vnic id in set L2 Rx mask' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'app/testpmd: fix command token' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/nfp: fix mbufs releasing when stop or close' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/tap: fix icc build' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'drivers/net: fix link autoneg value for virtual PMDs' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/sfc: process RSS settings on Rx configure step' " Yuanhan Liu
2018-05-06  6:36 ` [dpdk-stable] patch 'net/sfc: ignore spec bits not covered by mask' " Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180506063639.23196-19-yliu@fridaylinux.org \
    --to=yliu@fridaylinux.org \
    --cc=rasesh.mody@qlogic.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).