From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3E59531FC for ; Sun, 6 May 2018 08:38:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E1D8B21C0B; Sun, 6 May 2018 02:38:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 06 May 2018 02:38:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4w5CIGN4q1NtdEBT4 NUwwKyXfBv7Z04Ttlk6ykqKfo0=; b=EQWfcJ0eMiDVYH0KFmjipSfgw7SOIeWzg p578fE/twXY9jeqz6kegz4aDD1B7aUkkOCGWz03bm8ncm3GJW/RXbNRbvzPqkZ3C b0JnwdjxWwELg+FtTqfTNgI9ff3Wh3myCbXRHzXBvXWTH/NZuAkQT86Y2T7XbKKc G2ASnl0ohnEUczfb/njDFvbQcmZHDduELtoDSFYgo9wY7qhf1H0ExCS7XUphTszz jnf50h3X09nWWO8AxN0QIbkDtmlqYZPyWtdIDLbrWpmKPHOusGkwzO4Q+vUWKJvM 3XywYITybVImiNlolpe/MZqpP9orRi6t6rpc7AazqPl4wuhBEcT/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=4w5CIGN4q1NtdEBT4NUwwKyXfBv7Z04Ttlk6ykqKfo0=; b=TxZE6FbB qWwqhp5f0x5+OeYUuICfXlGXIuLR6QeyeIZvUGF9cuA8xTP7YMeJbfXkANFCZbFw pS/PprI7Z0hrqAn4+QgqlWhMYymBanKmbvc4pLJIYzen8WtiEJgOJP1seOcJSKoH iI41y25bVpOr/C09GTgcLokoafTOTV/JVzcrEj6E9ZaIqU+I4S02IRNYLG9QWNy9 j45r5DH3HUbu99SjoMWKlXFQfwMqZdgAxWTXzCe7bbxu3qkHJq8hm7jrnzam1pPC QTYcAnrROqrDhvhZIhdR0sjyadOsvt+5Vk6yI4vuiGaI74s50JW4NgTSqNxZH5wR ZDu09yqHRKV6kw== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.102]) by mail.messagingengine.com (Postfix) with ESMTPA id 2B81510256; Sun, 6 May 2018 02:38:05 -0400 (EDT) From: Yuanhan Liu To: Ferruh Yigit Cc: Pablo de Lara , dpdk stable Date: Sun, 6 May 2018 14:36:36 +0800 Message-Id: <20180506063639.23196-23-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180506063639.23196-1-yliu@fridaylinux.org> References: <20180506063639.23196-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/tap: fix icc build' has been queued to LTS release 17.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2018 06:38:08 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/09/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 3ef1c8cf9c642c21c20e17bf41e19433fc8c2809 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 12 Mar 2018 19:31:33 +0000 Subject: [PATCH] net/tap: fix icc build [ upstream commit 6db80eb7c97e7db9c006641cc7ecae46c625d64e ] build error: .../dpdk/drivers/net/tap/rte_eth_tap.c(598): error #279: controlling expression is constant RTE_ASSERT(!"unsupported request type: must not happen"); Although RTE_ASSERT helps debugging this issue when assert enabled, constant expression in assert means this path can be taken during runtime and there is no protection against it when assert is disabled. Adding error log and error return back, replacing RTE_ASSERT. Fixes: 7748a4b44196 ("net/tap: add debug messages") Signed-off-by: Ferruh Yigit Acked-by: Pablo de Lara --- drivers/net/tap/rte_eth_tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index b8187f9b2..bf5506e4b 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -544,7 +544,9 @@ apply: case SIOCSIFMTU: break; default: - RTE_ASSERT(!"unsupported request type: must not happen"); + RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n", + pmd->name); + return -EINVAL; } if (ioctl(pmd->ioctl_sock, request, ifr) < 0) goto error; -- 2.11.0