From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5F7232E8F for ; Sun, 6 May 2018 08:38:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0EACC213A3; Sun, 6 May 2018 02:38:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 06 May 2018 02:38:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=cpFMjiIMIJMWNGrhB PmEzfXn21clWZ0KYz+duGN5+L4=; b=uGwTboOvidmXgLvxv+kQu5AbnKm0h8nOL mMk34XWlRVAdtj49HbSgsP/WqEF3xFjNUBY0lNsCz7lIRz3dXEad/KSIAbpRKdVv O9B2uE+JPBKtfQKvDvCWgIKa6eo3pJlNqNLcLM+N3CKKNNb7u2pUUG2lpIuAnawu yN7EgMuX6DYXItBSlVGWOp+xMMljDoCGGoj5JWypOEM4r/hoO1ExsKvw8bXYQoig 11YKY3WrBzY7wYn3FerDlOI4zyyubnvqYVNe88XbiBsjfRBIQSeGU/uB2+WF0yUH cSwgrtSsjSseoI6LC2t3vFvF0BCXQvocfMJbZUfmyY2MkjgtT4rzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=cpFMjiIMIJMWNGrhBPmEzfXn21clWZ0KYz+duGN5+L4=; b=lMx7piZ2 cfKjetdjCu1iNqnyyiwimTw0e8FyP8mmXezzageRVwWR7PSCkcuW0PK23/wpnHxp qfM81Tw9wcreFrVJlKj+u8WPZd8cW8OLJNsIXWu5snAEOub456DibhZIvCKscCOk qYAtNGhzqrkG99MELNQ+cTmu8bptjC/2UxBxRPLtGttj9GrJOKbgf2LANRziVkFU +VarKyr8GMXbn9CZjOcvozG0J8DKAGxM0VOgweBCafoFn1iuLm/MiZMfblUfrD3X OkdPYsSmQU7PU2sgT6R3lwa128jgA93GWYO0q5ud5+yLoMCRVnx93hGL9RsAHLvu ZcEvprWifZB45A== X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.102]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D6CE10256; Sun, 6 May 2018 02:38:08 -0400 (EDT) From: Yuanhan Liu To: Ferruh Yigit Cc: Thomas Monjalon , dpdk stable Date: Sun, 6 May 2018 14:36:37 +0800 Message-Id: <20180506063639.23196-24-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180506063639.23196-1-yliu@fridaylinux.org> References: <20180506063639.23196-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'drivers/net: fix link autoneg value for virtual PMDs' has been queued to LTS release 17.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2018 06:38:10 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/09/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 1bb4b0ec227b7e51d52a16065d835ce650c57d57 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 20 Apr 2018 01:01:24 +0100 Subject: [PATCH] drivers/net: fix link autoneg value for virtual PMDs [ upstream commit 18869f97f163a58d29d45a2e85c6ed444b1c72e1 ] These drivers never attempt link speed negotiation. Change link_autoneg value to ETH_LINK_FIXED to be more accurate and consistent between PMDs. Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon --- drivers/net/af_packet/rte_eth_af_packet.c | 2 +- drivers/net/kni/rte_eth_kni.c | 2 +- drivers/net/null/rte_eth_null.c | 2 +- drivers/net/pcap/rte_eth_pcap.c | 2 +- drivers/net/ring/rte_eth_ring.c | 2 +- drivers/net/softnic/rte_eth_softnic.c | 2 +- drivers/net/tap/rte_eth_tap.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index d51540898..5a101cef9 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -124,7 +124,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG + .link_autoneg = ETH_LINK_FIXED, }; static uint16_t diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index c1a2ea51d..5c7950117 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -90,7 +90,7 @@ static const struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG, + .link_autoneg = ETH_LINK_FIXED, }; static int is_kni_initialized; diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 726a5c5e4..7a5f12570 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -91,7 +91,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG, + .link_autoneg = ETH_LINK_FIXED, }; static uint16_t diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 3385d0439..39947105b 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -124,7 +124,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG, + .link_autoneg = ETH_LINK_FIXED, }; static int diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 8583a6735..dbd350e18 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -89,7 +89,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG + .link_autoneg = ETH_LINK_FIXED, }; static uint16_t diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c index c8f918df1..3c695e4da 100644 --- a/drivers/net/softnic/rte_eth_softnic.c +++ b/drivers/net/softnic/rte_eth_softnic.c @@ -551,7 +551,7 @@ pmd_ethdev_register(struct rte_vdev_device *vdev, soft_dev->data->dev_private = dev_private; soft_dev->data->dev_link.link_speed = hard_speed; soft_dev->data->dev_link.link_duplex = ETH_LINK_FULL_DUPLEX; - soft_dev->data->dev_link.link_autoneg = ETH_LINK_AUTONEG; + soft_dev->data->dev_link.link_autoneg = ETH_LINK_FIXED; soft_dev->data->dev_link.link_status = ETH_LINK_DOWN; soft_dev->data->mac_addrs = ð_addr; soft_dev->data->promiscuous = 1; diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index bf5506e4b..c38c02ef1 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -95,7 +95,7 @@ static struct rte_eth_link pmd_link = { .link_speed = ETH_SPEED_NUM_10G, .link_duplex = ETH_LINK_FULL_DUPLEX, .link_status = ETH_LINK_DOWN, - .link_autoneg = ETH_LINK_AUTONEG + .link_autoneg = ETH_LINK_FIXED, }; static void -- 2.11.0