From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 85DD0CF80 for ; Wed, 9 May 2018 11:31:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 294A12278A; Wed, 9 May 2018 05:31:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 05:31:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=jymKD/Z7Gg4dxj 5elUAwtIlQrQGlc41uNiIyGbbsupU=; b=W9GGIfk8IHr/TjP2uxv7RYScO8fbLV 8yeAl7/sGR1gcgCTK5D8KcDBltIJwd0hzSTEw09P3JdVbhjH10TRjF3H5KJUpH0T YqUgpj6NKENCYB+P6RLJp9nwKqGJT7PBuDGmwIPoBASe9vR8Peho7lydqPRXZhWh OjHexYrG3HJc0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=jymKD/Z7Gg4dxj5elUAwtIlQrQGlc41uNiIyGbbsupU=; b=Ad0NXhX4 zWtY8EAVq94MLokTeUDBh9n+lRaWNafmT9xW49HJzezlUdUb4NW8WmmpoIcI3pP2 WOVXS4fglSG0hU1UOJgfIuR8eaRumb3m4t3gy6H1NtFiL9ikDkP4QttQmY6nJKnX XMRzc5T/mFhPPE/ZXliER0TxTvItPuPP20KaJjdg93Cu6hDDq4Ihbyyb6qiJHKhR l8wNP7X5WZWd6ZFyMf2dNcNVpD5P3Y+op1yX0wLAcoCpyCi7rTHKA95jrHdtQmZf o1Vi+vOGXStn4O7H9AjEBCzn2TfjX1Df7aK0gQAS6q51W865v+EHhwefUueTwjXz Ow/e58iK/rT8fw== X-ME-Sender: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 684F2E4ED0; Wed, 9 May 2018 05:31:14 -0400 (EDT) From: Thomas Monjalon To: matan@mellanox.com Cc: stable@dpdk.org Date: Wed, 9 May 2018 11:30:56 +0200 Message-Id: <20180509093105.25984-3-thomas@monjalon.net> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180509093105.25984-1-thomas@monjalon.net> References: <20180509093105.25984-1-thomas@monjalon.net> Subject: [dpdk-stable] [PATCH 02/11] net/failsafe: fix sub-device visibility X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 09:31:15 -0000 The iterator function rte_eth_find_next_owned_by(), used by the iterator macro RTE_ETH_FOREACH_DEV_OWNED_BY, are ignoring the devices which are neither ATTACHED nor REMOVED. Thus sub-devices, having the state DEFERRED, cannot be seen with the ethdev iterator. The state RTE_ETH_DEV_DEFERRED can be replaced by RTE_ETH_DEV_ATTACHED + owner. Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad --- drivers/net/failsafe/failsafe_eal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c index ee89236f1..ce767703f 100644 --- a/drivers/net/failsafe/failsafe_eal.c +++ b/drivers/net/failsafe/failsafe_eal.c @@ -98,7 +98,6 @@ fs_bus_init(struct rte_eth_dev *dev) SUB_ID(sdev) = i; sdev->fs_dev = dev; sdev->dev = ETH(sdev)->device; - ETH(sdev)->state = RTE_ETH_DEV_DEFERRED; sdev->state = DEV_PROBED; } return 0; -- 2.16.2