From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 64BC31B7C2 for ; Tue, 15 May 2018 15:48:01 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id j5-v6so1227357wme.5 for ; Tue, 15 May 2018 06:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qbVrwVUdvHSudpUbd0iABXVaDWnyZ+oo9qQCdEMfenM=; b=A/0WXrAYUxsiAw1F3iY7MW/w5LzChM37OvLzHw76idoLMYmgdD0Roe4QDdE9ViQBxG A0HxpaJBFMPNyCcbbVzzReWpVf/zE2ANcCxp9nh4bVRwwmzcPAv8x25Qe/RzWOPpeTKL rYMdct8X1VMuOf1k+pYh4jU5ZPM86DJXjCDVbX45RREtplE0OOOXzhQzMY5U/M5J/ORF lAgjsCqA1Bxdl73jl+XQ2C560PtD0X/o5Y6r3ye23IdR6wfwYC/WjUAa8UbGDJjIwKIS QJmBW8RploA/DfT2g8uU9nr32j69NvgB0CnbstrtQS2o3YlY3gYdFuQXDHUPLxlNRPuG A3iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qbVrwVUdvHSudpUbd0iABXVaDWnyZ+oo9qQCdEMfenM=; b=rnHe/w13Rsj21G0k/FA8S0GWJ+KEKUxBZtx7DbD+eztrsUTWD1IizgV4NCJtKP3B3G uEJAmsUgfOLcmNrfBAzT3uwmEdac1p9mCQpggIDGLUYZYpKAgegvPb3bVBwCKI18Xxj4 dwyq0oV4MTueXSpO1WlYtfk5edi3dM3LXwklO0CFcilNSjerIbl3sLWXRweHcjFP0b1z /GwECDELNrbOkpyyWgYe9/dC3VNO8RjUQcMO1ddFDR6e0tjDUHWrJVkXWe6xPQGR2b4u q7EdYlGEZEYh0y4P5o2Pgwgru+WKL45l6Y5oWOsqLOmHC9sRhRWM8Ae75tvLHdEX4WIV msSQ== X-Gm-Message-State: ALKqPwd/g1k5VVWFT/vdnSv6FTnwHHRXcNxvyyS9rAreKOEgAx0ouNTa trCDMTgWmDf6lramizZsF1ogMTkm X-Google-Smtp-Source: AB8JxZq/yT28hN38EhGt31Dj9gCPAlu9vrMrthiRGw7LejXJexpHApUe9+DYyCFrEbKdw+2NHxz1tQ== X-Received: by 2002:a1c:6d90:: with SMTP id b16-v6mr7706846wmi.138.1526392081107; Tue, 15 May 2018 06:48:01 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id x65-v6sm711741wme.31.2018.05.15.06.48.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:48:00 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Stephen Hemminger , dpdk stable Date: Tue, 15 May 2018 14:46:23 +0100 Message-Id: <20180515134731.9337-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'eal: declare trace buffer at top of own block' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:48:01 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 138987e4f1a7a2683de2d4f4e2b671d69fcb6430 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Sat, 12 May 2018 09:59:32 +0800 Subject: [PATCH] eal: declare trace buffer at top of own block [ upstream commit e3908132b7903dbbf45c6d073792cccc890812e0 ] rte_dev.h:54:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; Fixes: b974e4a40cb5 ("ethdev: make error checking macros public") Signed-off-by: Andy Green Reviewed-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_dev.h | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index b688f1efd..984bbbbd6 100644 --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -32,15 +32,18 @@ rte_pmd_debug_trace(const char *func_name, const char *fmt, ...) va_start(ap, fmt); - char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; + { + char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; - va_end(ap); + va_end(ap); - va_start(ap, fmt); - vsnprintf(buffer, sizeof(buffer), fmt, ap); - va_end(ap); + va_start(ap, fmt); + vsnprintf(buffer, sizeof(buffer), fmt, ap); + va_end(ap); - rte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, "%s: %s", func_name, buffer); + rte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, "%s: %s", + func_name, buffer); + } } /* -- 2.14.2