From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id E8A6C1B854 for ; Tue, 15 May 2018 15:48:02 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id p4-v6so231554wrh.3 for ; Tue, 15 May 2018 06:48:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=++ywxoyEHlBPNZavS4nU1GepX+VuHyMjGTqp6lZhjkc=; b=MbzfMk3Lh0PBIddOPL1PMi4chq5ZobfPw7ocXVM5Gl/6umbLNoxYsN3fJ7GMsXKI1C rLqLx5t9uMiybF2JnfqMXnw0q7DPrR4Djbs+Tdok1CQEI6mO7azTeHEVI/X2KXGw4N23 YswdYw35hLkJ9dA9hqQNcLS1ggkVrtuP2qzWQzU9zrMTrrSJSzvAMSlFi6dwpiF60hQ0 ZlUhUbY9RlWtQOjlt9n+XkXpSu/MvWlBGzb370MRP/ydbVKT1HkcEPMJInokCoSQJJx7 xrn9tfmOUQk0uAL9Nzck9dkEq077KSlycFFNLbad673VEN/6t1/KjvBcT+k+g3jiPFST Utyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=++ywxoyEHlBPNZavS4nU1GepX+VuHyMjGTqp6lZhjkc=; b=VYQhDxYCe/LjT96KvK00t7wG01gCjKEiYCEc6/CsJXL/KbISHLgFzyLSz/W5jwXWQL C3QIiVx/9Xh+wyGQqSPoHS6UzhPqShQcgFtQPtES1G2SgT5r8HDKsNtQ96Nv9LNie68f jI5voIEL8JJcG8Cz82Yj7idWRqqDjlEKQwnW9xPA3ddb6vRkQn6as+BQ5TErHpBPSOfi U19MSFznbc3XBrMypmuBpm9xyH9jFQJvgtGMlUhGMN7J0mSb/FKU718IfkJlbau6wiRn QxtxTEq+hIBt0HgEuDWlZd7cpk+4DzVdEoxDN7Y7D4Uq1ofNQd44o34OOOFU6xMM+7Vc NFNA== X-Gm-Message-State: ALKqPwf396zcl9CFlxl3uPB8d+2zwOdz7obbmF/K+4nKRHAloEjXIIm0 aokM8fu2AktCien2LWWI9Qk= X-Google-Smtp-Source: AB8JxZpXegsmtvmFewBiVOlPqrXnZDknSTtWt0NFyCcCHrOwaw5YETR9EOdLDqJ2uxlaFj3q8CIPTQ== X-Received: by 2002:adf:b067:: with SMTP id g36-v6mr10533762wra.128.1526392082675; Tue, 15 May 2018 06:48:02 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id e50-v6sm184475wre.4.2018.05.15.06.48.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:48:01 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Stephen Hemminger , dpdk stable Date: Tue, 15 May 2018 14:46:24 +0100 Message-Id: <20180515134731.9337-13-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'spinlock/x86: move stack declaration before code' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:48:03 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 38e6012219fdf92d09c27a2f88ec77a8930f7d37 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Sat, 12 May 2018 09:59:17 +0800 Subject: [PATCH] spinlock/x86: move stack declaration before code [ upstream commit f7f18e92a51276f1e23a0595f59615f79323b358 ] In function 'rte_try_tm': rte_spinlock.h:82:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] int retries = RTE_RTM_MAX_RETRIES; Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86") Signed-off-by: Andy Green Reviewed-by: Stephen Hemminger --- lib/librte_eal/common/include/arch/x86/rte_spinlock.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/x86/rte_spinlock.h b/lib/librte_eal/common/include/arch/x86/rte_spinlock.h index 4b16887ea..60321da02 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_spinlock.h +++ b/lib/librte_eal/common/include/arch/x86/rte_spinlock.h @@ -76,10 +76,12 @@ static inline int rte_tm_supported(void) static inline int rte_try_tm(volatile int *lock) { + int retries; + if (!rte_rtm_supported) return 0; - int retries = RTE_RTM_MAX_RETRIES; + retries = RTE_RTM_MAX_RETRIES; while (likely(retries--)) { -- 2.14.2