From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 2A2E11B7A9 for ; Tue, 15 May 2018 15:48:10 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id m129-v6so1237954wmb.3 for ; Tue, 15 May 2018 06:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sCU7FT8nEvcpaT8/5FlT+dYJ3jkkYw/s/XitnO+Ye2s=; b=fXaP6hUYe++h+55ck8CVhX/IG0JR1PUbRbQeQAYbpUNcbdpXUd8f91dmczpArUUTKd 9AqEuvaGUQ5xCrYlHb5n7JgCS2/gdFU4keY3TY2TnJYvrA9SfUBYVMC2sLg8vIls5UHf KkhYg6zlMPbS6df1hjrCFT6o7S8V7zF+iVknioaE2PWNkSZVlpxIj7uW/YPlN3XOnGgi oq9yvC5h+EA2kikXtXfzWim79ByudUaX255XuUBZGTsWBB8chSLqP4g4yoRJxHwPcE2I LzMO4HEntnoa8x47Pl27+YlqAG/lcxBtiyt9ZEjnqPhjGTwN9fiK1/Sfi6GDGx29rzcO z0Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sCU7FT8nEvcpaT8/5FlT+dYJ3jkkYw/s/XitnO+Ye2s=; b=p1xbM4FLzU4xvu2KUCjpkyiNsrkoxqA6SPy5vAaqrvvemeHivdkzKWlqjVpdJjeWAj rQWl/+hMTIox3qDp94iCTKxG2m0acFjCR7cHP0lnYFptnvhTjYp9xTf5OXgE7WF/0EWj YKFZJMDa+h+aTCKmEtzDYoBesJxPOB+5wp2Haci2fGtatRGW/vMrjPZmDku2znRt+1yL YBDV1cX8WL/kOX4J7zWxt7bTShBhwj2nADjABxYQb13xaKEcJml/m1ktAzrGoMwDBtPq a9xl3Jhg4096C08V4tgnRYZs0xhq0432g0ejsSg1VSMTrKJsSmLu8YxUr4VLgRXlTyXc bcmg== X-Gm-Message-State: ALKqPweUPmEBOgfiDlJ6fAzNifamE/F9xzA6lnouDWs3cQVR20XgEom+ A2m1o0zHp9CgVQDz0LnPHf0= X-Google-Smtp-Source: AB8JxZp3iZco0r9yNHT0geNkCgy818KOM9x9B6ctfr+81FuMnwQow9rTJ3p6tYMFOC423H5NDijstw== X-Received: by 2002:a1c:5894:: with SMTP id m142-v6mr7772910wmb.10.1526392089824; Tue, 15 May 2018 06:48:09 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id 33-v6sm159388wrs.5.2018.05.15.06.48.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:48:08 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Stephen Hemminger , dpdk stable Date: Tue, 15 May 2018 14:46:27 +0100 Message-Id: <20180515134731.9337-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'hash: move stack declaration at top of CRC32c function' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:48:10 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 3527fcd0d017ded7f9e46dd8b8ea725c04d42057 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Sat, 12 May 2018 10:00:32 +0800 Subject: [PATCH] hash: move stack declaration at top of CRC32c function [ upstream commit f1eb05a1dc64e17bb9d9b6ad29b78f181aae36b8 ] In function 'crc32c_2words': rte_hash_crc.h:347:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] uint32_t crc, term1, term2; Fixes: d983cf41698f ("hash: add software CRC32 implementation") Signed-off-by: Andy Green Reviewed-by: Stephen Hemminger --- lib/librte_hash/rte_hash_crc.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h index 479f84b14..5f5fb3db1 100644 --- a/lib/librte_hash/rte_hash_crc.h +++ b/lib/librte_hash/rte_hash_crc.h @@ -338,14 +338,13 @@ crc32c_1word(uint32_t data, uint32_t init_val) static inline uint32_t crc32c_2words(uint64_t data, uint32_t init_val) { + uint32_t crc, term1, term2; union { uint64_t u64; uint32_t u32[2]; } d; d.u64 = data; - uint32_t crc, term1, term2; - crc = init_val; crc ^= d.u32[0]; -- 2.14.2